Diff
Modified: trunk/Source/WebCore/ChangeLog (138676 => 138677)
--- trunk/Source/WebCore/ChangeLog 2013-01-03 00:26:37 UTC (rev 138676)
+++ trunk/Source/WebCore/ChangeLog 2013-01-03 00:30:50 UTC (rev 138677)
@@ -1,3 +1,67 @@
+2013-01-02 Adam Barth <[email protected]>
+
+ [V8] There are some extra blank lines after removing INC_STATS
+ https://bugs.webkit.org/show_bug.cgi?id=105964
+
+ Reviewed by Ojan Vafai.
+
+ This patch is a followup to http://trac.webkit.org/changeset/138665
+ that removes some extra blank lines that sed wasn't smart enough to
+ delete for us.
+
+ * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
+ (WebCore::V8CSSStyleDeclaration::namedPropertyQuery):
+ * bindings/v8/custom/V8DOMFormDataCustom.cpp:
+ (WebCore::V8DOMFormData::appendCallback):
+ * bindings/v8/custom/V8DOMWindowCustom.cpp:
+ (WebCore::V8DOMWindow::addEventListenerCallback):
+ (WebCore::V8DOMWindow::removeEventListenerCallback):
+ (WebCore::V8DOMWindow::postMessageCallback):
+ * bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:
+ (WebCore::V8DedicatedWorkerContext::postMessageCallback):
+ * bindings/v8/custom/V8DocumentCustom.cpp:
+ (WebCore::V8Document::evaluateCallback):
+ * bindings/v8/custom/V8GeolocationCustom.cpp:
+ (WebCore::V8Geolocation::getCurrentPositionCallback):
+ (WebCore::V8Geolocation::watchPositionCallback):
+ * bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
+ (WebCore::V8HTMLAllCollection::namedPropertyGetter):
+ * bindings/v8/custom/V8HTMLCollectionCustom.cpp:
+ (WebCore::V8HTMLCollection::namedPropertyGetter):
+ * bindings/v8/custom/V8HTMLFormControlsCollectionCustom.cpp:
+ (WebCore::V8HTMLFormControlsCollection::namedPropertyGetter):
+ * bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
+ (WebCore::v8HTMLImageElementConstructorCallback):
+ * bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
+ (WebCore::V8HTMLOptionsCollection::namedPropertyGetter):
+ * bindings/v8/custom/V8MessagePortCustom.cpp:
+ (WebCore::V8MessagePort::postMessageCallback):
+ * bindings/v8/custom/V8NamedNodeMapCustom.cpp:
+ (WebCore::V8NamedNodeMap::namedPropertyGetter):
+ * bindings/v8/custom/V8NotificationCustom.cpp:
+ (WebCore::V8Notification::requestPermissionCallback):
+ * bindings/v8/custom/V8PopStateEventCustom.cpp:
+ (WebCore::V8PopStateEvent::stateAccessorGetter):
+ * bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:
+ (WebCore::V8SQLResultSetRowList::itemCallback):
+ * bindings/v8/custom/V8SQLTransactionCustom.cpp:
+ (WebCore::V8SQLTransaction::executeSqlCallback):
+ * bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:
+ (WebCore::V8SQLTransactionSync::executeSqlCallback):
+ * bindings/v8/custom/V8StorageCustom.cpp:
+ (WebCore::V8Storage::namedPropertyQuery):
+ * bindings/v8/custom/V8StyleSheetListCustom.cpp:
+ (WebCore::V8StyleSheetList::namedPropertyGetter):
+ * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
+ (WebCore::V8WebGLRenderingContext::getAttachedShadersCallback):
+ (WebCore::V8WebGLRenderingContext::getFramebufferAttachmentParameterCallback):
+ (WebCore::V8WebGLRenderingContext::getParameterCallback):
+ (WebCore::V8WebGLRenderingContext::getProgramParameterCallback):
+ (WebCore::V8WebGLRenderingContext::getShaderParameterCallback):
+ (WebCore::V8WebGLRenderingContext::getUniformCallback):
+ * bindings/v8/custom/V8WorkerCustom.cpp:
+ (WebCore::V8Worker::postMessageCallback):
+
2013-01-02 Alexey Proskuryakov <[email protected]>
[WK2 NetworkProcess] Uploading fails if a client modified the request
Modified: trunk/Source/WebCore/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp (138676 => 138677)
--- trunk/Source/WebCore/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp 2013-01-03 00:26:37 UTC (rev 138676)
+++ trunk/Source/WebCore/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp 2013-01-03 00:30:50 UTC (rev 138677)
@@ -181,7 +181,6 @@
v8::Handle<v8::Integer> V8CSSStyleDeclaration::namedPropertyQuery(v8::Local<v8::String> v8Name, const v8::AccessorInfo& info)
{
-
if (cssPropertyInfo(v8Name))
return v8Integer(0, info.GetIsolate());
Modified: trunk/Source/WebCore/bindings/v8/custom/V8DOMFormDataCustom.cpp (138676 => 138677)
--- trunk/Source/WebCore/bindings/v8/custom/V8DOMFormDataCustom.cpp 2013-01-03 00:26:37 UTC (rev 138676)
+++ trunk/Source/WebCore/bindings/v8/custom/V8DOMFormDataCustom.cpp 2013-01-03 00:30:50 UTC (rev 138677)
@@ -53,7 +53,6 @@
v8::Handle<v8::Value> V8DOMFormData::appendCallback(const v8::Arguments& args)
{
-
if (args.Length() < 2)
return throwError(v8SyntaxError, "Not enough arguments", args.GetIsolate());
Modified: trunk/Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp (138676 => 138677)
--- trunk/Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp 2013-01-03 00:26:37 UTC (rev 138676)
+++ trunk/Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp 2013-01-03 00:30:50 UTC (rev 138677)
@@ -227,7 +227,6 @@
v8::Handle<v8::Value> V8DOMWindow::addEventListenerCallback(const v8::Arguments& args)
{
-
String eventType = toWebCoreString(args[0]);
bool useCapture = args[2]->BooleanValue();
@@ -258,7 +257,6 @@
v8::Handle<v8::Value> V8DOMWindow::removeEventListenerCallback(const v8::Arguments& args)
{
-
String eventType = toWebCoreString(args[0]);
bool useCapture = args[2]->BooleanValue();
@@ -295,7 +293,6 @@
v8::Handle<v8::Value> V8DOMWindow::postMessageCallback(const v8::Arguments& args)
{
-
// None of these need to be RefPtr because args and context are guaranteed
// to hold on to them.
DOMWindow* window = V8DOMWindow::toNative(args.Holder());
Modified: trunk/Source/WebCore/bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp (138676 => 138677)
--- trunk/Source/WebCore/bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp 2013-01-03 00:26:37 UTC (rev 138676)
+++ trunk/Source/WebCore/bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp 2013-01-03 00:30:50 UTC (rev 138677)
@@ -43,7 +43,6 @@
v8::Handle<v8::Value> V8DedicatedWorkerContext::postMessageCallback(const v8::Arguments& args)
{
-
DedicatedWorkerContext* workerContext = V8DedicatedWorkerContext::toNative(args.Holder());
MessagePortArray ports;
ArrayBufferArray arrayBuffers;
Modified: trunk/Source/WebCore/bindings/v8/custom/V8DocumentCustom.cpp (138676 => 138677)
--- trunk/Source/WebCore/bindings/v8/custom/V8DocumentCustom.cpp 2013-01-03 00:26:37 UTC (rev 138676)
+++ trunk/Source/WebCore/bindings/v8/custom/V8DocumentCustom.cpp 2013-01-03 00:30:50 UTC (rev 138677)
@@ -66,7 +66,6 @@
v8::Handle<v8::Value> V8Document::evaluateCallback(const v8::Arguments& args)
{
-
RefPtr<Document> document = V8Document::toNative(args.Holder());
ExceptionCode ec = 0;
String _expression_ = toWebCoreString(args[0]);
Modified: trunk/Source/WebCore/bindings/v8/custom/V8GeolocationCustom.cpp (138676 => 138677)
--- trunk/Source/WebCore/bindings/v8/custom/V8GeolocationCustom.cpp 2013-01-03 00:26:37 UTC (rev 138676)
+++ trunk/Source/WebCore/bindings/v8/custom/V8GeolocationCustom.cpp 2013-01-03 00:30:50 UTC (rev 138677)
@@ -130,7 +130,6 @@
v8::Handle<v8::Value> V8Geolocation::getCurrentPositionCallback(const v8::Arguments& args)
{
-
bool succeeded = false;
RefPtr<PositionCallback> positionCallback = createFunctionOnlyCallback<V8PositionCallback>(args[0], succeeded, args.GetIsolate());
@@ -155,7 +154,6 @@
v8::Handle<v8::Value> V8Geolocation::watchPositionCallback(const v8::Arguments& args)
{
-
bool succeeded = false;
RefPtr<PositionCallback> positionCallback = createFunctionOnlyCallback<V8PositionCallback>(args[0], succeeded, args.GetIsolate());
Modified: trunk/Source/WebCore/bindings/v8/custom/V8HTMLAllCollectionCustom.cpp (138676 => 138677)
--- trunk/Source/WebCore/bindings/v8/custom/V8HTMLAllCollectionCustom.cpp 2013-01-03 00:26:37 UTC (rev 138676)
+++ trunk/Source/WebCore/bindings/v8/custom/V8HTMLAllCollectionCustom.cpp 2013-01-03 00:30:50 UTC (rev 138677)
@@ -74,7 +74,6 @@
v8::Handle<v8::Value> V8HTMLAllCollection::namedPropertyGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info)
{
-
if (!info.Holder()->GetRealNamedPropertyInPrototypeChain(name).IsEmpty())
return v8Undefined();
if (info.Holder()->HasRealNamedCallbackProperty(name))
Modified: trunk/Source/WebCore/bindings/v8/custom/V8HTMLCollectionCustom.cpp (138676 => 138677)
--- trunk/Source/WebCore/bindings/v8/custom/V8HTMLCollectionCustom.cpp 2013-01-03 00:26:37 UTC (rev 138676)
+++ trunk/Source/WebCore/bindings/v8/custom/V8HTMLCollectionCustom.cpp 2013-01-03 00:30:50 UTC (rev 138677)
@@ -45,7 +45,6 @@
v8::Handle<v8::Value> V8HTMLCollection::namedPropertyGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info)
{
-
if (!info.Holder()->GetRealNamedPropertyInPrototypeChain(name).IsEmpty())
return v8Undefined();
if (info.Holder()->HasRealNamedCallbackProperty(name))
Modified: trunk/Source/WebCore/bindings/v8/custom/V8HTMLFormControlsCollectionCustom.cpp (138676 => 138677)
--- trunk/Source/WebCore/bindings/v8/custom/V8HTMLFormControlsCollectionCustom.cpp 2013-01-03 00:26:37 UTC (rev 138676)
+++ trunk/Source/WebCore/bindings/v8/custom/V8HTMLFormControlsCollectionCustom.cpp 2013-01-03 00:30:50 UTC (rev 138677)
@@ -55,7 +55,6 @@
v8::Handle<v8::Value> V8HTMLFormControlsCollection::namedPropertyGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info)
{
-
if (!info.Holder()->GetRealNamedPropertyInPrototypeChain(name).IsEmpty())
return v8Undefined();
if (info.Holder()->HasRealNamedCallbackProperty(name))
Modified: trunk/Source/WebCore/bindings/v8/custom/V8HTMLImageElementConstructor.cpp (138676 => 138677)
--- trunk/Source/WebCore/bindings/v8/custom/V8HTMLImageElementConstructor.cpp 2013-01-03 00:26:37 UTC (rev 138676)
+++ trunk/Source/WebCore/bindings/v8/custom/V8HTMLImageElementConstructor.cpp 2013-01-03 00:30:50 UTC (rev 138677)
@@ -47,7 +47,6 @@
static v8::Handle<v8::Value> v8HTMLImageElementConstructorCallback(const v8::Arguments& args)
{
-
if (!args.IsConstructCall())
return throwTypeError("DOM object constructor cannot be called as a function.", args.GetIsolate());
Modified: trunk/Source/WebCore/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp (138676 => 138677)
--- trunk/Source/WebCore/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp 2013-01-03 00:26:37 UTC (rev 138676)
+++ trunk/Source/WebCore/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp 2013-01-03 00:30:50 UTC (rev 138677)
@@ -61,7 +61,6 @@
v8::Handle<v8::Value> V8HTMLOptionsCollection::namedPropertyGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info)
{
-
if (!info.Holder()->GetRealNamedPropertyInPrototypeChain(name).IsEmpty())
return v8Undefined();
if (info.Holder()->HasRealNamedCallbackProperty(name))
Modified: trunk/Source/WebCore/bindings/v8/custom/V8MessagePortCustom.cpp (138676 => 138677)
--- trunk/Source/WebCore/bindings/v8/custom/V8MessagePortCustom.cpp 2013-01-03 00:26:37 UTC (rev 138676)
+++ trunk/Source/WebCore/bindings/v8/custom/V8MessagePortCustom.cpp 2013-01-03 00:30:50 UTC (rev 138677)
@@ -42,7 +42,6 @@
v8::Handle<v8::Value> V8MessagePort::postMessageCallback(const v8::Arguments& args)
{
-
MessagePort* messagePort = V8MessagePort::toNative(args.Holder());
MessagePortArray portArray;
ArrayBufferArray arrayBufferArray;
Modified: trunk/Source/WebCore/bindings/v8/custom/V8NamedNodeMapCustom.cpp (138676 => 138677)
--- trunk/Source/WebCore/bindings/v8/custom/V8NamedNodeMapCustom.cpp 2013-01-03 00:26:37 UTC (rev 138676)
+++ trunk/Source/WebCore/bindings/v8/custom/V8NamedNodeMapCustom.cpp 2013-01-03 00:30:50 UTC (rev 138677)
@@ -54,7 +54,6 @@
v8::Handle<v8::Value> V8NamedNodeMap::namedPropertyGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info)
{
-
if (!info.Holder()->GetRealNamedPropertyInPrototypeChain(name).IsEmpty())
return v8Undefined();
if (info.Holder()->HasRealNamedCallbackProperty(name))
Modified: trunk/Source/WebCore/bindings/v8/custom/V8NotificationCustom.cpp (138676 => 138677)
--- trunk/Source/WebCore/bindings/v8/custom/V8NotificationCustom.cpp 2013-01-03 00:26:37 UTC (rev 138676)
+++ trunk/Source/WebCore/bindings/v8/custom/V8NotificationCustom.cpp 2013-01-03 00:30:50 UTC (rev 138677)
@@ -36,7 +36,6 @@
v8::Handle<v8::Value> V8Notification::requestPermissionCallback(const v8::Arguments& args)
{
-
bool succeeded = false;
RefPtr<V8NotificationPermissionCallback> callback = createFunctionOnlyCallback<V8NotificationPermissionCallback>(args[0], succeeded, args.GetIsolate());
if (!succeeded)
Modified: trunk/Source/WebCore/bindings/v8/custom/V8PopStateEventCustom.cpp (138676 => 138677)
--- trunk/Source/WebCore/bindings/v8/custom/V8PopStateEventCustom.cpp 2013-01-03 00:26:37 UTC (rev 138676)
+++ trunk/Source/WebCore/bindings/v8/custom/V8PopStateEventCustom.cpp 2013-01-03 00:30:50 UTC (rev 138677)
@@ -48,7 +48,6 @@
v8::Handle<v8::Value> V8PopStateEvent::stateAccessorGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info)
{
-
v8::Handle<v8::Value> result = info.Holder()->GetHiddenValue(V8HiddenPropertyName::state());
if (!result.IsEmpty())
Modified: trunk/Source/WebCore/bindings/v8/custom/V8SQLResultSetRowListCustom.cpp (138676 => 138677)
--- trunk/Source/WebCore/bindings/v8/custom/V8SQLResultSetRowListCustom.cpp 2013-01-03 00:26:37 UTC (rev 138676)
+++ trunk/Source/WebCore/bindings/v8/custom/V8SQLResultSetRowListCustom.cpp 2013-01-03 00:30:50 UTC (rev 138677)
@@ -40,7 +40,6 @@
v8::Handle<v8::Value> V8SQLResultSetRowList::itemCallback(const v8::Arguments& args)
{
-
if (!args.Length())
return throwError(v8SyntaxError, "Item index is required.", args.GetIsolate());
Modified: trunk/Source/WebCore/bindings/v8/custom/V8SQLTransactionCustom.cpp (138676 => 138677)
--- trunk/Source/WebCore/bindings/v8/custom/V8SQLTransactionCustom.cpp 2013-01-03 00:26:37 UTC (rev 138676)
+++ trunk/Source/WebCore/bindings/v8/custom/V8SQLTransactionCustom.cpp 2013-01-03 00:30:50 UTC (rev 138677)
@@ -48,7 +48,6 @@
v8::Handle<v8::Value> V8SQLTransaction::executeSqlCallback(const v8::Arguments& args)
{
-
if (args.Length() == 0)
return setDOMException(SYNTAX_ERR, args.GetIsolate());
Modified: trunk/Source/WebCore/bindings/v8/custom/V8SQLTransactionSyncCustom.cpp (138676 => 138677)
--- trunk/Source/WebCore/bindings/v8/custom/V8SQLTransactionSyncCustom.cpp 2013-01-03 00:26:37 UTC (rev 138676)
+++ trunk/Source/WebCore/bindings/v8/custom/V8SQLTransactionSyncCustom.cpp 2013-01-03 00:30:50 UTC (rev 138677)
@@ -48,7 +48,6 @@
v8::Handle<v8::Value> V8SQLTransactionSync::executeSqlCallback(const v8::Arguments& args)
{
-
if (!args.Length())
return setDOMException(SYNTAX_ERR, args.GetIsolate());
Modified: trunk/Source/WebCore/bindings/v8/custom/V8StorageCustom.cpp (138676 => 138677)
--- trunk/Source/WebCore/bindings/v8/custom/V8StorageCustom.cpp 2013-01-03 00:26:37 UTC (rev 138676)
+++ trunk/Source/WebCore/bindings/v8/custom/V8StorageCustom.cpp 2013-01-03 00:30:50 UTC (rev 138677)
@@ -99,7 +99,6 @@
v8::Handle<v8::Integer> V8Storage::namedPropertyQuery(v8::Local<v8::String> v8Name, const v8::AccessorInfo& info)
{
-
Storage* storage = V8Storage::toNative(info.Holder());
String name = toWebCoreString(v8Name);
Modified: trunk/Source/WebCore/bindings/v8/custom/V8StyleSheetListCustom.cpp (138676 => 138677)
--- trunk/Source/WebCore/bindings/v8/custom/V8StyleSheetListCustom.cpp 2013-01-03 00:26:37 UTC (rev 138676)
+++ trunk/Source/WebCore/bindings/v8/custom/V8StyleSheetListCustom.cpp 2013-01-03 00:30:50 UTC (rev 138677)
@@ -40,7 +40,6 @@
v8::Handle<v8::Value> V8StyleSheetList::namedPropertyGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info)
{
-
if (info.Holder()->HasRealNamedProperty(name))
return v8Undefined();
Modified: trunk/Source/WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp (138676 => 138677)
--- trunk/Source/WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp 2013-01-03 00:26:37 UTC (rev 138676)
+++ trunk/Source/WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp 2013-01-03 00:30:50 UTC (rev 138677)
@@ -272,7 +272,6 @@
v8::Handle<v8::Value> V8WebGLRenderingContext::getAttachedShadersCallback(const v8::Arguments& args)
{
-
if (args.Length() < 1)
return throwNotEnoughArgumentsError(args.GetIsolate());
@@ -312,7 +311,6 @@
v8::Handle<v8::Value> V8WebGLRenderingContext::getFramebufferAttachmentParameterCallback(const v8::Arguments& args)
{
-
if (args.Length() != 3)
return throwNotEnoughArgumentsError(args.GetIsolate());
@@ -329,7 +327,6 @@
v8::Handle<v8::Value> V8WebGLRenderingContext::getParameterCallback(const v8::Arguments& args)
{
-
if (args.Length() != 1)
return throwNotEnoughArgumentsError(args.GetIsolate());
@@ -344,7 +341,6 @@
v8::Handle<v8::Value> V8WebGLRenderingContext::getProgramParameterCallback(const v8::Arguments& args)
{
-
if (args.Length() != 2)
return throwNotEnoughArgumentsError(args.GetIsolate());
@@ -367,7 +363,6 @@
v8::Handle<v8::Value> V8WebGLRenderingContext::getShaderParameterCallback(const v8::Arguments& args)
{
-
if (args.Length() != 2)
return throwNotEnoughArgumentsError(args.GetIsolate());
@@ -403,7 +398,6 @@
v8::Handle<v8::Value> V8WebGLRenderingContext::getUniformCallback(const v8::Arguments& args)
{
-
if (args.Length() != 2)
return throwNotEnoughArgumentsError(args.GetIsolate());
Modified: trunk/Source/WebCore/bindings/v8/custom/V8WorkerCustom.cpp (138676 => 138677)
--- trunk/Source/WebCore/bindings/v8/custom/V8WorkerCustom.cpp 2013-01-03 00:26:37 UTC (rev 138676)
+++ trunk/Source/WebCore/bindings/v8/custom/V8WorkerCustom.cpp 2013-01-03 00:30:50 UTC (rev 138677)
@@ -47,7 +47,6 @@
v8::Handle<v8::Value> V8Worker::postMessageCallback(const v8::Arguments& args)
{
-
Worker* worker = V8Worker::toNative(args.Holder());
MessagePortArray ports;
ArrayBufferArray arrayBuffers;
