Title: [138968] trunk/Source/WebKit/blackberry
- Revision
- 138968
- Author
- [email protected]
- Date
- 2013-01-07 11:31:35 -0800 (Mon, 07 Jan 2013)
Log Message
[BlackBerry] Roll out r136173 as there are alternative approaches from the client sides now
https://bugs.webkit.org/show_bug.cgi?id=106236
Unreviewed, rolling out r136173.
This becomes unnecessary now as there are alternative approaches to
solve the issue from the client sides.
* WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::createWindow):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/ChangeLog (138967 => 138968)
--- trunk/Source/WebKit/blackberry/ChangeLog 2013-01-07 19:24:18 UTC (rev 138967)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2013-01-07 19:31:35 UTC (rev 138968)
@@ -1,3 +1,15 @@
+2013-01-07 Jacky Jiang <[email protected]>
+
+ [BlackBerry] Roll out r136173 as there are alternative approaches from the client sides now
+ https://bugs.webkit.org/show_bug.cgi?id=106236
+
+ Unreviewed, rolling out r136173.
+ This becomes unnecessary now as there are alternative approaches to
+ solve the issue from the client sides.
+
+ * WebCoreSupport/ChromeClientBlackBerry.cpp:
+ (WebCore::ChromeClientBlackBerry::createWindow):
+
2013-01-07 Jakob Petsovits <[email protected]>
[BlackBerry] Never avoid blitting when one-shot drawing sync is involved.
@@ -2032,26 +2044,6 @@
* Api/BlackBerryGlobal.cpp:
(BlackBerry::WebKit::globalInitialize):
-2012-11-29 Jacky Jiang <[email protected]>
-
- [BlackBerry] window.open can load url twice which can cause security and timing issues
- https://bugs.webkit.org/show_bug.cgi?id=103670
-
- Reviewed by Yong Li.
-
- PR: 252234
- When we call window.open() in JS, DOMWindow will create a window and
- change the url to load the resources. However, during the window
- creation, we dispatch an OpenWindow event with the url to browser side
- and browser side loads the url thereafter as well.
- DOMWindow::createWindow() is only required to create the window not to
- load url as far as I can tell. This is unneccessary and can cause
- unexpected issues. So just pass an empty url instead to avoid
- the double-load issue.
-
- * WebCoreSupport/ChromeClientBlackBerry.cpp:
- (WebCore::ChromeClientBlackBerry::createWindow):
-
2012-11-29 Otto Derek Cheung <[email protected]>
[BlackBerry] Modifying GeoClientBlackBerry to switch between high and low accuracy
Modified: trunk/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp (138967 => 138968)
--- trunk/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp 2013-01-07 19:24:18 UTC (rev 138967)
+++ trunk/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp 2013-01-07 19:31:35 UTC (rev 138968)
@@ -257,7 +257,7 @@
if (features.dialog)
flags |= WebPageClient::FlagWindowIsDialog;
- WebPage* webPage = m_webPagePrivate->m_client->createWindow(x, y, width, height, flags, BlackBerry::Platform::String::emptyString(), request.frameName());
+ WebPage* webPage = m_webPagePrivate->m_client->createWindow(x, y, width, height, flags, url.string(), request.frameName());
if (!webPage)
return 0;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
