Title: [138990] trunk/Source/WebCore
Revision
138990
Author
[email protected]
Date
2013-01-07 14:10:40 -0800 (Mon, 07 Jan 2013)

Log Message

Document::initSecurityContext() gives parent security context to iframes with invalid URLs.
https://bugs.webkit.org/show_bug.cgi?id=104960

Reviewed by Adam Barth.

Change covers the case of an invalid non-empty URL.  We know nothing
about that kind of URL and choose not to inherit origins.

* dom/Document.cpp:
(WebCore::shouldInheritSecurityOriginFromOwner):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (138989 => 138990)


--- trunk/Source/WebCore/ChangeLog	2013-01-07 22:09:16 UTC (rev 138989)
+++ trunk/Source/WebCore/ChangeLog	2013-01-07 22:10:40 UTC (rev 138990)
@@ -1,3 +1,16 @@
+2013-01-07  Tom Sepez  <[email protected]>
+
+        Document::initSecurityContext() gives parent security context to iframes with invalid URLs.
+        https://bugs.webkit.org/show_bug.cgi?id=104960
+
+        Reviewed by Adam Barth.
+
+        Change covers the case of an invalid non-empty URL.  We know nothing
+        about that kind of URL and choose not to inherit origins.
+        
+        * dom/Document.cpp:
+        (WebCore::shouldInheritSecurityOriginFromOwner):
+
 2013-01-07  Chris Fleizach  <[email protected]>
 
         AX: Regression: Contextual menu not following with VO cursor in HTML content when item is scrolled

Modified: trunk/Source/WebCore/dom/Document.cpp (138989 => 138990)


--- trunk/Source/WebCore/dom/Document.cpp	2013-01-07 22:09:16 UTC (rev 138989)
+++ trunk/Source/WebCore/dom/Document.cpp	2013-01-07 22:10:40 UTC (rev 138990)
@@ -339,7 +339,7 @@
     // Note: We generalize this to all "blank" URLs and invalid URLs because we
     // treat all of these URLs as about:blank.
     //
-    return !url.isValid() || url.isBlankURL();
+    return url.isEmpty() || url.isBlankURL();
 }
 
 static Widget* widgetForNode(Node* focusedNode)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to