Title: [139034] trunk
- Revision
- 139034
- Author
- [email protected]
- Date
- 2013-01-07 23:07:02 -0800 (Mon, 07 Jan 2013)
Log Message
[CoordinatedGraphics] compositing/repaint/resize-repaint.html is failing
https://bugs.webkit.org/show_bug.cgi?id=104637
Reviewed by Noam Rosenthal.
Source/WebKit2:
r137526 attempted to fix excessive repainting when compositing layers
change size. However, the fix did not suffice for ports using Coordinated
Graphics because CoordinatedGraphicsLayer::setSize() was calling
setNeedsDisplay() causing a full repaint.
This patch removes the call to setNeedsDisplay() in
CoordinatedGraphicsLayer::setSize() so that we don't unconditionally
repaint CoordinatedGraphics layers when their size changes.
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::setSize):
LayoutTests:
Unskip compositing/repaint/resize-repaint.html now that Coordinated
Graphics is no longer repainting unconditionally compositing layers
when their size changes.
* platform/efl-wk2/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (139033 => 139034)
--- trunk/LayoutTests/ChangeLog 2013-01-08 06:53:30 UTC (rev 139033)
+++ trunk/LayoutTests/ChangeLog 2013-01-08 07:07:02 UTC (rev 139034)
@@ -1,5 +1,18 @@
2013-01-07 Christophe Dumez <[email protected]>
+ [CoordinatedGraphics] compositing/repaint/resize-repaint.html is failing
+ https://bugs.webkit.org/show_bug.cgi?id=104637
+
+ Reviewed by Noam Rosenthal.
+
+ Unskip compositing/repaint/resize-repaint.html now that Coordinated
+ Graphics is no longer repainting unconditionally compositing layers
+ when their size changes.
+
+ * platform/efl-wk2/TestExpectations:
+
+2013-01-07 Christophe Dumez <[email protected]>
+
[CoordinatedGraphics] Support invalidation tracking for CoordinatedGraphicsLayer
https://bugs.webkit.org/show_bug.cgi?id=106002
Modified: trunk/LayoutTests/platform/efl-wk2/TestExpectations (139033 => 139034)
--- trunk/LayoutTests/platform/efl-wk2/TestExpectations 2013-01-08 06:53:30 UTC (rev 139033)
+++ trunk/LayoutTests/platform/efl-wk2/TestExpectations 2013-01-08 07:07:02 UTC (rev 139034)
@@ -368,9 +368,6 @@
Bug(EFL) svg/animations/animate-linear-discrete-additive-b.svg [ ImageOnlyFailure ]
Bug(EFL) svg/transforms/transformed-text-fill-pattern.html [ ImageOnlyFailure ]
-# New compositing test introduced in r137215 that is failing on WK2 EFL.
-webkit.org/b/104637 compositing/repaint/resize-repaint.html [ Failure ]
-
webkit.org/b/104656 compositing/repaint/clipped-layer-size-change.html [ ImageOnlyFailure Pass ]
# New compositing test introduced in r137828 that is failing on WK2 EFL.
Modified: trunk/Source/WebKit2/ChangeLog (139033 => 139034)
--- trunk/Source/WebKit2/ChangeLog 2013-01-08 06:53:30 UTC (rev 139033)
+++ trunk/Source/WebKit2/ChangeLog 2013-01-08 07:07:02 UTC (rev 139034)
@@ -1,5 +1,24 @@
2013-01-07 Christophe Dumez <[email protected]>
+ [CoordinatedGraphics] compositing/repaint/resize-repaint.html is failing
+ https://bugs.webkit.org/show_bug.cgi?id=104637
+
+ Reviewed by Noam Rosenthal.
+
+ r137526 attempted to fix excessive repainting when compositing layers
+ change size. However, the fix did not suffice for ports using Coordinated
+ Graphics because CoordinatedGraphicsLayer::setSize() was calling
+ setNeedsDisplay() causing a full repaint.
+
+ This patch removes the call to setNeedsDisplay() in
+ CoordinatedGraphicsLayer::setSize() so that we don't unconditionally
+ repaint CoordinatedGraphics layers when their size changes.
+
+ * WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:
+ (WebCore::CoordinatedGraphicsLayer::setSize):
+
+2013-01-07 Christophe Dumez <[email protected]>
+
[CoordinatedGraphics] Support invalidation tracking for CoordinatedGraphicsLayer
https://bugs.webkit.org/show_bug.cgi?id=106002
Modified: trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp (139033 => 139034)
--- trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp 2013-01-08 06:53:30 UTC (rev 139033)
+++ trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp 2013-01-08 07:07:02 UTC (rev 139034)
@@ -214,7 +214,7 @@
return;
GraphicsLayer::setSize(size);
- setNeedsDisplay();
+
if (maskLayer())
maskLayer()->setSize(size);
didChangeGeometry();
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
