Title: [139081] trunk/Source/WebCore
- Revision
- 139081
- Author
- [email protected]
- Date
- 2013-01-08 10:54:35 -0800 (Tue, 08 Jan 2013)
Log Message
[GTK] Build failures when building with python 3.3
https://bugs.webkit.org/show_bug.cgi?id=106194
Reviewed by Dirk Pranke.
Python 3.3 introduced changes to dictionaries which can result in changed
iteration order. More about these changes:
http://docs.python.org/3.3/whatsnew/3.3.html#pep-412-key-sharing-dictionary
http://www.python.org/dev/peps/pep-0412/#cons
This causes the Source/WebCore/inspector/generate-inspector-protocol-version
script to fail the self-testing when using Python 3.3. These changes work
around this problem by not checking for expected errors in order but rather
for their presence in the error output sequence. The number of actual errors
is also checked to be equal to the number of expected errors.
No new tests - no new functionality.
* inspector/generate-inspector-protocol-version:
(self_test):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (139080 => 139081)
--- trunk/Source/WebCore/ChangeLog 2013-01-08 18:49:48 UTC (rev 139080)
+++ trunk/Source/WebCore/ChangeLog 2013-01-08 18:54:35 UTC (rev 139081)
@@ -1,3 +1,26 @@
+2013-01-08 Zan Dobersek <[email protected]>
+
+ [GTK] Build failures when building with python 3.3
+ https://bugs.webkit.org/show_bug.cgi?id=106194
+
+ Reviewed by Dirk Pranke.
+
+ Python 3.3 introduced changes to dictionaries which can result in changed
+ iteration order. More about these changes:
+ http://docs.python.org/3.3/whatsnew/3.3.html#pep-412-key-sharing-dictionary
+ http://www.python.org/dev/peps/pep-0412/#cons
+
+ This causes the Source/WebCore/inspector/generate-inspector-protocol-version
+ script to fail the self-testing when using Python 3.3. These changes work
+ around this problem by not checking for expected errors in order but rather
+ for their presence in the error output sequence. The number of actual errors
+ is also checked to be equal to the number of expected errors.
+
+ No new tests - no new functionality.
+
+ * inspector/generate-inspector-protocol-version:
+ (self_test):
+
2013-01-08 Antoine Quint <[email protected]>
<track> element's mode set to "disabled" after load although it was explicitly set to "hidden"
Modified: trunk/Source/WebCore/inspector/generate-inspector-protocol-version (139080 => 139081)
--- trunk/Source/WebCore/inspector/generate-inspector-protocol-version 2013-01-08 18:49:48 UTC (rev 139080)
+++ trunk/Source/WebCore/inspector/generate-inspector-protocol-version 2013-01-08 18:54:35 UTC (rev 139081)
@@ -303,9 +303,9 @@
"Network.requestWillBeSent: required parameter is missing: postData",
"Network.requestWillBeSent: required parameter is missing: documentURL" ]
for i in range(len(errors)):
- if errors[i] != golden_errors[i]:
+ if errors[i] not in golden_errors:
return False
- return True
+ return len(errors) is len(golden_errors)
def main():
if not self_test():
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
