Title: [139102] trunk/Tools
- Revision
- 139102
- Author
- zandober...@gmail.com
- Date
- 2013-01-08 13:25:28 -0800 (Tue, 08 Jan 2013)
Log Message
[webkitpy] Call setup_test_run method of the parent Port interface when method is called on subclasses
https://bugs.webkit.org/show_bug.cgi?id=106364
Reviewed by Eric Seidel.
When the setup_test_run method is called on the subclasses of the base Port
interface, the parent method should also be called via super(), despite the
parent method not doing anything at the moment.
The according calls to super() are required in the ChromiumPort, EflPort
and GtkPort implementations.
* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort.setup_test_run):
* Scripts/webkitpy/layout_tests/port/efl.py:
(EflPort.setup_test_run):
* Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort.setup_test_run):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (139101 => 139102)
--- trunk/Tools/ChangeLog 2013-01-08 21:11:03 UTC (rev 139101)
+++ trunk/Tools/ChangeLog 2013-01-08 21:25:28 UTC (rev 139102)
@@ -1,3 +1,24 @@
+2013-01-08 Zan Dobersek <zandober...@gmail.com>
+
+ [webkitpy] Call setup_test_run method of the parent Port interface when method is called on subclasses
+ https://bugs.webkit.org/show_bug.cgi?id=106364
+
+ Reviewed by Eric Seidel.
+
+ When the setup_test_run method is called on the subclasses of the base Port
+ interface, the parent method should also be called via super(), despite the
+ parent method not doing anything at the moment.
+
+ The according calls to super() are required in the ChromiumPort, EflPort
+ and GtkPort implementations.
+
+ * Scripts/webkitpy/layout_tests/port/chromium.py:
+ (ChromiumPort.setup_test_run):
+ * Scripts/webkitpy/layout_tests/port/efl.py:
+ (EflPort.setup_test_run):
+ * Scripts/webkitpy/layout_tests/port/gtk.py:
+ (GtkPort.setup_test_run):
+
2013-01-08 Julie Parent <jpar...@chromium.org>
Dashboard cleanup: Remove globals g_buildersThatFailedToLoad and g_staleBuilders
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py (139101 => 139102)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py 2013-01-08 21:11:03 UTC (rev 139101)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py 2013-01-08 21:25:28 UTC (rev 139102)
@@ -288,6 +288,7 @@
}
def setup_test_run(self):
+ super(ChromiumPort, self).setup_test_run()
# Delete the disk cache if any to ensure a clean test run.
dump_render_tree_binary_path = self._path_to_driver()
cachedir = self._filesystem.dirname(dump_render_tree_binary_path)
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/efl.py (139101 => 139102)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/efl.py 2013-01-08 21:11:03 UTC (rev 139101)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/efl.py 2013-01-08 21:25:28 UTC (rev 139102)
@@ -52,6 +52,7 @@
return "--efl"
def setup_test_run(self):
+ super(EflPort, self).setup_test_run()
self._pulseaudio_sanitizer.unload_pulseaudio_module()
def setup_environ_for_server(self, server_name=None):
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py (139101 => 139102)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py 2013-01-08 21:11:03 UTC (rev 139101)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py 2013-01-08 21:25:28 UTC (rev 139102)
@@ -57,6 +57,7 @@
return 6 * 1000
def setup_test_run(self):
+ super(GtkPort, self).setup_test_run()
self._pulseaudio_sanitizer.unload_pulseaudio_module()
def clean_up_test_run(self):
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
