Title: [139139] trunk/Source/WebKit/chromium
- Revision
- 139139
- Author
- [email protected]
- Date
- 2013-01-08 17:41:13 -0800 (Tue, 08 Jan 2013)
Log Message
[Chromium] Hiding popups on mouse wheel should be handled by WebViewImpl
https://bugs.webkit.org/show_bug.cgi?id=106312
Reviewed by Kent Tamura.
We had to removed the code that closed popups on mouse wheel events from
content::RenderWidgetHostViewMac because it no longer had access to
child popups. WebViewImpl will hide the popups on mouse wheel events so
we can maintain the same behavior.
https://src.chromium.org/viewvc/chrome?view=rev&revision=175488
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleMouseWheel): Overriding so we can hide popups.
(WebKit):
* src/WebViewImpl.h:
Modified Paths
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (139138 => 139139)
--- trunk/Source/WebKit/chromium/ChangeLog 2013-01-09 01:36:28 UTC (rev 139138)
+++ trunk/Source/WebKit/chromium/ChangeLog 2013-01-09 01:41:13 UTC (rev 139139)
@@ -1,3 +1,22 @@
+2013-01-08 Keishi Hattori <[email protected]>
+
+ [Chromium] Hiding popups on mouse wheel should be handled by WebViewImpl
+ https://bugs.webkit.org/show_bug.cgi?id=106312
+
+ Reviewed by Kent Tamura.
+
+ We had to removed the code that closed popups on mouse wheel events from
+ content::RenderWidgetHostViewMac because it no longer had access to
+ child popups. WebViewImpl will hide the popups on mouse wheel events so
+ we can maintain the same behavior.
+
+ https://src.chromium.org/viewvc/chrome?view=rev&revision=175488
+
+ * src/WebViewImpl.cpp:
+ (WebKit::WebViewImpl::handleMouseWheel): Overriding so we can hide popups.
+ (WebKit):
+ * src/WebViewImpl.h:
+
2013-01-08 James Robinson <[email protected]>
[chromium] Remove transitional #defines from WebKit API headers
Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (139138 => 139139)
--- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2013-01-09 01:36:28 UTC (rev 139138)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2013-01-09 01:41:13 UTC (rev 139139)
@@ -647,6 +647,12 @@
#endif
}
+bool WebViewImpl::handleMouseWheel(Frame& mainFrame, const WebMouseWheelEvent& event)
+{
+ hidePopups();
+ return PageWidgetEventHandler::handleMouseWheel(mainFrame, event);
+}
+
void WebViewImpl::scrollBy(const WebPoint& delta)
{
WebMouseWheelEvent syntheticWheel;
Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.h (139138 => 139139)
--- trunk/Source/WebKit/chromium/src/WebViewImpl.h 2013-01-09 01:36:28 UTC (rev 139138)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.h 2013-01-09 01:41:13 UTC (rev 139139)
@@ -673,6 +673,7 @@
virtual void handleMouseLeave(WebCore::Frame&, const WebMouseEvent&) OVERRIDE;
virtual void handleMouseDown(WebCore::Frame&, const WebMouseEvent&) OVERRIDE;
virtual void handleMouseUp(WebCore::Frame&, const WebMouseEvent&) OVERRIDE;
+ virtual bool handleMouseWheel(WebCore::Frame&, const WebMouseWheelEvent&) OVERRIDE;
virtual bool handleGestureEvent(const WebGestureEvent&) OVERRIDE;
virtual bool handleKeyEvent(const WebKeyboardEvent&) OVERRIDE;
virtual bool handleCharEvent(const WebKeyboardEvent&) OVERRIDE;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
