Title: [139165] trunk/Source
- Revision
- 139165
- Author
- [email protected]
- Date
- 2013-01-08 22:42:55 -0800 (Tue, 08 Jan 2013)
Log Message
Remove unused/deprecated render() method in chromium WebKit API
https://bugs.webkit.org/show_bug.cgi?id=106399
Reviewed by Kent Tamura.
Source/Platform:
* chromium/public/WebAudioDevice.h:
Source/WebKit/chromium:
* src/AudioDestinationChromium.cpp:
* src/AudioDestinationChromium.h:
(AudioDestinationChromium):
Modified Paths
Diff
Modified: trunk/Source/Platform/ChangeLog (139164 => 139165)
--- trunk/Source/Platform/ChangeLog 2013-01-09 06:39:58 UTC (rev 139164)
+++ trunk/Source/Platform/ChangeLog 2013-01-09 06:42:55 UTC (rev 139165)
@@ -1,3 +1,12 @@
+2013-01-08 Chris Rogers <[email protected]>
+
+ Remove unused/deprecated render() method in chromium WebKit API
+ https://bugs.webkit.org/show_bug.cgi?id=106399
+
+ Reviewed by Kent Tamura.
+
+ * chromium/public/WebAudioDevice.h:
+
2013-01-08 James Robinson <[email protected]>
[chromium] Remove transitional #defines from WebKit API headers
Modified: trunk/Source/Platform/chromium/public/WebAudioDevice.h (139164 => 139165)
--- trunk/Source/Platform/chromium/public/WebAudioDevice.h 2013-01-09 06:39:58 UTC (rev 139164)
+++ trunk/Source/Platform/chromium/public/WebAudioDevice.h 2013-01-09 06:42:55 UTC (rev 139165)
@@ -41,9 +41,6 @@
public:
virtual void render(const WebVector<float*>& sourceData, const WebVector<float*>& destinationData, size_t numberOfFrames) { };
- // FIXME: to be removed once we switch over to newer render() method handling both audio output and (optional) input.
- virtual void render(const WebVector<float*>& audioData, size_t numberOfFrames) = 0;
-
protected:
virtual ~RenderCallback() { }
};
Modified: trunk/Source/WebKit/chromium/ChangeLog (139164 => 139165)
--- trunk/Source/WebKit/chromium/ChangeLog 2013-01-09 06:39:58 UTC (rev 139164)
+++ trunk/Source/WebKit/chromium/ChangeLog 2013-01-09 06:42:55 UTC (rev 139165)
@@ -1,3 +1,14 @@
+2013-01-08 Chris Rogers <[email protected]>
+
+ Remove unused/deprecated render() method in chromium WebKit API
+ https://bugs.webkit.org/show_bug.cgi?id=106399
+
+ Reviewed by Kent Tamura.
+
+ * src/AudioDestinationChromium.cpp:
+ * src/AudioDestinationChromium.h:
+ (AudioDestinationChromium):
+
2013-01-08 Yoshifumi Inoue <[email protected]>
Remove WebKit/chromium/src/DragScrollTimer.{cpp,h}
Modified: trunk/Source/WebKit/chromium/src/AudioDestinationChromium.cpp (139164 => 139165)
--- trunk/Source/WebKit/chromium/src/AudioDestinationChromium.cpp 2013-01-09 06:39:58 UTC (rev 139164)
+++ trunk/Source/WebKit/chromium/src/AudioDestinationChromium.cpp 2013-01-09 06:42:55 UTC (rev 139165)
@@ -145,27 +145,6 @@
m_fifo->consume(&m_renderBus, numberOfFrames);
}
-// Pulls on our provider to get the rendered audio stream.
-// FIXME: remove this method when the chromium-side switches over to the synchronized I/O render() method (above).
-void AudioDestinationChromium::render(const WebVector<float*>& audioData, size_t numberOfFrames)
-{
- bool isNumberOfChannelsGood = audioData.size() == numberOfChannels;
- if (!isNumberOfChannelsGood) {
- ASSERT_NOT_REACHED();
- return;
- }
-
- bool isBufferSizeGood = numberOfFrames == m_callbackBufferSize;
- if (!isBufferSizeGood) {
- ASSERT_NOT_REACHED();
- return;
- }
-
- m_renderBus.setChannelMemory(0, audioData[0], numberOfFrames);
- m_renderBus.setChannelMemory(1, audioData[1], numberOfFrames);
- m_fifo->consume(&m_renderBus, numberOfFrames);
-}
-
void AudioDestinationChromium::provideInput(AudioBus* bus, size_t framesToProcess)
{
AudioBus* sourceBus = 0;
Modified: trunk/Source/WebKit/chromium/src/AudioDestinationChromium.h (139164 => 139165)
--- trunk/Source/WebKit/chromium/src/AudioDestinationChromium.h 2013-01-09 06:39:58 UTC (rev 139164)
+++ trunk/Source/WebKit/chromium/src/AudioDestinationChromium.h 2013-01-09 06:42:55 UTC (rev 139165)
@@ -58,7 +58,6 @@
// WebKit::WebAudioDevice::RenderCallback
virtual void render(const WebKit::WebVector<float*>& sourceData, const WebKit::WebVector<float*>& audioData, size_t numberOfFrames);
- virtual void render(const WebKit::WebVector<float*>& audioData, size_t numberOfFrames);
// WebCore::AudioSourceProvider
virtual void provideInput(AudioBus*, size_t framesToProcess);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
