Title: [139478] trunk/Tools
- Revision
- 139478
- Author
- [email protected]
- Date
- 2013-01-11 11:58:00 -0800 (Fri, 11 Jan 2013)
Log Message
TestRunner leaks when running tests
https://bugs.webkit.org/show_bug.cgi?id=106683
Reviewed by Simon Fraser.
Remove extra ref() that we missed out on deleting when refactoring window.layoutTestController
to window.testRunner in r124705. This caused the TestRunner object to be leaked when running
tests.
* DumpRenderTree/TestRunner.cpp:
(TestRunner::makeWindowObject):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (139477 => 139478)
--- trunk/Tools/ChangeLog 2013-01-11 19:50:19 UTC (rev 139477)
+++ trunk/Tools/ChangeLog 2013-01-11 19:58:00 UTC (rev 139478)
@@ -1,3 +1,17 @@
+2013-01-11 Pratik Solanki <[email protected]>
+
+ TestRunner leaks when running tests
+ https://bugs.webkit.org/show_bug.cgi?id=106683
+
+ Reviewed by Simon Fraser.
+
+ Remove extra ref() that we missed out on deleting when refactoring window.layoutTestController
+ to window.testRunner in r124705. This caused the TestRunner object to be leaked when running
+ tests.
+
+ * DumpRenderTree/TestRunner.cpp:
+ (TestRunner::makeWindowObject):
+
2013-01-11 Julie Parent <[email protected]>
Dashboard Cleanup: Add isLoadingComplete to the loader.Loader object.
Modified: trunk/Tools/DumpRenderTree/TestRunner.cpp (139477 => 139478)
--- trunk/Tools/DumpRenderTree/TestRunner.cpp 2013-01-11 19:50:19 UTC (rev 139477)
+++ trunk/Tools/DumpRenderTree/TestRunner.cpp 2013-01-11 19:58:00 UTC (rev 139478)
@@ -2143,7 +2143,6 @@
{
JSRetainPtr<JSStringRef> testRunnerStr(Adopt, JSStringCreateWithUTF8CString("testRunner"));
ref();
- ref();
JSClassRef classRef = getJSClass();
JSValueRef layoutTestContollerObject = JSObjectMake(context, classRef, this);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
