Log Message
Explicitly set msvs_cygwin_shell to true for actions in WebKit https://bugs.webkit.org/show_bug.cgi?id=106706
Patch by Robert Iannucci <[email protected]> on 2013-01-11 Reviewed by Tony Chang. Currently, msvs_cygwin_shell is set to 1 by default. This patch explicitly sets it on the actions which will break if msvs_cygwin_shell were set to 0. This is in preparation for changing the default value of msvs_cygwin_shell, which in turn is in preparation of the removal of cygwin as a buld-system requirement. Since this change will have no semantic effect, no new tests are required. * WebCore.gyp/WebCore.gyp:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (139519 => 139520)
--- trunk/Source/WebCore/ChangeLog 2013-01-12 00:14:58 UTC (rev 139519)
+++ trunk/Source/WebCore/ChangeLog 2013-01-12 00:19:01 UTC (rev 139520)
@@ -1,3 +1,21 @@
+2013-01-11 Robert Iannucci <[email protected]>
+
+ Explicitly set msvs_cygwin_shell to true for actions in WebKit
+ https://bugs.webkit.org/show_bug.cgi?id=106706
+
+ Reviewed by Tony Chang.
+
+ Currently, msvs_cygwin_shell is set to 1 by default. This patch
+ explicitly sets it on the actions which will break if msvs_cygwin_shell
+ were set to 0. This is in preparation for changing the default value of
+ msvs_cygwin_shell, which in turn is in preparation of the removal of
+ cygwin as a buld-system requirement.
+
+ Since this change will have no semantic effect, no new tests are
+ required.
+
+ * WebCore.gyp/WebCore.gyp:
+
2013-01-11 Joshua Bell <[email protected]>
IndexedDB: IDBTransaction should manage lifetime of IDBRequests
Modified: trunk/Source/WebCore/WebCore.gyp/WebCore.gyp (139519 => 139520)
--- trunk/Source/WebCore/WebCore.gyp/WebCore.gyp 2013-01-12 00:14:58 UTC (rev 139519)
+++ trunk/Source/WebCore/WebCore.gyp/WebCore.gyp 2013-01-12 00:19:01 UTC (rev 139520)
@@ -401,6 +401,7 @@
'--output_cpp_dir', '<(SHARED_INTERMEDIATE_DIR)/webcore',
],
'message': 'Generating Inspector protocol sources from Inspector.json',
+ 'msvs_cygwin_shell': 1,
},
]
},
@@ -551,6 +552,7 @@
'--',
'<@(_inputs)',
],
+ 'msvs_cygwin_shell': 1,
},
]
},
@@ -708,6 +710,7 @@
],
}],
],
+ 'msvs_cygwin_shell': 1,
},
{
'action_name': 'CSSValueKeywords',
@@ -736,6 +739,7 @@
],
}],
],
+ 'msvs_cygwin_shell': 1,
},
{
'action_name': 'HTMLNames',
@@ -762,6 +766,7 @@
'--wrapperFactoryV8',
'--extraDefines', '<(feature_defines)'
],
+ 'msvs_cygwin_shell': 1,
},
{
'action_name': 'WebKitFontFamilyNames',
@@ -782,6 +787,7 @@
'--',
'--fonts',
],
+ 'msvs_cygwin_shell': 1,
},
{
'action_name': 'SVGNames',
@@ -809,6 +815,7 @@
'--wrapperFactoryV8',
'--extraDefines', '<(feature_defines)'
],
+ 'msvs_cygwin_shell': 1,
},
{
'action_name': 'EventFactory',
@@ -828,6 +835,7 @@
'--',
'<@(_inputs)',
],
+ 'msvs_cygwin_shell': 1,
},
{
'action_name': 'EventTargetFactory',
@@ -846,6 +854,7 @@
'--',
'<@(_inputs)',
],
+ 'msvs_cygwin_shell': 1,
},
{
'action_name': 'ExceptionCodeDescription',
@@ -866,6 +875,7 @@
'--',
'<@(_inputs)',
],
+ 'msvs_cygwin_shell': 1,
},
{
'action_name': 'MathMLNames',
@@ -890,6 +900,7 @@
'--factory',
'--extraDefines', '<(feature_defines)'
],
+ 'msvs_cygwin_shell': 1,
},
{
'action_name': 'UserAgentStyleSheets',
@@ -936,6 +947,7 @@
'--',
'--defines', '<(feature_defines)',
],
+ 'msvs_cygwin_shell': 1,
},
{
'action_name': 'PickerCommon',
@@ -1033,6 +1045,7 @@
'--',
'--extraDefines', '<(feature_defines)'
],
+ 'msvs_cygwin_shell': 1,
},
{
'action_name': 'XMLNSNames',
@@ -1053,6 +1066,7 @@
'--',
'--extraDefines', '<(feature_defines)'
],
+ 'msvs_cygwin_shell': 1,
},
{
'action_name': 'XMLNames',
@@ -1073,6 +1087,7 @@
'--',
'--extraDefines', '<(feature_defines)'
],
+ 'msvs_cygwin_shell': 1,
},
{
'action_name': 'derived_sources_all_in_one',
@@ -1857,7 +1872,7 @@
['include', 'platform/graphics/harfbuzz/HarfBuzzShaperBase\\.(cpp|h)$'],
['include', 'platform/graphics/harfbuzz/ng/HarfBuzzNGFaceCoreText\\.cpp$'],
['include', 'platform/graphics/harfbuzz/ng/HarfBuzzNGFace\\.(cpp|h)$'],
- ['include', 'platform/graphics/harfbuzz/ng/HarfBuzzShaper\\.(cpp|h)$'],
+ ['include', 'platform/graphics/harfbuzz/ng/HarfBuzzShaper\\.(cpp|h)$'],
],
},{ # OS!="mac"
'sources/': [
_______________________________________________ webkit-changes mailing list [email protected] http://lists.webkit.org/mailman/listinfo/webkit-changes
