[webkit-changes] [139545] trunk/Source

Fri, 11 Jan 2013 23:01:38 -0800

Title: [139545] trunk/Source
Revision
139545
Author
[email protected]
Date
2013-01-11 23:03:18 -0800 (Fri, 11 Jan 2013)

Log Message

[clean up] Remove HTMLFormElement::AutocompleteResultError in favor of more specific Error reasons
https://bugs.webkit.org/show_bug.cgi?id=106610

Patch by Dan Beam <[email protected]> on 2013-01-11
Reviewed by Darin Fisher.

Source/WebCore:

No new tests (none needed).

* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::finishRequestAutocomplete): Removed handling of AutocompleteResultError.
* html/HTMLFormElement.h: Removed HTMLFormElement::AutocompleteResultError in favor of more specific errors.

Source/WebKit/chromium:

* public/WebFormElement.h: Removed WebFormElement::AutocompleteResultError in favor of more specific error reasons.
* src/AssertMatchingEnums.cpp: Removed enum value from compile-time asserts.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (139544 => 139545)


--- trunk/Source/WebCore/ChangeLog	2013-01-12 05:20:06 UTC (rev 139544)
+++ trunk/Source/WebCore/ChangeLog	2013-01-12 07:03:18 UTC (rev 139545)
@@ -1,3 +1,16 @@
+2013-01-11  Dan Beam  <[email protected]>
+
+        [clean up] Remove HTMLFormElement::AutocompleteResultError in favor of more specific Error reasons
+        https://bugs.webkit.org/show_bug.cgi?id=106610
+
+        Reviewed by Darin Fisher.
+
+        No new tests (none needed).
+
+        * html/HTMLFormElement.cpp: 
+        (WebCore::HTMLFormElement::finishRequestAutocomplete): Removed handling of AutocompleteResultError.
+        * html/HTMLFormElement.h: Removed HTMLFormElement::AutocompleteResultError in favor of more specific errors.
+
 2013-01-10  Filip Pizlo  <[email protected]>
 
         JITThunks should not compile only because of luck

Modified: trunk/Source/WebCore/html/HTMLFormElement.cpp (139544 => 139545)


--- trunk/Source/WebCore/html/HTMLFormElement.cpp	2013-01-12 05:20:06 UTC (rev 139544)
+++ trunk/Source/WebCore/html/HTMLFormElement.cpp	2013-01-12 07:03:18 UTC (rev 139545)
@@ -415,8 +415,6 @@
     RefPtr<Event> event;
     if (result == AutocompleteResultSuccess)
         event = Event::create(eventNames().autocompleteEvent, false, false);
-    else if (result == AutocompleteResultError) // FIXME: Remove when no longer used.
-        event = Event::create(eventNames().autocompleteerrorEvent, false, false);
     else if (result == AutocompleteResultErrorDisabled)
         event = AutocompleteErrorEvent::create("disabled");
     else if (result == AutocompleteResultErrorCancel)

Modified: trunk/Source/WebCore/html/HTMLFormElement.h (139544 => 139545)


--- trunk/Source/WebCore/html/HTMLFormElement.h	2013-01-12 05:20:06 UTC (rev 139544)
+++ trunk/Source/WebCore/html/HTMLFormElement.h	2013-01-12 07:03:18 UTC (rev 139545)
@@ -101,7 +101,6 @@
 #if ENABLE(REQUEST_AUTOCOMPLETE)
     enum AutocompleteResult {
         AutocompleteResultSuccess,
-        AutocompleteResultError, // FIXME: Remove when no longer used.
         AutocompleteResultErrorDisabled,
         AutocompleteResultErrorCancel,
         AutocompleteResultErrorInvalid,

Modified: trunk/Source/WebKit/chromium/ChangeLog (139544 => 139545)


--- trunk/Source/WebKit/chromium/ChangeLog	2013-01-12 05:20:06 UTC (rev 139544)
+++ trunk/Source/WebKit/chromium/ChangeLog	2013-01-12 07:03:18 UTC (rev 139545)
@@ -1,3 +1,13 @@
+2013-01-11  Dan Beam  <[email protected]>
+
+        [clean up] Remove HTMLFormElement::AutocompleteResultError in favor of more specific Error reasons
+        https://bugs.webkit.org/show_bug.cgi?id=106610
+
+        Reviewed by Darin Fisher.
+
+        * public/WebFormElement.h: Removed WebFormElement::AutocompleteResultError in favor of more specific error reasons.
+        * src/AssertMatchingEnums.cpp: Removed enum value from compile-time asserts.
+
 2013-01-11  Tien-Ren Chen  <[email protected]>
 
         WebWidgetClient::didHandleGestureEvent needs to distinguish the case if the event is processed or swallowed

Modified: trunk/Source/WebKit/chromium/public/WebFormElement.h (139544 => 139545)


--- trunk/Source/WebKit/chromium/public/WebFormElement.h	2013-01-12 05:20:06 UTC (rev 139544)
+++ trunk/Source/WebKit/chromium/public/WebFormElement.h	2013-01-12 07:03:18 UTC (rev 139545)
@@ -71,7 +71,6 @@
 
         enum AutocompleteResult {
             AutocompleteResultSuccess,
-            AutocompleteResultError, // FIXME: Remove when not used any more.
             AutocompleteResultErrorDisabled,
             AutocompleteResultErrorCancel,
             AutocompleteResultErrorInvalid,

Modified: trunk/Source/WebKit/chromium/src/AssertMatchingEnums.cpp (139544 => 139545)


--- trunk/Source/WebKit/chromium/src/AssertMatchingEnums.cpp	2013-01-12 05:20:06 UTC (rev 139544)
+++ trunk/Source/WebKit/chromium/src/AssertMatchingEnums.cpp	2013-01-12 07:03:18 UTC (rev 139545)
@@ -627,7 +627,6 @@
 
 #if ENABLE(REQUEST_AUTOCOMPLETE)
 COMPILE_ASSERT_MATCHING_ENUM(WebFormElement::AutocompleteResultSuccess, HTMLFormElement::AutocompleteResultSuccess);
-COMPILE_ASSERT_MATCHING_ENUM(WebFormElement::AutocompleteResultError, HTMLFormElement::AutocompleteResultError);
 COMPILE_ASSERT_MATCHING_ENUM(WebFormElement::AutocompleteResultErrorDisabled, HTMLFormElement::AutocompleteResultErrorDisabled);
 COMPILE_ASSERT_MATCHING_ENUM(WebFormElement::AutocompleteResultErrorCancel, HTMLFormElement::AutocompleteResultErrorCancel);
 COMPILE_ASSERT_MATCHING_ENUM(WebFormElement::AutocompleteResultErrorInvalid, HTMLFormElement::AutocompleteResultErrorInvalid);

_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to