Title: [139579] trunk/Tools
- Revision
- 139579
- Author
- [email protected]
- Date
- 2013-01-13 18:22:46 -0800 (Sun, 13 Jan 2013)
Log Message
[chromium] webkitpy-test: executive.py stringify_args error on the release test bot
https://bugs.webkit.org/show_bug.cgi?id=105380
Reviewed by Eric Seidel.
Fix a regression introduced in r137692 where we were double-encoding
the arguments to popen(); this was only an issue on windows, where
we would try to encode something to mbcs, then try to encode it
to unicode as if the input as ascii.
* Scripts/webkitpy/common/system/executive.py:
(Executive.run_command):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (139578 => 139579)
--- trunk/Tools/ChangeLog 2013-01-14 02:18:08 UTC (rev 139578)
+++ trunk/Tools/ChangeLog 2013-01-14 02:22:46 UTC (rev 139579)
@@ -1,3 +1,18 @@
+2013-01-13 Dirk Pranke <[email protected]>
+
+ [chromium] webkitpy-test: executive.py stringify_args error on the release test bot
+ https://bugs.webkit.org/show_bug.cgi?id=105380
+
+ Reviewed by Eric Seidel.
+
+ Fix a regression introduced in r137692 where we were double-encoding
+ the arguments to popen(); this was only an issue on windows, where
+ we would try to encode something to mbcs, then try to encode it
+ to unicode as if the input as ascii.
+
+ * Scripts/webkitpy/common/system/executive.py:
+ (Executive.run_command):
+
2013-01-13 Alan Cutter <[email protected]>
State who told sheriffbot to roll the Chromium deps and to what revision
Modified: trunk/Tools/Scripts/webkitpy/common/system/executive.py (139578 => 139579)
--- trunk/Tools/Scripts/webkitpy/common/system/executive.py 2013-01-14 02:18:08 UTC (rev 139578)
+++ trunk/Tools/Scripts/webkitpy/common/system/executive.py 2013-01-14 02:22:46 UTC (rev 139579)
@@ -406,7 +406,6 @@
"""Popen wrapper for convenience and to work around python bugs."""
assert(isinstance(args, list) or isinstance(args, tuple))
start_time = time.time()
- args = self._stringify_args(args)
stdin, string_to_communicate = self._compute_stdin(input)
stderr = self.STDOUT if return_stderr else None
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
