Title: [139597] trunk/Source/WebCore
Revision
139597
Author
[email protected]
Date
2013-01-14 02:13:20 -0800 (Mon, 14 Jan 2013)

Log Message

Web Inspector: [Styles] HTML color names not converted to RGB/HEX/HSL when "Color format" feature used
https://bugs.webkit.org/show_bug.cgi?id=106767

Reviewed by Vsevolod Vlasov.

We used to render named colors as names regardless of the selected color format option.

* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (139596 => 139597)


--- trunk/Source/WebCore/ChangeLog	2013-01-14 09:55:11 UTC (rev 139596)
+++ trunk/Source/WebCore/ChangeLog	2013-01-14 10:13:20 UTC (rev 139597)
@@ -1,3 +1,15 @@
+2013-01-14  Alexander Pavlov  <[email protected]>
+
+        Web Inspector: [Styles] HTML color names not converted to RGB/HEX/HSL when "Color format" feature used
+        https://bugs.webkit.org/show_bug.cgi?id=106767
+
+        Reviewed by Vsevolod Vlasov.
+
+        We used to render named colors as names regardless of the selected color format option.
+
+        * inspector/front-end/StylesSidebarPane.js:
+        (WebInspector.StylePropertyTreeElement.prototype.updateTitle.):
+
 2013-01-14  Andrei Bucur  <[email protected]>
 
         Crash caused by incomplete cleanup of regions information for anonymous block

Modified: trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js (139596 => 139597)


--- trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js	2013-01-14 09:55:11 UTC (rev 139596)
+++ trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js	2013-01-14 10:13:20 UTC (rev 139597)
@@ -1819,8 +1819,6 @@
                     var formatSetting = WebInspector.settings.colorFormat.get();
                     if (formatSetting === cf.Original)
                         format = cf.Original;
-                    else if (color.nickname)
-                        format = cf.Nickname;
                     else if (formatSetting === cf.RGB)
                         format = (color.simple ? cf.RGB : cf.RGBA);
                     else if (formatSetting === cf.HSL)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to