Title: [139658] trunk
- Revision
- 139658
- Author
- [email protected]
- Date
- 2013-01-14 13:38:46 -0800 (Mon, 14 Jan 2013)
Log Message
Chromium: Error in AccessibilityUIElement::intValueGetterCallback
https://bugs.webkit.org/show_bug.cgi?id=106682
Reviewed by Chris Fleizach.
Tools:
Modify Chromium's DRT implementation of intValue to return a
different value depending on the role.
There are actually platform-specific differences in what should
be returned in the "value" of an object, so Chromium normally keeps
these separate (i.e. valueForRange, headingLevel, hierarchicalLevel, etc.)
but this is a fine simplification to make cross-platform tests easier.
* DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
(WebTestRunner::AccessibilityUIElement::intValueGetterCallback):
LayoutTests:
Unskip accessibility/heading-level.html now that the bug is fixed.
* platform/chromium/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (139657 => 139658)
--- trunk/LayoutTests/ChangeLog 2013-01-14 21:37:59 UTC (rev 139657)
+++ trunk/LayoutTests/ChangeLog 2013-01-14 21:38:46 UTC (rev 139658)
@@ -1,3 +1,14 @@
+2013-01-14 Dominic Mazzoni <[email protected]>
+
+ Chromium: Error in AccessibilityUIElement::intValueGetterCallback
+ https://bugs.webkit.org/show_bug.cgi?id=106682
+
+ Reviewed by Chris Fleizach.
+
+ Unskip accessibility/heading-level.html now that the bug is fixed.
+
+ * platform/chromium/TestExpectations:
+
2013-01-14 Stephen Chenney <[email protected]>
[Chromium] More test expectations for Skia changes
Modified: trunk/LayoutTests/platform/chromium/TestExpectations (139657 => 139658)
--- trunk/LayoutTests/platform/chromium/TestExpectations 2013-01-14 21:37:59 UTC (rev 139657)
+++ trunk/LayoutTests/platform/chromium/TestExpectations 2013-01-14 21:38:46 UTC (rev 139658)
@@ -1435,7 +1435,6 @@
webkit.org/b/96529 accessibility/hidden-legend.html [ Skip ]
webkit.org/b/73912 accessibility/aria-checkbox-text.html [ Skip ]
webkit.org/b/99665 accessibility/loading-iframe-sends-notification.html [ Skip ]
-webkit.org/b/106682 accessibility/heading-level.html [ Skip ]
webkit.org/b/73912 accessibility/aria-checkbox-sends-notification.html [ Failure Pass ]
#webkit.org/b/98787 accessibility/aria-hidden-negates-no-visibility.html [ Skip ]
Modified: trunk/Tools/ChangeLog (139657 => 139658)
--- trunk/Tools/ChangeLog 2013-01-14 21:37:59 UTC (rev 139657)
+++ trunk/Tools/ChangeLog 2013-01-14 21:38:46 UTC (rev 139658)
@@ -1,3 +1,21 @@
+2013-01-14 Dominic Mazzoni <[email protected]>
+
+ Chromium: Error in AccessibilityUIElement::intValueGetterCallback
+ https://bugs.webkit.org/show_bug.cgi?id=106682
+
+ Reviewed by Chris Fleizach.
+
+ Modify Chromium's DRT implementation of intValue to return a
+ different value depending on the role.
+
+ There are actually platform-specific differences in what should
+ be returned in the "value" of an object, so Chromium normally keeps
+ these separate (i.e. valueForRange, headingLevel, hierarchicalLevel, etc.)
+ but this is a fine simplification to make cross-platform tests easier.
+
+ * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
+ (WebTestRunner::AccessibilityUIElement::intValueGetterCallback):
+
2013-01-14 Jochen Eisinger <[email protected]>
[chromium] move remaining methods to dump WebViewClient callbacks to TestRunner library
Modified: trunk/Tools/DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp (139657 => 139658)
--- trunk/Tools/DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp 2013-01-14 21:37:59 UTC (rev 139657)
+++ trunk/Tools/DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp 2013-01-14 21:38:46 UTC (rev 139658)
@@ -518,7 +518,12 @@
void AccessibilityUIElement::intValueGetterCallback(CppVariant* result)
{
- result->set(accessibilityObject().valueForRange());
+ if (accessibilityObject().supportsRangeValue())
+ result->set(accessibilityObject().valueForRange());
+ else if (accessibilityObject().roleValue() == WebAccessibilityRoleHeading)
+ result->set(accessibilityObject().headingLevel());
+ else
+ result->set(atoi(accessibilityObject().stringValue().utf8().data()));
}
void AccessibilityUIElement::minValueGetterCallback(CppVariant* result)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
