Title: [139715] trunk/Tools
- Revision
- 139715
- Author
- [email protected]
- Date
- 2013-01-14 21:25:56 -0800 (Mon, 14 Jan 2013)
Log Message
nrwt: stub out show_results_html for mock ports
https://bugs.webkit.org/show_bug.cgi?id=106848
Reviewed by Ojan Vafai.
We were accidentally using the underlying ports'
show_results_html_file() implementation, which would, unsurprisingly,
fail in many cases (e.g., running mock-efl on the mac).
No test added since we don't generally add tests for the mock
implementation.
* Scripts/webkitpy/layout_tests/port/mock_drt.py:
(MockDRTPort.show_results_html_file):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (139714 => 139715)
--- trunk/Tools/ChangeLog 2013-01-15 05:22:43 UTC (rev 139714)
+++ trunk/Tools/ChangeLog 2013-01-15 05:25:56 UTC (rev 139715)
@@ -1,3 +1,20 @@
+2013-01-14 Dirk Pranke <[email protected]>
+
+ nrwt: stub out show_results_html for mock ports
+ https://bugs.webkit.org/show_bug.cgi?id=106848
+
+ Reviewed by Ojan Vafai.
+
+ We were accidentally using the underlying ports'
+ show_results_html_file() implementation, which would, unsurprisingly,
+ fail in many cases (e.g., running mock-efl on the mac).
+
+ No test added since we don't generally add tests for the mock
+ implementation.
+
+ * Scripts/webkitpy/layout_tests/port/mock_drt.py:
+ (MockDRTPort.show_results_html_file):
+
2013-01-14 Tim 'mithro' Ansell <[email protected]>
Changing clean_working_directory/clean_local_commits and related
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/mock_drt.py (139714 => 139715)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/mock_drt.py 2013-01-15 05:22:43 UTC (rev 139714)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/mock_drt.py 2013-01-15 05:25:56 UTC (rev 139715)
@@ -124,7 +124,10 @@
def release_http_lock(self):
pass
+ def show_results_html_file(self, results_filename):
+ pass
+
def main(argv, host, stdin, stdout, stderr):
"""Run the tests."""
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
