Title: [139807] trunk
- Revision
- 139807
- Author
- [email protected]
- Date
- 2013-01-15 16:14:57 -0800 (Tue, 15 Jan 2013)
Log Message
[Sub pixel layout] RTL cells with padding wraps
https://bugs.webkit.org/show_bug.cgi?id=106843
Source/WebCore:
Reviewed by Levi Weintraub.
At certain zoom levels table cells with padding wraps for rtl
content.
Test: fast/sub-pixel/table-rtl-padding.html
* rendering/RenderTable.h: Override paddingStart/End to return
integer values for padding as we do elsewhere in the table code.
LayoutTests:
Reviewed by Levi Weintraub.
Add test for rtl tables with padding.
* fast/sub-pixel/input-caret-on-subpixel-bound-expected.html:
* fast/sub-pixel/table-rtl-padding-expected.html: Added.
* fast/sub-pixel/table-rtl-padding.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (139806 => 139807)
--- trunk/LayoutTests/ChangeLog 2013-01-16 00:13:15 UTC (rev 139806)
+++ trunk/LayoutTests/ChangeLog 2013-01-16 00:14:57 UTC (rev 139807)
@@ -1,3 +1,16 @@
+2013-01-15 Emil A Eklund <[email protected]>
+
+ [Sub pixel layout] RTL cells with padding wraps
+ https://bugs.webkit.org/show_bug.cgi?id=106843
+
+ Reviewed by Levi Weintraub.
+
+ Add test for rtl tables with padding.
+
+ * fast/sub-pixel/input-caret-on-subpixel-bound-expected.html:
+ * fast/sub-pixel/table-rtl-padding-expected.html: Added.
+ * fast/sub-pixel/table-rtl-padding.html: Added.
+
2013-01-15 Dominic Mazzoni <[email protected]>
Use-after-free in AXObjectCache::notificationPostTimerFired
Modified: trunk/LayoutTests/fast/sub-pixel/input-caret-on-subpixel-bound-expected.html (139806 => 139807)
--- trunk/LayoutTests/fast/sub-pixel/input-caret-on-subpixel-bound-expected.html 2013-01-16 00:13:15 UTC (rev 139806)
+++ trunk/LayoutTests/fast/sub-pixel/input-caret-on-subpixel-bound-expected.html 2013-01-16 00:14:57 UTC (rev 139807)
@@ -10,7 +10,7 @@
padding: 2px 3px 3px 2px;
}
input {
- padding: 6px 5px 5px 6px;
+ padding: 6px 6px 5px 5px;
}
</style>
</head>
Added: trunk/LayoutTests/fast/sub-pixel/table-rtl-padding-expected.html (0 => 139807)
--- trunk/LayoutTests/fast/sub-pixel/table-rtl-padding-expected.html (rev 0)
+++ trunk/LayoutTests/fast/sub-pixel/table-rtl-padding-expected.html 2013-01-16 00:14:57 UTC (rev 139807)
@@ -0,0 +1,20 @@
+<!DOCTYPE html>
+<html>
+ <head>
+ <meta content="text/html; charset=utf-8" http-equiv="Content-Type">
+ <style>
+ td { white-space: nowrap; }
+ </style>
+ </head>
+ <body style="zoom: 1.1;">
+ <table style="padding-right: 3px">
+ <tbody>
+ <tr>
+ <td>עדי רם </td>
+ <td>(11:05 , 11.01.13 )</td>
+ </tr>
+ </tbody>
+ Table content should not wrap.
+ </table>
+ </body>
+</html>
Added: trunk/LayoutTests/fast/sub-pixel/table-rtl-padding.html (0 => 139807)
--- trunk/LayoutTests/fast/sub-pixel/table-rtl-padding.html (rev 0)
+++ trunk/LayoutTests/fast/sub-pixel/table-rtl-padding.html 2013-01-16 00:14:57 UTC (rev 139807)
@@ -0,0 +1,17 @@
+<!DOCTYPE html>
+<html>
+ <head>
+ <meta content="text/html; charset=utf-8" http-equiv="Content-Type">
+ </head>
+ <body style="zoom: 1.1;">
+ <table style="padding-right: 3px">
+ <tbody>
+ <tr>
+ <td>עדי רם </td>
+ <td>(11:05 , 11.01.13 )</td>
+ </tr>
+ </tbody>
+ Table content should not wrap.
+ </table>
+ </body>
+</html>
Modified: trunk/Source/WebCore/ChangeLog (139806 => 139807)
--- trunk/Source/WebCore/ChangeLog 2013-01-16 00:13:15 UTC (rev 139806)
+++ trunk/Source/WebCore/ChangeLog 2013-01-16 00:14:57 UTC (rev 139807)
@@ -1,3 +1,18 @@
+2013-01-15 Emil A Eklund <[email protected]>
+
+ [Sub pixel layout] RTL cells with padding wraps
+ https://bugs.webkit.org/show_bug.cgi?id=106843
+
+ Reviewed by Levi Weintraub.
+
+ At certain zoom levels table cells with padding wraps for rtl
+ content.
+
+ Test: fast/sub-pixel/table-rtl-padding.html
+
+ * rendering/RenderTable.h: Override paddingStart/End to return
+ integer values for padding as we do elsewhere in the table code.
+
2013-01-15 Dominic Mazzoni <[email protected]>
Use-after-free in AXObjectCache::notificationPostTimerFired
Modified: trunk/Source/WebCore/rendering/RenderTable.h (139806 => 139807)
--- trunk/Source/WebCore/rendering/RenderTable.h 2013-01-16 00:13:15 UTC (rev 139806)
+++ trunk/Source/WebCore/rendering/RenderTable.h 2013-01-16 00:14:57 UTC (rev 139807)
@@ -194,6 +194,10 @@
return 0;
}
+ // Override paddingStart/End to return pixel values to match behavor of RenderTableCell.
+ virtual LayoutUnit paddingEnd() const OVERRIDE { return static_cast<int>(RenderBlock::paddingEnd()); }
+ virtual LayoutUnit paddingStart() const OVERRIDE { return static_cast<int>(RenderBlock::paddingStart()); }
+
LayoutUnit bordersPaddingAndSpacingInRowDirection() const
{
// 'border-spacing' only applies to separate borders (see 17.6.1 The separated borders model).
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
