Title: [139870] trunk/Source/WebCore
Revision
139870
Author
[email protected]
Date
2013-01-16 04:13:45 -0800 (Wed, 16 Jan 2013)

Log Message

GraphicsSurfaceGLX is leaking an XWindow
https://bugs.webkit.org/show_bug.cgi?id=107002

The XWindow created as a backing surface for
the GraphicsSurfaceGLX needs to be destroyed
together with the GraphicsSurface.

Reviewed by Noam Rosenthal.

* platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp:
(WebCore::GraphicsSurfacePrivate::clear):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (139869 => 139870)


--- trunk/Source/WebCore/ChangeLog	2013-01-16 12:02:43 UTC (rev 139869)
+++ trunk/Source/WebCore/ChangeLog	2013-01-16 12:13:45 UTC (rev 139870)
@@ -1,3 +1,17 @@
+2013-01-16  Zeno Albisser  <[email protected]>
+
+        GraphicsSurfaceGLX is leaking an XWindow
+        https://bugs.webkit.org/show_bug.cgi?id=107002
+
+        The XWindow created as a backing surface for
+        the GraphicsSurfaceGLX needs to be destroyed
+        together with the GraphicsSurface.
+
+        Reviewed by Noam Rosenthal.
+
+        * platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp:
+        (WebCore::GraphicsSurfacePrivate::clear):
+
 2013-01-16  Pablo Flouret  <[email protected]>
 
         Implement CSSSupportsRule

Modified: trunk/Source/WebCore/platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp (139869 => 139870)


--- trunk/Source/WebCore/platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp	2013-01-16 12:02:43 UTC (rev 139869)
+++ trunk/Source/WebCore/platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp	2013-01-16 12:13:45 UTC (rev 139870)
@@ -439,6 +439,11 @@
             m_xPixmap = 0;
         }
 
+        if (m_surface) {
+            XDestroyWindow(m_display, m_surface);
+            m_surface = 0;
+        }
+
         if (m_glContext) {
             glXDestroyContext(m_display, m_glContext);
             m_glContext = 0;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to