Title: [139939] trunk/Source/WebCore
- Revision
- 139939
- Author
- [email protected]
- Date
- 2013-01-16 17:21:20 -0800 (Wed, 16 Jan 2013)
Log Message
Cursor stops blinking after clicking on scrollbar
https://bugs.webkit.org/show_bug.cgi?id=106470
Reviewed by Ojan Vafai.
Restore the caret blinking when doing a mouseup on a
scrollbar so scrolling a textarea doesn't cause the
caret to freeze.
No new tests, there doesn't seem to be any way to test
cursor blinking.
* page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseReleaseEvent):
(WebCore::EventHandler::handleMouseDoubleClickEvent):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (139938 => 139939)
--- trunk/Source/WebCore/ChangeLog 2013-01-17 01:18:26 UTC (rev 139938)
+++ trunk/Source/WebCore/ChangeLog 2013-01-17 01:21:20 UTC (rev 139939)
@@ -1,3 +1,21 @@
+2013-01-16 Elliott Sprehn <[email protected]>
+
+ Cursor stops blinking after clicking on scrollbar
+ https://bugs.webkit.org/show_bug.cgi?id=106470
+
+ Reviewed by Ojan Vafai.
+
+ Restore the caret blinking when doing a mouseup on a
+ scrollbar so scrolling a textarea doesn't cause the
+ caret to freeze.
+
+ No new tests, there doesn't seem to be any way to test
+ cursor blinking.
+
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::handleMouseReleaseEvent):
+ (WebCore::EventHandler::handleMouseDoubleClickEvent):
+
2013-01-16 Adam Barth <[email protected]>
Teach HTMLParserOptions about Settings::threadedHTMLParser
Modified: trunk/Source/WebCore/page/EventHandler.cpp (139938 => 139939)
--- trunk/Source/WebCore/page/EventHandler.cpp 2013-01-17 01:18:26 UTC (rev 139938)
+++ trunk/Source/WebCore/page/EventHandler.cpp 2013-01-17 01:21:20 UTC (rev 139939)
@@ -888,7 +888,6 @@
// Used to prevent mouseMoveEvent from initiating a drag before
// the mouse is pressed again.
- m_frame->selection()->setCaretBlinkingSuspended(false);
m_mousePressed = false;
m_capturesDragging = false;
#if ENABLE(DRAG_SUPPORT)
@@ -1553,6 +1552,8 @@
{
RefPtr<FrameView> protector(m_frame->view());
+ m_frame->selection()->setCaretBlinkingSuspended(false);
+
UserGestureIndicator gestureIndicator(DefinitelyProcessingUserGesture);
// We get this instead of a second mouse-up
@@ -1761,6 +1762,8 @@
{
RefPtr<FrameView> protector(m_frame->view());
+ m_frame->selection()->setCaretBlinkingSuspended(false);
+
#if ENABLE(TOUCH_EVENTS)
bool defaultPrevented = dispatchSyntheticTouchEventIfEnabled(mouseEvent);
if (defaultPrevented)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
