[webkit-changes] [139980] trunk

Thu, 17 Jan 2013 08:13:51 -0800

Title: [139980] trunk
Revision
139980
Author
[email protected]
Date
2013-01-17 08:15:33 -0800 (Thu, 17 Jan 2013)

Log Message

Web Inspector: fix DefaultTextEditor's broken backspace
https://bugs.webkit.org/show_bug.cgi?id=107130

Patch by Andrey Lushnikov <[email protected]> on 2013-01-17
Reviewed by Pavel Feldman.

Source/WebCore:

Remove css "position: relative;" style from "webkit-line-content" class, which
somehow brakes editing experience. Remove "height: 100%" from text-editor-overlay-highlight
class and cast necessary height via inserting "&nbsp;" into overlay span elements.

No new tests: no change in behaviour.

* inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorMainPanel.prototype._appendOverlayHighlight):
* inspector/front-end/textEditor.css:
(.text-editor-overlay-highlight):

LayoutTests:

Fix test expected results to correspond to changes.

* inspector/editor/text-editor-highlight-regexp-expected.txt:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (139979 => 139980)


--- trunk/LayoutTests/ChangeLog	2013-01-17 15:54:18 UTC (rev 139979)
+++ trunk/LayoutTests/ChangeLog	2013-01-17 16:15:33 UTC (rev 139980)
@@ -1,3 +1,14 @@
+2013-01-17  Andrey Lushnikov  <[email protected]>
+
+        Web Inspector: fix DefaultTextEditor's broken backspace
+        https://bugs.webkit.org/show_bug.cgi?id=107130
+
+        Reviewed by Pavel Feldman.
+
+        Fix test expected results to correspond to changes.
+
+        * inspector/editor/text-editor-highlight-regexp-expected.txt:
+
 2013-01-17  Zan Dobersek  <[email protected]>
 
         Unreviewed GTK gardening.

Modified: trunk/LayoutTests/inspector/editor/text-editor-highlight-regexp-expected.txt (139979 => 139980)


--- trunk/LayoutTests/inspector/editor/text-editor-highlight-regexp-expected.txt	2013-01-17 15:54:18 UTC (rev 139979)
+++ trunk/LayoutTests/inspector/editor/text-editor-highlight-regexp-expected.txt	2013-01-17 16:15:33 UTC (rev 139980)
@@ -17,11 +17,11 @@
 
 <div class="inner-container" tabindex="0">
 <div class="webkit-line-content">foo();</div>
-<div class="webkit-line-content">foo_1; foor; foo_;<span class="some-css-class text-editor-overlay-highlight" style="margin-left: -127px; width: 37px;"></span><span class="some-css-class text-editor-overlay-highlight" style="margin-left: -36px; width: 37px;"></span></div>
+<div class="webkit-line-content">foo_1; foor; foo_;<span class="some-css-class text-editor-overlay-highlight" style="margin-left: -127px; width: 37px;">&nbsp;</span><span class="some-css-class text-editor-overlay-highlight" style="margin-left: -36px; width: 37px;">&nbsp;</span></div>
 <div class="webkit-line-content">foo_</div>
 <div class="webkit-line-content">global_foo</div>
 <div class="webkit-line-content">global_foo2</div>
-<div class="webkit-line-content">some_other_foo_X<span class="some-css-class text-editor-overlay-highlight" style="margin-left: -36px; width: 37px;"></span></div></div>
+<div class="webkit-line-content">some_other_foo_X<span class="some-css-class text-editor-overlay-highlight" style="margin-left: -36px; width: 37px;">&nbsp;</span></div></div>
 
 Remove highlight for regexp /foo_./

Modified: trunk/Source/WebCore/ChangeLog (139979 => 139980)


--- trunk/Source/WebCore/ChangeLog	2013-01-17 15:54:18 UTC (rev 139979)
+++ trunk/Source/WebCore/ChangeLog	2013-01-17 16:15:33 UTC (rev 139980)
@@ -1,3 +1,21 @@
+2013-01-17  Andrey Lushnikov  <[email protected]>
+
+        Web Inspector: fix DefaultTextEditor's broken backspace
+        https://bugs.webkit.org/show_bug.cgi?id=107130
+
+        Reviewed by Pavel Feldman.
+
+        Remove css "position: relative;" style from "webkit-line-content" class, which
+        somehow brakes editing experience. Remove "height: 100%" from text-editor-overlay-highlight
+        class and cast necessary height via inserting "&nbsp;" into overlay span elements.
+
+        No new tests: no change in behaviour.
+
+        * inspector/front-end/DefaultTextEditor.js:
+        (WebInspector.TextEditorMainPanel.prototype._appendOverlayHighlight):
+        * inspector/front-end/textEditor.css:
+        (.text-editor-overlay-highlight):
+
 2013-01-16  Vsevolod Vlasov  <[email protected]>
 
         Web Inspector: Introduce FileSystemWorkspaceProvider to allow showing files from file system in workspace.

Modified: trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js (139979 => 139980)


--- trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js	2013-01-17 15:54:18 UTC (rev 139979)
+++ trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js	2013-01-17 16:15:33 UTC (rev 139980)
@@ -1981,6 +1981,7 @@
 
             highlight.style.marginLeft = (metrics[i].left - highlight.offsetLeft - extraWidth) + "px";
             highlight.style.width = (metrics[i].width + extraWidth * 2) + "px";
+            highlight.innerHTML = "&nbsp;";
             highlight.addStyleClass("text-editor-overlay-highlight");
         }
     },

Modified: trunk/Source/WebCore/inspector/front-end/textEditor.css (139979 => 139980)


--- trunk/Source/WebCore/inspector/front-end/textEditor.css	2013-01-17 15:54:18 UTC (rev 139979)
+++ trunk/Source/WebCore/inspector/front-end/textEditor.css	2013-01-17 16:15:33 UTC (rev 139980)
@@ -32,7 +32,6 @@
 
 .text-editor-overlay-highlight {
     position: absolute;
-    height: 100%;
     pointer-events: none;
     -webkit-user-select: none;
     z-index: -1;
@@ -56,10 +55,6 @@
     background-color: rgb(240, 240, 240);
 }
 
-.webkit-line-content {
-    position: relative;
-}
-
 .webkit-line-decorations {
     pointer-events: none;
     -webkit-user-select: none;

_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to