Diff
Modified: trunk/Source/WebKit/blackberry/ChangeLog (140147 => 140148)
--- trunk/Source/WebKit/blackberry/ChangeLog 2013-01-18 15:36:02 UTC (rev 140147)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2013-01-18 15:43:24 UTC (rev 140148)
@@ -1,3 +1,16 @@
+2013-01-18 Seokju Kwon <seokju.k...@gmail.com>
+
+ Add explicit keyword to constructors in platform-specific InspectorClient
+ https://bugs.webkit.org/show_bug.cgi?id=107255
+
+ Reviewed by Kentaro Hara.
+
+ Add explicit keyword to constructors that take one argument
+ in platform-specific implementation of InspectorClient.
+
+ * WebCoreSupport/InspectorClientBlackBerry.h:
+ (InspectorClientBlackBerry):
+
2013-01-18 Andrew Lo <a...@rim.com>
[BlackBerry] Assert failing in RenderQueue::renderScrollZoomJobs
Modified: trunk/Source/WebKit/blackberry/WebCoreSupport/InspectorClientBlackBerry.h (140147 => 140148)
--- trunk/Source/WebKit/blackberry/WebCoreSupport/InspectorClientBlackBerry.h 2013-01-18 15:36:02 UTC (rev 140147)
+++ trunk/Source/WebKit/blackberry/WebCoreSupport/InspectorClientBlackBerry.h 2013-01-18 15:43:24 UTC (rev 140148)
@@ -37,7 +37,7 @@
class InspectorClientBlackBerry : public InspectorClient, public InspectorFrontendChannel, public BlackBerry::WebKit::InspectorOverlay::InspectorOverlayClient {
public:
- InspectorClientBlackBerry(BlackBerry::WebKit::WebPagePrivate*);
+ explicit InspectorClientBlackBerry(BlackBerry::WebKit::WebPagePrivate*);
virtual void inspectorDestroyed();
virtual void highlight();
Modified: trunk/Source/WebKit/chromium/ChangeLog (140147 => 140148)
--- trunk/Source/WebKit/chromium/ChangeLog 2013-01-18 15:36:02 UTC (rev 140147)
+++ trunk/Source/WebKit/chromium/ChangeLog 2013-01-18 15:43:24 UTC (rev 140148)
@@ -1,3 +1,16 @@
+2013-01-18 Seokju Kwon <seokju.k...@gmail.com>
+
+ Add explicit keyword to constructors in platform-specific InspectorClient
+ https://bugs.webkit.org/show_bug.cgi?id=107255
+
+ Reviewed by Kentaro Hara.
+
+ Add explicit keyword to constructors that take one argument
+ in platform-specific implementation of InspectorClient.
+
+ * src/InspectorClientImpl.h:
+ (InspectorClientImpl):
+
2013-01-17 Dominic Cooney <domin...@chromium.org>
[Chromium] Unreviewed gardening.
Modified: trunk/Source/WebKit/chromium/src/InspectorClientImpl.h (140147 => 140148)
--- trunk/Source/WebKit/chromium/src/InspectorClientImpl.h 2013-01-18 15:36:02 UTC (rev 140147)
+++ trunk/Source/WebKit/chromium/src/InspectorClientImpl.h 2013-01-18 15:43:24 UTC (rev 140148)
@@ -45,7 +45,7 @@
class InspectorClientImpl : public WebCore::InspectorClient,
public WebCore::InspectorFrontendChannel {
public:
- InspectorClientImpl(WebViewImpl*);
+ explicit InspectorClientImpl(WebViewImpl*);
~InspectorClientImpl();
// InspectorClient methods:
Modified: trunk/Source/WebKit/gtk/ChangeLog (140147 => 140148)
--- trunk/Source/WebKit/gtk/ChangeLog 2013-01-18 15:36:02 UTC (rev 140147)
+++ trunk/Source/WebKit/gtk/ChangeLog 2013-01-18 15:43:24 UTC (rev 140148)
@@ -1,3 +1,22 @@
+2013-01-18 Seokju Kwon <seokju.k...@gmail.com>
+
+ Add explicit keyword to constructors in platform-specific InspectorClient
+ https://bugs.webkit.org/show_bug.cgi?id=107255
+
+ Reviewed by Kentaro Hara.
+
+ Add explicit keyword to constructors that take one argument
+ in platform-specific implementation of InspectorClient.
+ And fix some coding style.
+
+ * WebCoreSupport/InspectorClientGtk.h:
+ (WebCore):
+ (WebKit):
+ (InspectorClient):
+ (WebKit::InspectorClient::disconnectFrontendClient):
+ (InspectorFrontendClient):
+ (WebKit::InspectorFrontendClient::disconnectInspectorClient):
+
2013-01-18 Manuel Rego Casasnovas <r...@igalia.com>
[GTK] Add new method to support addUserScript in DumpRenderTree
Modified: trunk/Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.h (140147 => 140148)
--- trunk/Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.h 2013-01-18 15:36:02 UTC (rev 140147)
+++ trunk/Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.h 2013-01-18 15:43:24 UTC (rev 140148)
@@ -32,77 +32,77 @@
#include "InspectorClient.h"
#include "InspectorFrontendChannel.h"
#include "InspectorFrontendClientLocal.h"
+#include "webkitwebinspector.h"
#include "webkitwebview.h"
-#include "webkitwebinspector.h"
#include <wtf/Forward.h>
#include <wtf/gobject/GOwnPtr.h>
#include <wtf/gobject/GRefPtr.h>
namespace WebCore {
- class Page;
+class Page;
}
namespace WebKit {
- class InspectorFrontendClient;
+class InspectorFrontendClient;
- class InspectorClient : public WebCore::InspectorClient, public WebCore::InspectorFrontendChannel {
- public:
- InspectorClient(WebKitWebView* webView);
- ~InspectorClient();
+class InspectorClient : public WebCore::InspectorClient, public WebCore::InspectorFrontendChannel {
+public:
+ explicit InspectorClient(WebKitWebView*);
+ ~InspectorClient();
- void disconnectFrontendClient() { m_frontendClient = 0; }
+ void disconnectFrontendClient() { m_frontendClient = 0; }
- virtual void inspectorDestroyed();
+ virtual void inspectorDestroyed();
- virtual WebCore::InspectorFrontendChannel* openInspectorFrontend(WebCore::InspectorController*);
- virtual void closeInspectorFrontend();
- virtual void bringFrontendToFront();
+ virtual WebCore::InspectorFrontendChannel* openInspectorFrontend(WebCore::InspectorController*);
+ virtual void closeInspectorFrontend();
+ virtual void bringFrontendToFront();
- virtual void highlight();
- virtual void hideHighlight();
+ virtual void highlight();
+ virtual void hideHighlight();
- virtual bool sendMessageToFrontend(const WTF::String&);
+ virtual bool sendMessageToFrontend(const WTF::String&);
- void releaseFrontendPage();
- const char* inspectorFilesPath();
+ void releaseFrontendPage();
+ const char* inspectorFilesPath();
- private:
- WebKitWebView* m_inspectedWebView;
- WebCore::Page* m_frontendPage;
- InspectorFrontendClient* m_frontendClient;
- GOwnPtr<gchar> m_inspectorFilesPath;
- };
+private:
+ WebKitWebView* m_inspectedWebView;
+ WebCore::Page* m_frontendPage;
+ InspectorFrontendClient* m_frontendClient;
+ GOwnPtr<gchar> m_inspectorFilesPath;
+};
- class InspectorFrontendClient : public WebCore::InspectorFrontendClientLocal {
- public:
- InspectorFrontendClient(WebKitWebView* inspectedWebView, WebKitWebView* inspectorWebView, WebKitWebInspector* webInspector, WebCore::Page* inspectorPage, InspectorClient* inspectorClient);
- virtual ~InspectorFrontendClient();
+class InspectorFrontendClient : public WebCore::InspectorFrontendClientLocal {
+public:
+ InspectorFrontendClient(WebKitWebView* inspectedWebView, WebKitWebView* inspectorWebView, WebKitWebInspector*, WebCore::Page* inspectorPage, InspectorClient*);
+ virtual ~InspectorFrontendClient();
- void disconnectInspectorClient() { m_inspectorClient = 0; }
+ void disconnectInspectorClient() { m_inspectorClient = 0; }
- void destroyInspectorWindow(bool notifyInspectorController);
+ void destroyInspectorWindow(bool notifyInspectorController);
- virtual WTF::String localizedStringsURL();
+ virtual WTF::String localizedStringsURL();
- virtual WTF::String hiddenPanels();
+ virtual WTF::String hiddenPanels();
- virtual void bringToFront();
- virtual void closeWindow();
+ virtual void bringToFront();
+ virtual void closeWindow();
- virtual void attachWindow();
- virtual void detachWindow();
+ virtual void attachWindow();
+ virtual void detachWindow();
- virtual void setAttachedWindowHeight(unsigned height);
+ virtual void setAttachedWindowHeight(unsigned);
- virtual void inspectedURLChanged(const WTF::String& newURL);
+ virtual void inspectedURLChanged(const WTF::String& newURL);
- private:
- WebKitWebView* m_inspectorWebView;
- WebKitWebView* m_inspectedWebView;
- GRefPtr<WebKitWebInspector> m_webInspector;
- InspectorClient* m_inspectorClient;
- };
+private:
+ WebKitWebView* m_inspectorWebView;
+ WebKitWebView* m_inspectedWebView;
+ GRefPtr<WebKitWebInspector> m_webInspector;
+ InspectorClient* m_inspectorClient;
+};
}
#endif
Modified: trunk/Source/WebKit/mac/ChangeLog (140147 => 140148)
--- trunk/Source/WebKit/mac/ChangeLog 2013-01-18 15:36:02 UTC (rev 140147)
+++ trunk/Source/WebKit/mac/ChangeLog 2013-01-18 15:43:24 UTC (rev 140148)
@@ -1,3 +1,16 @@
+2013-01-18 Seokju Kwon <seokju.k...@gmail.com>
+
+ Add explicit keyword to constructors in platform-specific InspectorClient
+ https://bugs.webkit.org/show_bug.cgi?id=107255
+
+ Reviewed by Kentaro Hara.
+
+ Add explicit keyword to constructors that take one argument
+ in platform-specific implementation of InspectorClient.
+
+ * WebCoreSupport/WebInspectorClient.h:
+ (WebInspectorClient):
+
2013-01-15 Jer Noble <jer.no...@apple.com>
Add a Setting to disable QTKit media engine.
Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.h (140147 => 140148)
--- trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.h 2013-01-18 15:36:02 UTC (rev 140147)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.h 2013-01-18 15:43:24 UTC (rev 140148)
@@ -59,7 +59,7 @@
class WebInspectorClient : public WebCore::InspectorClient, public WebCore::InspectorFrontendChannel {
public:
- WebInspectorClient(WebView *);
+ explicit WebInspectorClient(WebView *);
virtual void inspectorDestroyed() OVERRIDE;
Modified: trunk/Source/WebKit/qt/ChangeLog (140147 => 140148)
--- trunk/Source/WebKit/qt/ChangeLog 2013-01-18 15:36:02 UTC (rev 140147)
+++ trunk/Source/WebKit/qt/ChangeLog 2013-01-18 15:43:24 UTC (rev 140148)
@@ -1,3 +1,16 @@
+2013-01-18 Seokju Kwon <seokju.k...@gmail.com>
+
+ Add explicit keyword to constructors in platform-specific InspectorClient
+ https://bugs.webkit.org/show_bug.cgi?id=107255
+
+ Reviewed by Kentaro Hara.
+
+ Add explicit keyword to constructors that take one argument
+ in platform-specific implementation of InspectorClient.
+
+ * WebCoreSupport/InspectorClientQt.h:
+ (InspectorClientQt):
+
2013-01-16 Jocelyn Turcotte <jocelyn.turco...@digia.com>
[Qt] Use the shared HistoryItem serialization for QWebHistory
Modified: trunk/Source/WebKit/qt/WebCoreSupport/InspectorClientQt.h (140147 => 140148)
--- trunk/Source/WebKit/qt/WebCoreSupport/InspectorClientQt.h 2013-01-18 15:36:02 UTC (rev 140147)
+++ trunk/Source/WebKit/qt/WebCoreSupport/InspectorClientQt.h 2013-01-18 15:43:24 UTC (rev 140148)
@@ -51,7 +51,7 @@
class InspectorClientQt : public InspectorClient, public InspectorFrontendChannel {
public:
- InspectorClientQt(QWebPageAdapter*);
+ explicit InspectorClientQt(QWebPageAdapter*);
virtual void inspectorDestroyed();
Modified: trunk/Source/WebKit/win/ChangeLog (140147 => 140148)
--- trunk/Source/WebKit/win/ChangeLog 2013-01-18 15:36:02 UTC (rev 140147)
+++ trunk/Source/WebKit/win/ChangeLog 2013-01-18 15:43:24 UTC (rev 140148)
@@ -1,3 +1,16 @@
+2013-01-18 Seokju Kwon <seokju.k...@gmail.com>
+
+ Add explicit keyword to constructors in platform-specific InspectorClient
+ https://bugs.webkit.org/show_bug.cgi?id=107255
+
+ Reviewed by Kentaro Hara.
+
+ Add explicit keyword to constructors that take one argument
+ in platform-specific implementation of InspectorClient.
+
+ * WebCoreSupport/WebInspectorClient.h:
+ (WebInspectorClient):
+
2013-01-18 Sheriff Bot <webkit.review....@gmail.com>
Unreviewed, rolling out r140005.
Modified: trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.h (140147 => 140148)
--- trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.h 2013-01-18 15:36:02 UTC (rev 140147)
+++ trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.h 2013-01-18 15:43:24 UTC (rev 140148)
@@ -53,7 +53,7 @@
class WebInspectorClient : public WebCore::InspectorClient, public WebCore::InspectorFrontendChannel {
public:
- WebInspectorClient(WebView*);
+ explicit WebInspectorClient(WebView*);
// InspectorClient
virtual void inspectorDestroyed();
Modified: trunk/Source/WebKit/wince/ChangeLog (140147 => 140148)
--- trunk/Source/WebKit/wince/ChangeLog 2013-01-18 15:36:02 UTC (rev 140147)
+++ trunk/Source/WebKit/wince/ChangeLog 2013-01-18 15:43:24 UTC (rev 140148)
@@ -1,3 +1,17 @@
+2013-01-18 Seokju Kwon <seokju.k...@gmail.com>
+
+ Add explicit keyword to constructors in platform-specific InspectorClient
+ https://bugs.webkit.org/show_bug.cgi?id=107255
+
+ Reviewed by Kentaro Hara.
+
+ Add explicit keyword to constructors that take one argument
+ in platform-specific implementation of InspectorClient.
+ And fix some coding style.
+
+ * WebCoreSupport/InspectorClientWinCE.h:
+ (InspectorClientWinCE):
+
2013-01-08 Mark Lam <mark....@apple.com>
Removed the need for the ProposedDatabase mechanism.
Modified: trunk/Source/WebKit/wince/WebCoreSupport/InspectorClientWinCE.h (140147 => 140148)
--- trunk/Source/WebKit/wince/WebCoreSupport/InspectorClientWinCE.h 2013-01-18 15:36:02 UTC (rev 140147)
+++ trunk/Source/WebKit/wince/WebCoreSupport/InspectorClientWinCE.h 2013-01-18 15:43:24 UTC (rev 140148)
@@ -34,7 +34,7 @@
class InspectorClientWinCE : public WebCore::InspectorClient, public WebCore::InspectorFrontendChannel {
public:
- InspectorClientWinCE(WebView* webView);
+ explicit InspectorClientWinCE(WebView*);
~InspectorClientWinCE();
virtual void inspectorDestroyed();
