Title: [140325] trunk/Source/WebCore
- Revision
- 140325
- Author
- [email protected]
- Date
- 2013-01-21 05:34:11 -0800 (Mon, 21 Jan 2013)
Log Message
[Gtk] [Cairo] Memory leak when is WebView destroy.
https://bugs.webkit.org/show_bug.cgi?id=107112
Patch by Oleg Smirnov <[email protected]> on 2013-01-21
Reviewed by Martin Robinson.
Make createSurfaceForBackingStore return a smart pointer in all supported
build configurations to avoid a memory leak.
No new tests. There is memory leak only.
* platform/cairo/WidgetBackingStoreCairo.cpp:
(WebCore::createSurfaceForBackingStore):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (140324 => 140325)
--- trunk/Source/WebCore/ChangeLog 2013-01-21 12:50:30 UTC (rev 140324)
+++ trunk/Source/WebCore/ChangeLog 2013-01-21 13:34:11 UTC (rev 140325)
@@ -1,3 +1,18 @@
+2013-01-21 Oleg Smirnov <[email protected]>
+
+ [Gtk] [Cairo] Memory leak when is WebView destroy.
+ https://bugs.webkit.org/show_bug.cgi?id=107112
+
+ Reviewed by Martin Robinson.
+
+ Make createSurfaceForBackingStore return a smart pointer in all supported
+ build configurations to avoid a memory leak.
+
+ No new tests. There is memory leak only.
+
+ * platform/cairo/WidgetBackingStoreCairo.cpp:
+ (WebCore::createSurfaceForBackingStore):
+
2013-01-21 Kent Tamura <[email protected]>
INPUT_MULTIPLE_FIELDS_UI: should not dispatch 'input' events if the element value is not updated
Modified: trunk/Source/WebCore/platform/cairo/WidgetBackingStoreCairo.cpp (140324 => 140325)
--- trunk/Source/WebCore/platform/cairo/WidgetBackingStoreCairo.cpp 2013-01-21 12:50:30 UTC (rev 140324)
+++ trunk/Source/WebCore/platform/cairo/WidgetBackingStoreCairo.cpp 2013-01-21 13:34:11 UTC (rev 140325)
@@ -33,9 +33,7 @@
static PassRefPtr<cairo_surface_t> createSurfaceForBackingStore(PlatformWidget widget, const IntSize& size)
{
#if PLATFORM(GTK)
- return gdk_window_create_similar_surface(gtk_widget_get_window(widget),
- CAIRO_CONTENT_COLOR_ALPHA,
- size.width(), size.height());
+ return adoptRef(gdk_window_create_similar_surface(gtk_widget_get_window(widget), CAIRO_CONTENT_COLOR_ALPHA, size.width(), size.height()));
#else
UNUSED_PARAM(widget);
return adoptRef(cairo_image_surface_create(CAIRO_FORMAT_ARGB32, size.width(), size.height()));
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
