Title: [140327] trunk/Tools
- Revision
- 140327
- Author
- [email protected]
- Date
- 2013-01-21 05:55:36 -0800 (Mon, 21 Jan 2013)
Log Message
[EFL][WKTR] platformRunUntil() should keep the main loop running
https://bugs.webkit.org/show_bug.cgi?id=107442
Reviewed by Noam Rosenthal.
EFL's implementation of platformRunUntil() should keep the main loop
running and avoid calling sleep() between calls to
ecore_main_loop_iterate(). This call to sleep seems to be a source
of deadlocks (see Bug 106884).
* WebKitTestRunner/efl/TestControllerEfl.cpp:
(WTR::TestController::platformRunUntil):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (140326 => 140327)
--- trunk/Tools/ChangeLog 2013-01-21 13:40:06 UTC (rev 140326)
+++ trunk/Tools/ChangeLog 2013-01-21 13:55:36 UTC (rev 140327)
@@ -1,3 +1,18 @@
+2013-01-21 Christophe Dumez <[email protected]>
+
+ [EFL][WKTR] platformRunUntil() should keep the main loop running
+ https://bugs.webkit.org/show_bug.cgi?id=107442
+
+ Reviewed by Noam Rosenthal.
+
+ EFL's implementation of platformRunUntil() should keep the main loop
+ running and avoid calling sleep() between calls to
+ ecore_main_loop_iterate(). This call to sleep seems to be a source
+ of deadlocks (see Bug 106884).
+
+ * WebKitTestRunner/efl/TestControllerEfl.cpp:
+ (WTR::TestController::platformRunUntil):
+
2013-01-21 Vivek Galatage <[email protected]>
QtTestBrowser should provide way to clear selected elements
Modified: trunk/Tools/WebKitTestRunner/efl/TestControllerEfl.cpp (140326 => 140327)
--- trunk/Tools/WebKitTestRunner/efl/TestControllerEfl.cpp 2013-01-21 13:40:06 UTC (rev 140326)
+++ trunk/Tools/WebKitTestRunner/efl/TestControllerEfl.cpp 2013-01-21 13:55:36 UTC (rev 140327)
@@ -65,10 +65,9 @@
{
if (timeout == m_noTimeout) {
// Never timeout if we are debugging or not meant to timeout.
- while (!condition) {
+ while (!condition)
ecore_main_loop_iterate();
- sleep(1);
- }
+
return;
}
timer = ecore_timer_loop_add(timeout, timerFired, 0);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
