Title: [140339] trunk/Source/WebCore
- Revision
- 140339
- Author
- [email protected]
- Date
- 2013-01-21 08:39:34 -0800 (Mon, 21 Jan 2013)
Log Message
[GTK] Volume button should not be shown for videos without audio
https://bugs.webkit.org/show_bug.cgi?id=106436
Patch by Halton Huo <[email protected]> on 2013-01-21
Reviewed by Philippe Normand.
The volume control is no longer shown for videos with no audio.
No new tests, tested by media/video-no-audio.html.
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::hasOwnDisabledStateHandlingFor):
(WebCore):
* platform/gtk/RenderThemeGtk.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (140338 => 140339)
--- trunk/Source/WebCore/ChangeLog 2013-01-21 16:23:13 UTC (rev 140338)
+++ trunk/Source/WebCore/ChangeLog 2013-01-21 16:39:34 UTC (rev 140339)
@@ -1,3 +1,19 @@
+2013-01-21 Halton Huo <[email protected]>
+
+ [GTK] Volume button should not be shown for videos without audio
+ https://bugs.webkit.org/show_bug.cgi?id=106436
+
+ Reviewed by Philippe Normand.
+
+ The volume control is no longer shown for videos with no audio.
+
+ No new tests, tested by media/video-no-audio.html.
+
+ * platform/gtk/RenderThemeGtk.cpp:
+ (WebCore::RenderThemeGtk::hasOwnDisabledStateHandlingFor):
+ (WebCore):
+ * platform/gtk/RenderThemeGtk.h:
+
2013-01-21 Dan Winship <[email protected]>
[Soup] Work around a glib bug
Modified: trunk/Source/WebCore/platform/gtk/RenderThemeGtk.cpp (140338 => 140339)
--- trunk/Source/WebCore/platform/gtk/RenderThemeGtk.cpp 2013-01-21 16:23:13 UTC (rev 140338)
+++ trunk/Source/WebCore/platform/gtk/RenderThemeGtk.cpp 2013-01-21 16:39:34 UTC (rev 140339)
@@ -513,6 +513,11 @@
return false;
}
+bool RenderThemeGtk::hasOwnDisabledStateHandlingFor(ControlPart part) const
+{
+ return (part != MediaMuteButtonPart);
+}
+
bool RenderThemeGtk::paintMediaFullscreenButton(RenderObject* renderObject, const PaintInfo& paintInfo, const IntRect& rect)
{
return paintMediaButton(renderObject, paintInfo.context, rect, GTK_STOCK_FULLSCREEN);
Modified: trunk/Source/WebCore/platform/gtk/RenderThemeGtk.h (140338 => 140339)
--- trunk/Source/WebCore/platform/gtk/RenderThemeGtk.h 2013-01-21 16:23:13 UTC (rev 140338)
+++ trunk/Source/WebCore/platform/gtk/RenderThemeGtk.h 2013-01-21 16:39:34 UTC (rev 140339)
@@ -162,7 +162,7 @@
void initMediaColors();
void initMediaButtons();
void adjustMediaSliderThumbSize(RenderStyle*) const;
- virtual bool hasOwnDisabledStateHandlingFor(ControlPart) const { return true; }
+ virtual bool hasOwnDisabledStateHandlingFor(ControlPart) const;
virtual bool paintMediaFullscreenButton(RenderObject*, const PaintInfo&, const IntRect&);
virtual bool paintMediaPlayButton(RenderObject*, const PaintInfo&, const IntRect&);
virtual bool paintMediaMuteButton(RenderObject*, const PaintInfo&, const IntRect&);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
