Title: [140372] trunk/Source/WebKit2
Revision
140372
Author
[email protected]
Date
2013-01-21 17:04:34 -0800 (Mon, 21 Jan 2013)

Log Message

[EFL][WK2] Implement WebInspector::localizedStringsURL() on EFL
https://bugs.webkit.org/show_bug.cgi?id=107363

Patch by Sudarsana Nagineni <[email protected]> on 2013-01-21
Reviewed by Benjamin Poulain.

Implement WebInspector::localizedStringsURL() method to return the
file URL of the localizedStrings.js.

This prevents printing warnings about "Localized string not found" in
the console and fixes Web inspector related failing tests on the bots.

* WebProcess/WebPage/efl/WebInspectorEfl.cpp:
(WebKit::WebInspector::localizedStringsURL):

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (140371 => 140372)


--- trunk/Source/WebKit2/ChangeLog	2013-01-22 00:45:14 UTC (rev 140371)
+++ trunk/Source/WebKit2/ChangeLog	2013-01-22 01:04:34 UTC (rev 140372)
@@ -1,3 +1,19 @@
+2013-01-21  Sudarsana Nagineni  <[email protected]>
+
+        [EFL][WK2] Implement WebInspector::localizedStringsURL() on EFL
+        https://bugs.webkit.org/show_bug.cgi?id=107363
+
+        Reviewed by Benjamin Poulain.
+
+        Implement WebInspector::localizedStringsURL() method to return the
+        file URL of the localizedStrings.js.
+
+        This prevents printing warnings about "Localized string not found" in
+        the console and fixes Web inspector related failing tests on the bots.
+
+        * WebProcess/WebPage/efl/WebInspectorEfl.cpp:
+        (WebKit::WebInspector::localizedStringsURL):
+
 2013-01-21  Kiran Muppala  <[email protected]>
 
         Enable process suppression by default on Mac

Modified: trunk/Source/WebKit2/WebProcess/WebPage/efl/WebInspectorEfl.cpp (140371 => 140372)


--- trunk/Source/WebKit2/WebProcess/WebPage/efl/WebInspectorEfl.cpp	2013-01-22 00:45:14 UTC (rev 140371)
+++ trunk/Source/WebKit2/WebProcess/WebPage/efl/WebInspectorEfl.cpp	2013-01-22 01:04:34 UTC (rev 140372)
@@ -28,15 +28,14 @@
 
 #if ENABLE(INSPECTOR)
 
-#include <WebCore/NotImplemented.h>
+#include <WebCore/EflInspectorUtilities.h>
 #include <wtf/text/WTFString.h>
 
 namespace WebKit {
 
 String WebInspector::localizedStringsURL() const
 {
-    notImplemented();
-    return String();
+    return "file://" + WebCore::inspectorResourcePath() + "/localizedStrings.js";
 }
 
 } // namespace WebKit
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to