Title: [140381] trunk/Source/WebCore
Revision
140381
Author
[email protected]
Date
2013-01-21 21:04:29 -0800 (Mon, 21 Jan 2013)

Log Message

FrameSelection should use shadowHost instead of shadowAncestorNode
https://bugs.webkit.org/show_bug.cgi?id=107220

Reviewed by Kent Tamura.

shadowAncestorNode() is deprecated and we want to use shadowHost.
Here, all objects calling shadowAncestorNode() is in ShadowDOM, we can safely convert
the call to shadowHost().

No new tests, simple refactoring.

* editing/FrameSelection.cpp:
(WebCore::FrameSelection::selectAll):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (140380 => 140381)


--- trunk/Source/WebCore/ChangeLog	2013-01-22 03:29:42 UTC (rev 140380)
+++ trunk/Source/WebCore/ChangeLog	2013-01-22 05:04:29 UTC (rev 140381)
@@ -1,3 +1,19 @@
+2013-01-21  Shinya Kawanaka  <[email protected]>
+
+        FrameSelection should use shadowHost instead of shadowAncestorNode
+        https://bugs.webkit.org/show_bug.cgi?id=107220
+
+        Reviewed by Kent Tamura.
+
+        shadowAncestorNode() is deprecated and we want to use shadowHost.
+        Here, all objects calling shadowAncestorNode() is in ShadowDOM, we can safely convert
+        the call to shadowHost().
+
+        No new tests, simple refactoring.
+
+        * editing/FrameSelection.cpp:
+        (WebCore::FrameSelection::selectAll):
+
 2013-01-21  Dirk Schulze  <[email protected]>
 
         Add build flag for Canvas's Path object (disabled by default)

Modified: trunk/Source/WebCore/editing/FrameSelection.cpp (140380 => 140381)


--- trunk/Source/WebCore/editing/FrameSelection.cpp	2013-01-22 03:29:42 UTC (rev 140380)
+++ trunk/Source/WebCore/editing/FrameSelection.cpp	2013-01-22 05:04:29 UTC (rev 140381)
@@ -1607,13 +1607,13 @@
     if (isContentEditable()) {
         root = highestEditableRoot(m_selection.start());
         if (Node* shadowRoot = m_selection.nonBoundaryShadowTreeRootNode())
-            selectStartTarget = shadowRoot->shadowAncestorNode();
+            selectStartTarget = shadowRoot->shadowHost();
         else
             selectStartTarget = root.get();
     } else {
         root = m_selection.nonBoundaryShadowTreeRootNode();
         if (root)
-            selectStartTarget = root->shadowAncestorNode();
+            selectStartTarget = root->shadowHost();
         else {
             root = document->documentElement();
             selectStartTarget = document->body();
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to