Title: [140387] trunk/Source/WebCore
- Revision
- 140387
- Author
- [email protected]
- Date
- 2013-01-21 23:33:16 -0800 (Mon, 21 Jan 2013)
Log Message
[V8] ScriptState::isolate() should use Context::GetIsolate()
https://bugs.webkit.org/show_bug.cgi?id=107490
Reviewed by Adam Barth.
Now V8 provides Context::GetIsolate(). We should use it
in ScriptState::isolate().
* bindings/v8/ScriptState.h:
(WebCore::ScriptState::isolate):
(ScriptState):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (140386 => 140387)
--- trunk/Source/WebCore/ChangeLog 2013-01-22 06:42:23 UTC (rev 140386)
+++ trunk/Source/WebCore/ChangeLog 2013-01-22 07:33:16 UTC (rev 140387)
@@ -1,3 +1,17 @@
+2013-01-21 Kentaro Hara <[email protected]>
+
+ [V8] ScriptState::isolate() should use Context::GetIsolate()
+ https://bugs.webkit.org/show_bug.cgi?id=107490
+
+ Reviewed by Adam Barth.
+
+ Now V8 provides Context::GetIsolate(). We should use it
+ in ScriptState::isolate().
+
+ * bindings/v8/ScriptState.h:
+ (WebCore::ScriptState::isolate):
+ (ScriptState):
+
2013-01-21 Michał Pakuła vel Rutka <[email protected]>
[EFL] Missing context menus strings
Modified: trunk/Source/WebCore/bindings/v8/ScriptState.h (140386 => 140387)
--- trunk/Source/WebCore/bindings/v8/ScriptState.h 2013-01-22 06:42:23 UTC (rev 140386)
+++ trunk/Source/WebCore/bindings/v8/ScriptState.h 2013-01-22 07:33:16 UTC (rev 140387)
@@ -65,9 +65,7 @@
v8::Isolate* isolate()
{
- if (!m_isolate)
- m_isolate = v8::Isolate::GetCurrent();
- return m_isolate;
+ return m_context->GetIsolate();
}
DOMWindow* domWindow() const;
@@ -88,7 +86,6 @@
v8::Local<v8::Value> m_exception;
ScopedPersistent<v8::Context> m_context;
- v8::Isolate* m_isolate;
};
class EmptyScriptState : public ScriptState {
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
