Title: [140538] trunk/Source/WebCore
- Revision
- 140538
- Author
- [email protected]
- Date
- 2013-01-23 09:45:36 -0800 (Wed, 23 Jan 2013)
Log Message
Web Inspector: remove invisibleLineRow code from paintLines DTE method
https://bugs.webkit.org/show_bug.cgi?id=107649
Patch by Andrey Lushnikov <[email protected]> on 2013-01-23
Reviewed by Pavel Feldman.
Remove invisibleLineRow logic from TextEditorMainPanel._paintLines method.
No new tests: no change in behaviour.
* inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorMainPanel.prototype._paintLines):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (140537 => 140538)
--- trunk/Source/WebCore/ChangeLog 2013-01-23 15:22:15 UTC (rev 140537)
+++ trunk/Source/WebCore/ChangeLog 2013-01-23 17:45:36 UTC (rev 140538)
@@ -1,3 +1,17 @@
+2013-01-23 Andrey Lushnikov <[email protected]>
+
+ Web Inspector: remove invisibleLineRow code from paintLines DTE method
+ https://bugs.webkit.org/show_bug.cgi?id=107649
+
+ Reviewed by Pavel Feldman.
+
+ Remove invisibleLineRow logic from TextEditorMainPanel._paintLines method.
+
+ No new tests: no change in behaviour.
+
+ * inspector/front-end/DefaultTextEditor.js:
+ (WebInspector.TextEditorMainPanel.prototype._paintLines):
+
2013-01-23 Rafael Weinstein <[email protected]>
REGRESSION(r140101): caused debug asserts in fast/forms/associated-element-crash.html and html5lib/run-template.html
Modified: trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js (140537 => 140538)
--- trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js 2013-01-23 15:22:15 UTC (rev 140537)
+++ trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js 2013-01-23 17:45:36 UTC (rev 140538)
@@ -1791,35 +1791,19 @@
*/
_paintLines: function(fromLine, toLine, restoreSelection)
{
- // First, paint visible lines, so that in case of long lines we should start highlighting
- // the visible area immediately, instead of waiting for the lines above the visible area.
- var visibleFrom = this.scrollTop();
- var firstVisibleLineNumber = this.lineNumberAtOffset(visibleFrom);
-
var chunk;
var selection;
- var invisibleLineRows = [];
for (var lineNumber = fromLine; lineNumber < toLine; ++lineNumber) {
if (!chunk || lineNumber < chunk.startLine || lineNumber >= chunk.startLine + chunk.linesCount)
chunk = this.chunkForLine(lineNumber);
var lineRow = chunk.expandedLineRow(lineNumber);
if (!lineRow)
continue;
- if (lineNumber < firstVisibleLineNumber) {
- invisibleLineRows.push(lineRow);
- continue;
- }
if (restoreSelection && !selection)
selection = this.selection();
this._paintLine(lineRow);
}
- for (var i = 0; i < invisibleLineRows.length; ++i) {
- if (restoreSelection && !selection)
- selection = this.selection();
- this._paintLine(invisibleLineRows[i]);
- }
-
if (restoreSelection)
this._restoreSelection(selection);
},
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
