Title: [140691] trunk
- Revision
- 140691
- Author
- [email protected]
- Date
- 2013-01-24 09:39:18 -0800 (Thu, 24 Jan 2013)
Log Message
Web Inspector: expand more chunks in DTE
https://bugs.webkit.org/show_bug.cgi?id=107698
Patch by Andrey Lushnikov <[email protected]> on 2013-01-24
Reviewed by Pavel Feldman.
Source/WebCore:
Mock DefaultTextEditor visible area as if it is slightly larger than real one and
do all chunk expandings and repaints based on this new area.
No new tests: no change in behaviour.
* inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorChunkedPanel.prototype.findVisibleChunks):
LayoutTests:
Correct text expectation as we change amount of expanded chunks.
* inspector/editor/text-editor-selection-expected.txt:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (140690 => 140691)
--- trunk/LayoutTests/ChangeLog 2013-01-24 17:28:02 UTC (rev 140690)
+++ trunk/LayoutTests/ChangeLog 2013-01-24 17:39:18 UTC (rev 140691)
@@ -1,3 +1,14 @@
+2013-01-24 Andrey Lushnikov <[email protected]>
+
+ Web Inspector: expand more chunks in DTE
+ https://bugs.webkit.org/show_bug.cgi?id=107698
+
+ Reviewed by Pavel Feldman.
+
+ Correct text expectation as we change amount of expanded chunks.
+
+ * inspector/editor/text-editor-selection-expected.txt:
+
2013-01-24 Ádám Kallai <[email protected]>
[Qt] Unreviewed gardening. Added platform specific expectation after r140174.
Modified: trunk/LayoutTests/inspector/editor/text-editor-selection-expected.txt (140690 => 140691)
--- trunk/LayoutTests/inspector/editor/text-editor-selection-expected.txt 2013-01-24 17:28:02 UTC (rev 140690)
+++ trunk/LayoutTests/inspector/editor/text-editor-selection-expected.txt 2013-01-24 17:39:18 UTC (rev 140691)
@@ -2,7 +2,7 @@
Chunk model
Chunk [0] 0:9 (expanded)
-Chunk [1] 9:18 (collapsed)
+Chunk [1] 9:18 (expanded)
Chunk [2] 18:27 (collapsed)
Chunk [3] 27:34 (collapsed)
Modified: trunk/Source/WebCore/ChangeLog (140690 => 140691)
--- trunk/Source/WebCore/ChangeLog 2013-01-24 17:28:02 UTC (rev 140690)
+++ trunk/Source/WebCore/ChangeLog 2013-01-24 17:39:18 UTC (rev 140691)
@@ -1,3 +1,18 @@
+2013-01-24 Andrey Lushnikov <[email protected]>
+
+ Web Inspector: expand more chunks in DTE
+ https://bugs.webkit.org/show_bug.cgi?id=107698
+
+ Reviewed by Pavel Feldman.
+
+ Mock DefaultTextEditor visible area as if it is slightly larger than real one and
+ do all chunk expandings and repaints based on this new area.
+
+ No new tests: no change in behaviour.
+
+ * inspector/front-end/DefaultTextEditor.js:
+ (WebInspector.TextEditorChunkedPanel.prototype.findVisibleChunks):
+
2013-01-24 Victor Jaquez <[email protected]>
[GStreamer] Implement setPreservesPitch()
Modified: trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js (140690 => 140691)
--- trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js 2013-01-24 17:28:02 UTC (rev 140690)
+++ trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js 2013-01-24 17:39:18 UTC (rev 140691)
@@ -894,6 +894,10 @@
*/
findVisibleChunks: function(visibleFrom, visibleTo)
{
+ var span = (visibleTo - visibleFrom) * 0.5;
+ visibleFrom = Math.max(visibleFrom - span, 0);
+ visibleTo = visibleTo + span;
+
var from = this._findFirstVisibleChunkNumber(visibleFrom);
for (var to = from + 1; to < this._textChunks.length; ++to) {
if (this._textChunks[to].offsetTop >= visibleTo)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
