Title: [140733] trunk/Source/WebCore
- Revision
- 140733
- Author
- [email protected]
- Date
- 2013-01-24 15:17:22 -0800 (Thu, 24 Jan 2013)
Log Message
Web Inspector: "XHR loaded!" messages should be DebugMessageLevel.
https://bugs.webkit.org/show_bug.cgi?id=107817
Reviewed by Pavel Feldman.
The 'XHR finished loading:' message is currently sent at
LogMessageLevel. Upon reflection, the only messages that should be
sent at that level are messages the developer generates herself via
'console.*' calls. This message is better categorized as 'debug'.
* inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::didFinishXHRLoading):
Change the message to DebugMessageLevel.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (140732 => 140733)
--- trunk/Source/WebCore/ChangeLog 2013-01-24 23:14:42 UTC (rev 140732)
+++ trunk/Source/WebCore/ChangeLog 2013-01-24 23:17:22 UTC (rev 140733)
@@ -1,3 +1,19 @@
+2013-01-24 Mike West <[email protected]>
+
+ Web Inspector: "XHR loaded!" messages should be DebugMessageLevel.
+ https://bugs.webkit.org/show_bug.cgi?id=107817
+
+ Reviewed by Pavel Feldman.
+
+ The 'XHR finished loading:' message is currently sent at
+ LogMessageLevel. Upon reflection, the only messages that should be
+ sent at that level are messages the developer generates herself via
+ 'console.*' calls. This message is better categorized as 'debug'.
+
+ * inspector/InspectorConsoleAgent.cpp:
+ (WebCore::InspectorConsoleAgent::didFinishXHRLoading):
+ Change the message to DebugMessageLevel.
+
2013-01-24 James Robinson <[email protected]>
REGRESSION(140571): Crash in ScrollingCoordinator::mainThreadScrollingReasons during Frame::createView
Modified: trunk/Source/WebCore/inspector/InspectorConsoleAgent.cpp (140732 => 140733)
--- trunk/Source/WebCore/inspector/InspectorConsoleAgent.cpp 2013-01-24 23:14:42 UTC (rev 140732)
+++ trunk/Source/WebCore/inspector/InspectorConsoleAgent.cpp 2013-01-24 23:17:22 UTC (rev 140733)
@@ -268,7 +268,7 @@
return;
if (m_frontend && m_state->getBoolean(ConsoleAgentState::monitoringXHR)) {
String message = "XHR finished loading: \"" + url + "\".";
- addMessageToConsole(NetworkMessageSource, LogMessageType, LogMessageLevel, message, sendURL, sendLineNumber, 0, requestIdentifier);
+ addMessageToConsole(NetworkMessageSource, LogMessageType, DebugMessageLevel, message, sendURL, sendLineNumber, 0, requestIdentifier);
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
