Title: [140747] trunk/Source/WebCore
- Revision
- 140747
- Author
- [email protected]
- Date
- 2013-01-24 16:27:58 -0800 (Thu, 24 Jan 2013)
Log Message
Some formerly-fixed objects scroll as if they are still fixed
https://bugs.webkit.org/show_bug.cgi?id=107869
Reviewed by Simon Fraser.
Removing nodes need to mark m_hasChangedProperties on the state tree, otherwise
they will not be committed to the scrolling tree until something else changes,
which could actually take a while. During the delay, the scrolling tree will
continue to move around the formerly-fixed object as long as it still has a layer.
* page/scrolling/ScrollingStateTree.cpp:
(WebCore::ScrollingStateTree::didRemoveNode):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (140746 => 140747)
--- trunk/Source/WebCore/ChangeLog 2013-01-25 00:11:26 UTC (rev 140746)
+++ trunk/Source/WebCore/ChangeLog 2013-01-25 00:27:58 UTC (rev 140747)
@@ -1,3 +1,17 @@
+2013-01-24 Beth Dakin <[email protected]>
+
+ Some formerly-fixed objects scroll as if they are still fixed
+ https://bugs.webkit.org/show_bug.cgi?id=107869
+
+ Reviewed by Simon Fraser.
+
+ Removing nodes need to mark m_hasChangedProperties on the state tree, otherwise
+ they will not be committed to the scrolling tree until something else changes,
+ which could actually take a while. During the delay, the scrolling tree will
+ continue to move around the formerly-fixed object as long as it still has a layer.
+ * page/scrolling/ScrollingStateTree.cpp:
+ (WebCore::ScrollingStateTree::didRemoveNode):
+
2013-01-24 Arko Saha <[email protected]>
Microdata: itemtype attribute must update correctly on adding or removing tokens
Modified: trunk/Source/WebCore/page/scrolling/ScrollingStateTree.cpp (140746 => 140747)
--- trunk/Source/WebCore/page/scrolling/ScrollingStateTree.cpp 2013-01-25 00:11:26 UTC (rev 140746)
+++ trunk/Source/WebCore/page/scrolling/ScrollingStateTree.cpp 2013-01-25 00:27:58 UTC (rev 140747)
@@ -70,6 +70,7 @@
void ScrollingStateTree::didRemoveNode(ScrollingNodeID nodeID)
{
m_nodesRemovedSinceLastCommit.append(nodeID);
+ m_hasChangedProperties = true;
}
} // namespace WebCore
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
