Title: [140800] trunk/Source/WebCore
- Revision
- 140800
- Author
- h...@chromium.org
- Date
- 2013-01-25 01:35:51 -0800 (Fri, 25 Jan 2013)
Log Message
Disable Clang's -Wreturn-type-c-linkage for Source/WebCore/bindings/v8/
https://bugs.webkit.org/show_bug.cgi?id=107845
Reviewed by Adam Barth.
A recent version of Clang started warning about code in
Source/WebCore/bindings/v8/npruntime.cpp.
In this case it is warning about an 'extern "c"' function returning a
non-POD type. But because the function has internal linkage, the
warning doesn't really apply.
This change suppresses the warning in the meantime.
Tested by building with Clang r172454.
* WebCore.gyp/WebCore.gyp:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (140799 => 140800)
--- trunk/Source/WebCore/ChangeLog 2013-01-25 09:24:07 UTC (rev 140799)
+++ trunk/Source/WebCore/ChangeLog 2013-01-25 09:35:51 UTC (rev 140800)
@@ -1,3 +1,23 @@
+2013-01-24 Hans Wennborg <h...@chromium.org>
+
+ Disable Clang's -Wreturn-type-c-linkage for Source/WebCore/bindings/v8/
+ https://bugs.webkit.org/show_bug.cgi?id=107845
+
+ Reviewed by Adam Barth.
+
+ A recent version of Clang started warning about code in
+ Source/WebCore/bindings/v8/npruntime.cpp.
+
+ In this case it is warning about an 'extern "c"' function returning a
+ non-POD type. But because the function has internal linkage, the
+ warning doesn't really apply.
+
+ This change suppresses the warning in the meantime.
+
+ Tested by building with Clang r172454.
+
+ * WebCore.gyp/WebCore.gyp:
+
2013-01-25 Eberhard Graether <egraet...@google.com>
Web Inspector: add checkbox for continuous painting to the inspector's settings
Modified: trunk/Source/WebCore/WebCore.gyp/WebCore.gyp (140799 => 140800)
--- trunk/Source/WebCore/WebCore.gyp/WebCore.gyp 2013-01-25 09:24:07 UTC (rev 140799)
+++ trunk/Source/WebCore/WebCore.gyp/WebCore.gyp 2013-01-25 09:35:51 UTC (rev 140800)
@@ -2157,6 +2157,17 @@
['OS!="mac"', {
'sources/': [['exclude', 'Mac\\.(cpp|mm?)$']]
}],
+ ['clang==1', {
+ # FIXME: Remove once this warning has been tweaked in Clang.
+ 'cflags': [
+ '-Wno-return-type-c-linkage',
+ ],
+ 'xcode_settings': {
+ 'WARNING_CFLAGS': [
+ '-Wno-return-type-c-linkage',
+ ],
+ }
+ }],
],
},
{
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
