Title: [140955] trunk/Source/WebCore
Revision
140955
Author
[email protected]
Date
2013-01-28 01:39:13 -0800 (Mon, 28 Jan 2013)

Log Message

[REGRESSION] Calendar Picker focus ring is gone
https://bugs.webkit.org/show_bug.cgi?id=108055

Reviewed by Kent Tamura.

The focus ring wasn't visible because -webkit-focus-ring-color value
only works for outline property in strict mode. Using fixed color
instead.

No new tests. Can't reproduce in layout test because mock popup writes a
script tag in front of the doctype.

* Resources/pagepopups/chromium/calendarPickerChromium.css:
(.days-area-container:focus):
* Resources/pagepopups/chromium/pickerCommonChromium.css:
(:enabled:focus:-webkit-any(button, input[type='button'])):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (140954 => 140955)


--- trunk/Source/WebCore/ChangeLog	2013-01-28 09:39:00 UTC (rev 140954)
+++ trunk/Source/WebCore/ChangeLog	2013-01-28 09:39:13 UTC (rev 140955)
@@ -1,3 +1,22 @@
+2013-01-28  Keishi Hattori  <[email protected]>
+
+        [REGRESSION] Calendar Picker focus ring is gone
+        https://bugs.webkit.org/show_bug.cgi?id=108055
+
+        Reviewed by Kent Tamura.
+
+        The focus ring wasn't visible because -webkit-focus-ring-color value
+        only works for outline property in strict mode. Using fixed color
+        instead.
+
+        No new tests. Can't reproduce in layout test because mock popup writes a
+        script tag in front of the doctype.
+
+        * Resources/pagepopups/chromium/calendarPickerChromium.css:
+        (.days-area-container:focus):
+        * Resources/pagepopups/chromium/pickerCommonChromium.css:
+        (:enabled:focus:-webkit-any(button, input[type='button'])):
+
 2013-01-25  Yury Semikhatsky  <[email protected]>
 
         Web Inspector: remove unused isElement and similar methods from HeapProfiler

Modified: trunk/Source/WebCore/Resources/pagepopups/chromium/calendarPickerChromium.css (140954 => 140955)


--- trunk/Source/WebCore/Resources/pagepopups/chromium/calendarPickerChromium.css	2013-01-28 09:39:00 UTC (rev 140954)
+++ trunk/Source/WebCore/Resources/pagepopups/chromium/calendarPickerChromium.css	2013-01-28 09:39:13 UTC (rev 140955)
@@ -9,6 +9,6 @@
     -webkit-transition: border-color 200ms;
     /* We use border color because it follows the border radius (unlike outline).
     * This is particularly noticeable on mac. */
-    border-color: -webkit-focus-ring-color;
+    border-color: rgb(77, 144, 254);
     outline: none;
 }

Modified: trunk/Source/WebCore/Resources/pagepopups/chromium/pickerCommonChromium.css (140954 => 140955)


--- trunk/Source/WebCore/Resources/pagepopups/chromium/pickerCommonChromium.css	2013-01-28 09:39:00 UTC (rev 140954)
+++ trunk/Source/WebCore/Resources/pagepopups/chromium/pickerCommonChromium.css	2013-01-28 09:39:13 UTC (rev 140955)
@@ -41,6 +41,6 @@
     -webkit-transition: border-color 200ms;
     /* We use border color because it follows the border radius (unlike outline).
     * This is particularly noticeable on mac. */
-    border-color: -webkit-focus-ring-color;
+    border-color: rgb(77, 144, 254);
     outline: none;
 }
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to