Title: [140995] trunk/Source
Revision
140995
Author
[email protected]
Date
2013-01-28 13:10:43 -0800 (Mon, 28 Jan 2013)

Log Message

Add StorageStrategy member functions to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=108105

Reviewed by Tim Horton.

Source/WebCore:

StorageStrategy::sessionStorageNamespace should be virtual, not static...

* WebCore.exp.in:
* storage/StorageStrategy.h:
(StorageStrategy):

Source/WebKit2:

Add default implementations that just chain up to the base class for now.

* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::localStorageNamespace):
(WebKit::WebPlatformStrategies::sessionStorageNamespace):
* WebProcess/WebCoreSupport/WebPlatformStrategies.h:
(WebPlatformStrategies):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (140994 => 140995)


--- trunk/Source/WebCore/ChangeLog	2013-01-28 21:08:20 UTC (rev 140994)
+++ trunk/Source/WebCore/ChangeLog	2013-01-28 21:10:43 UTC (rev 140995)
@@ -1,3 +1,16 @@
+2013-01-28  Anders Carlsson  <[email protected]>
+
+        Add StorageStrategy member functions to WebKit2
+        https://bugs.webkit.org/show_bug.cgi?id=108105
+
+        Reviewed by Tim Horton.
+
+        StorageStrategy::sessionStorageNamespace should be virtual, not static...
+
+        * WebCore.exp.in:
+        * storage/StorageStrategy.h:
+        (StorageStrategy):
+
 2013-01-28  Uday Kiran  <[email protected]>
 
         getComputedStyle returns "left" instead of "none" for "float" on abspos elements

Modified: trunk/Source/WebCore/WebCore.exp.in (140994 => 140995)


--- trunk/Source/WebCore/WebCore.exp.in	2013-01-28 21:08:20 UTC (rev 140994)
+++ trunk/Source/WebCore/WebCore.exp.in	2013-01-28 21:10:43 UTC (rev 140995)
@@ -423,6 +423,7 @@
 __ZN7WebCore15ScrollAlignment17alignCenterAlwaysE
 __ZN7WebCore15ScrollAlignment19alignToEdgeIfNeededE
 __ZN7WebCore15StorageStrategy21localStorageNamespaceERKN3WTF6StringEj
+__ZN7WebCore15StorageStrategy23sessionStorageNamespaceEPNS_4PageEj
 __ZN7WebCore15StringTruncator13rightTruncateERKN3WTF6StringEfRKNS_4FontENS0_24EnableRoundingHacksOrNotE
 __ZN7WebCore15StringTruncator14centerTruncateERKN3WTF6StringEfRKNS_4FontENS0_24EnableRoundingHacksOrNotE
 __ZN7WebCore15StringTruncator5widthERKN3WTF6StringERKNS_4FontENS0_24EnableRoundingHacksOrNotE

Modified: trunk/Source/WebCore/storage/StorageStrategy.h (140994 => 140995)


--- trunk/Source/WebCore/storage/StorageStrategy.h	2013-01-28 21:08:20 UTC (rev 140994)
+++ trunk/Source/WebCore/storage/StorageStrategy.h	2013-01-28 21:10:43 UTC (rev 140995)
@@ -38,7 +38,7 @@
 class StorageStrategy {
 public:
     virtual PassRefPtr<StorageNamespace> localStorageNamespace(const String& path, unsigned quota);
-    static PassRefPtr<StorageNamespace> sessionStorageNamespace(Page*, unsigned quota);
+    virtual PassRefPtr<StorageNamespace> sessionStorageNamespace(Page*, unsigned quota);
 
 protected:
     virtual ~StorageStrategy()

Modified: trunk/Source/WebKit2/ChangeLog (140994 => 140995)


--- trunk/Source/WebKit2/ChangeLog	2013-01-28 21:08:20 UTC (rev 140994)
+++ trunk/Source/WebKit2/ChangeLog	2013-01-28 21:10:43 UTC (rev 140995)
@@ -1,3 +1,18 @@
+2013-01-28  Anders Carlsson  <[email protected]>
+
+        Add StorageStrategy member functions to WebKit2
+        https://bugs.webkit.org/show_bug.cgi?id=108105
+
+        Reviewed by Tim Horton.
+
+        Add default implementations that just chain up to the base class for now.
+
+        * WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
+        (WebKit::WebPlatformStrategies::localStorageNamespace):
+        (WebKit::WebPlatformStrategies::sessionStorageNamespace):
+        * WebProcess/WebCoreSupport/WebPlatformStrategies.h:
+        (WebPlatformStrategies):
+
 2013-01-28  Adam Barth  <[email protected]>
 
         Remove webkitNotifications.createHTMLNotification

Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp (140994 => 140995)


--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp	2013-01-28 21:08:20 UTC (rev 140994)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp	2013-01-28 21:10:43 UTC (rev 140995)
@@ -47,6 +47,7 @@
 #include <WebCore/PlatformCookieJar.h>
 #include <WebCore/PlatformPasteboard.h>
 #include <WebCore/ResourceError.h>
+#include <WebCore/StorageNamespace.h>
 #include <wtf/Atomics.h>
 
 #if ENABLE(NETWORK_PROCESS)
@@ -300,6 +301,18 @@
 }
 #endif // ENABLE(NETSCAPE_PLUGIN_API)
 
+// StorageStrategy
+
+PassRefPtr<StorageNamespace> WebPlatformStrategies::localStorageNamespace(const String& path, unsigned quota)
+{
+    return StorageStrategy::localStorageNamespace(path, quota);
+}
+
+PassRefPtr<StorageNamespace> WebPlatformStrategies::sessionStorageNamespace(Page* page, unsigned quota)
+{
+    return sessionStorageNamespace(page, quota);
+}
+
 // VisitedLinkStrategy
 
 bool WebPlatformStrategies::isLinkVisited(Page*, LinkHash linkHash, const KURL&, const AtomicString&)

Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.h (140994 => 140995)


--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.h	2013-01-28 21:08:20 UTC (rev 140994)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.h	2013-01-28 21:10:43 UTC (rev 140995)
@@ -80,6 +80,10 @@
     virtual void refreshPlugins() OVERRIDE;
     virtual void getPluginInfo(const WebCore::Page*, Vector<WebCore::PluginInfo>&) OVERRIDE;
 
+    // WebCore::StorageStrategy.
+    virtual PassRefPtr<WebCore::StorageNamespace> localStorageNamespace(const String& path, unsigned quota) OVERRIDE;
+    virtual PassRefPtr<WebCore::StorageNamespace> sessionStorageNamespace(WebCore::Page*, unsigned quota) OVERRIDE;
+
     // WebCore::VisitedLinkStrategy
     virtual bool isLinkVisited(WebCore::Page*, WebCore::LinkHash, const WebCore::KURL& baseURL, const WTF::AtomicString& attributeURL) OVERRIDE;
     virtual void addVisitedLink(WebCore::Page*, WebCore::LinkHash) OVERRIDE;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to