Title: [141035] trunk/Source/WebCore
Revision
141035
Author
[email protected]
Date
2013-01-28 19:42:34 -0800 (Mon, 28 Jan 2013)

Log Message

compositing/reflections/become-simple-composited-reflection.html pixel result shows bug
https://bugs.webkit.org/show_bug.cgi?id=107174

Reviewed by Dean Jackson.

When we have a content layer for solid color, we need to update reflection
clones when that color changes.

Tested by the pixel test for compositing/reflections/become-simple-composited-reflection.html.

* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::updateContentsColorLayer):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (141034 => 141035)


--- trunk/Source/WebCore/ChangeLog	2013-01-29 02:37:52 UTC (rev 141034)
+++ trunk/Source/WebCore/ChangeLog	2013-01-29 03:42:34 UTC (rev 141035)
@@ -1,3 +1,18 @@
+2013-01-28  Simon Fraser  <[email protected]>
+
+        compositing/reflections/become-simple-composited-reflection.html pixel result shows bug
+        https://bugs.webkit.org/show_bug.cgi?id=107174
+
+        Reviewed by Dean Jackson.
+        
+        When we have a content layer for solid color, we need to update reflection
+        clones when that color changes.
+
+        Tested by the pixel test for compositing/reflections/become-simple-composited-reflection.html.
+
+        * platform/graphics/ca/GraphicsLayerCA.cpp:
+        (WebCore::GraphicsLayerCA::updateContentsColorLayer):
+
 2013-01-28  Tom Sepez  <[email protected]>
 
         [v8] Security feature: _javascript_ Bindings hardening

Modified: trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp (141034 => 141035)


--- trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp	2013-01-29 02:37:52 UTC (rev 141034)
+++ trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp	2013-01-29 03:42:34 UTC (rev 141035)
@@ -1674,6 +1674,12 @@
         updateContentsRect();
         ASSERT(m_contentsSolidColor.isValid()); // An invalid color should have removed the contents layer.
         m_contentsLayer->setBackgroundColor(m_contentsSolidColor);
+
+        if (m_contentsLayerClones) {
+            LayerMap::const_iterator end = m_contentsLayerClones->end();
+            for (LayerMap::const_iterator it = m_contentsLayerClones->begin(); it != end; ++it)
+                it->value->setBackgroundColor(m_contentsSolidColor);
+        }
     }
 }
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to