Title: [141059] trunk/Source/_javascript_Core
Revision
141059
Author
[email protected]
Date
2013-01-28 22:59:42 -0800 (Mon, 28 Jan 2013)

Log Message

Collapse testing for a list of PLATFORM() into OS() and USE() tests
https://bugs.webkit.org/show_bug.cgi?id=108018

Patch by Laszlo Gombos <[email protected]> on 2013-01-28
Reviewed by Eric Seidel.

No functional change as "OS(DARWIN) && USE(CF)" equals to the
following platforms: MAC, WX, QT and CHROMIUM. CHROMIUM
is not using _javascript_Core.

* runtime/DatePrototype.cpp:
(JSC):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (141058 => 141059)


--- trunk/Source/_javascript_Core/ChangeLog	2013-01-29 06:55:27 UTC (rev 141058)
+++ trunk/Source/_javascript_Core/ChangeLog	2013-01-29 06:59:42 UTC (rev 141059)
@@ -1,3 +1,17 @@
+2013-01-28  Laszlo Gombos  <[email protected]>
+
+        Collapse testing for a list of PLATFORM() into OS() and USE() tests
+        https://bugs.webkit.org/show_bug.cgi?id=108018
+
+        Reviewed by Eric Seidel.
+
+        No functional change as "OS(DARWIN) && USE(CF)" equals to the
+        following platforms: MAC, WX, QT and CHROMIUM. CHROMIUM
+        is not using _javascript_Core. 
+
+        * runtime/DatePrototype.cpp:
+        (JSC):
+
 2013-01-28  Geoffrey Garen  <[email protected]>
 
         Static size inference for _javascript_ objects

Modified: trunk/Source/_javascript_Core/runtime/DatePrototype.cpp (141058 => 141059)


--- trunk/Source/_javascript_Core/runtime/DatePrototype.cpp	2013-01-29 06:55:27 UTC (rev 141058)
+++ trunk/Source/_javascript_Core/runtime/DatePrototype.cpp	2013-01-29 06:59:42 UTC (rev 141059)
@@ -61,7 +61,7 @@
 #include <sys/timeb.h>
 #endif
 
-#if PLATFORM(MAC) || PLATFORM(IOS) || (PLATFORM(WX) && OS(DARWIN)) || (PLATFORM(QT) && OS(DARWIN))
+#if OS(DARWIN) && USE(CF)
 #include <CoreFoundation/CoreFoundation.h>
 #elif USE(ICU_UNICODE)
 #include <unicode/udat.h>
@@ -125,9 +125,9 @@
 
 enum LocaleDateTimeFormat { LocaleDateAndTime, LocaleDate, LocaleTime };
  
-#if PLATFORM(MAC) || PLATFORM(IOS) || (PLATFORM(WX) && OS(DARWIN)) || (PLATFORM(QT) && OS(DARWIN))
+#if OS(DARWIN) && USE(CF)
 
-// FIXME: Since this is superior to the strftime-based version, why limit this to PLATFORM(MAC)?
+// FIXME: Since this is superior to the strftime-based version, why limit this to OS(DARWIN)?
 // Instead we should consider using this whenever USE(CF) is true.
 
 static CFDateFormatterStyle styleFromArgString(const String& string, CFDateFormatterStyle defaultStyle)
@@ -337,7 +337,7 @@
     return formatLocaleDate(exec, *gregorianDateTime, format);
 }
 
-#endif // !PLATFORM(MAC) && !PLATFORM(IOS)
+#endif // OS(DARWIN) && USE(CF)
 
 static EncodedJSValue formateDateInstance(ExecState* exec, DateTimeFormat format, bool asUTCVariant)
 {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to