Title: [141074] branches/chromium/1364
- Revision
- 141074
- Author
- [email protected]
- Date
- 2013-01-29 00:31:49 -0800 (Tue, 29 Jan 2013)
Log Message
Merge 139616
> Web Inspector: Audit Tool's False Positive on Set-Cookie header
> https://bugs.webkit.org/show_bug.cgi?id=106794
>
> Reviewed by Pavel Feldman.
>
> Source/WebCore:
>
> Header value is now returned as undefined if there is no such header as it was before regression.
>
> Test: http/tests/inspector/audits/set-cookie-header-audit-no-false-positive.html
>
> * inspector/front-end/AuditRules.js:
> (WebInspector.AuditRules.CSSRuleBase.prototype.sheetsCallback): Drive-by fix, callback should be called even when there is no headers.
> * inspector/front-end/NetworkRequest.js:
> (WebInspector.NetworkRequest.prototype._headerValue):
>
> LayoutTests:
>
> * http/tests/inspector/audits/resources/abe.png: Renamed from LayoutTests/inspector/audits/resources/abe.png.
> * http/tests/inspector/audits/set-cookie-header-audit-no-false-positive-expected.txt: Added.
> * http/tests/inspector/audits/set-cookie-header-audit-no-false-positive.html: Added.
>
[email protected]
BUG=169771
Review URL: https://codereview.chromium.org/12089042
Modified Paths
Removed Paths
Diff
Deleted: branches/chromium/1364/LayoutTests/inspector/audits/resources/abe.png
(Binary files differ)
Modified: branches/chromium/1364/Source/WebCore/inspector/front-end/AuditRules.js (141073 => 141074)
--- branches/chromium/1364/Source/WebCore/inspector/front-end/AuditRules.js 2013-01-29 08:30:09 UTC (rev 141073)
+++ branches/chromium/1364/Source/WebCore/inspector/front-end/AuditRules.js 2013-01-29 08:31:49 UTC (rev 141074)
@@ -1058,6 +1058,8 @@
if (error)
return callback(null);
+ if (!headers.length)
+ return callback(null);
for (var i = 0; i < headers.length; ++i) {
var header = headers[i];
if (header.disabled)
Modified: branches/chromium/1364/Source/WebCore/inspector/front-end/NetworkRequest.js (141073 => 141074)
--- branches/chromium/1364/Source/WebCore/inspector/front-end/NetworkRequest.js 2013-01-29 08:30:09 UTC (rev 141073)
+++ branches/chromium/1364/Source/WebCore/inspector/front-end/NetworkRequest.js 2013-01-29 08:31:49 UTC (rev 141074)
@@ -706,6 +706,8 @@
if (headers[i].name.toLowerCase() === headerName)
values.push(headers[i].value);
}
+ if (!values.length)
+ return undefined;
// Set-Cookie values should be separated by '\n', not comma, otherwise cookies could not be parsed.
if (headerName === "set-cookie")
return values.join("\n");
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes