Title: [141147] trunk/LayoutTests
- Revision
- 141147
- Author
- [email protected]
- Date
- 2013-01-29 12:54:16 -0800 (Tue, 29 Jan 2013)
Log Message
Current error reporting method used by check-layout.js should not affect subsequent sub-tests using checking data-offset-y.
https://bugs.webkit.org/show_bug.cgi?id=105407
Patch by Pravin D <[email protected]> on 2013-01-29
Reviewed by Tony Chang.
When a testcase is processed by check-layout.js, the result is written just after the node being processed. This causes
offsetTop of subsequent sub-testcases to altered. If however if we process the nodes in the reverse order in which they
appear in the DOM tree, the result of node being processed will not affect the offsetTop of susequent nodes.
* resources/check-layout.js:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (141146 => 141147)
--- trunk/LayoutTests/ChangeLog 2013-01-29 20:51:20 UTC (rev 141146)
+++ trunk/LayoutTests/ChangeLog 2013-01-29 20:54:16 UTC (rev 141147)
@@ -1,3 +1,16 @@
+2013-01-29 Pravin D <[email protected]>
+
+ Current error reporting method used by check-layout.js should not affect subsequent sub-tests using checking data-offset-y.
+ https://bugs.webkit.org/show_bug.cgi?id=105407
+
+ Reviewed by Tony Chang.
+
+ When a testcase is processed by check-layout.js, the result is written just after the node being processed. This causes
+ offsetTop of subsequent sub-testcases to altered. If however if we process the nodes in the reverse order in which they
+ appear in the DOM tree, the result of node being processed will not affect the offsetTop of susequent nodes.
+
+ * resources/check-layout.js:
+
2013-01-29 Dirk Schulze <[email protected]>
Canvas support for isPointInStroke
Modified: trunk/LayoutTests/resources/check-layout.js (141146 => 141147)
--- trunk/LayoutTests/resources/check-layout.js 2013-01-29 20:51:20 UTC (rev 141146)
+++ trunk/LayoutTests/resources/check-layout.js 2013-01-29 20:54:16 UTC (rev 141147)
@@ -163,6 +163,8 @@
return;
}
var nodes = document.querySelectorAll(selectorList);
+ nodes = Array.prototype.slice.call(nodes);
+ nodes.reverse();
Array.prototype.forEach.call(nodes, function(node) {
var failures = [];
checkExpectedValues(node.parentNode, failures);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
