Title: [141178] trunk/Source/_javascript_Core
- Revision
- 141178
- Author
- [email protected]
- Date
- 2013-01-29 16:30:33 -0800 (Tue, 29 Jan 2013)
Log Message
Remove redundant AST dump method from cloop.rb, since they are already defined in ast.rb
https://bugs.webkit.org/show_bug.cgi?id=108247
Reviewed by Oliver Hunt.
Makes offlineasm dumping easier to read and less likely to cause assertion failures.
Also fixes the strange situation where cloop.rb and ast.rb both defined dump methods,
but cloop.rb was winning.
* offlineasm/cloop.rb:
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (141177 => 141178)
--- trunk/Source/_javascript_Core/ChangeLog 2013-01-30 00:22:23 UTC (rev 141177)
+++ trunk/Source/_javascript_Core/ChangeLog 2013-01-30 00:30:33 UTC (rev 141178)
@@ -1,3 +1,16 @@
+2013-01-29 Filip Pizlo <[email protected]>
+
+ Remove redundant AST dump method from cloop.rb, since they are already defined in ast.rb
+ https://bugs.webkit.org/show_bug.cgi?id=108247
+
+ Reviewed by Oliver Hunt.
+
+ Makes offlineasm dumping easier to read and less likely to cause assertion failures.
+ Also fixes the strange situation where cloop.rb and ast.rb both defined dump methods,
+ but cloop.rb was winning.
+
+ * offlineasm/cloop.rb:
+
2013-01-29 Mark Hahnenberg <[email protected]>
Objective-C API: JSObjCClassInfo creates reference cycle with JSContext
Modified: trunk/Source/_javascript_Core/offlineasm/cloop.rb (141177 => 141178)
--- trunk/Source/_javascript_Core/offlineasm/cloop.rb 2013-01-30 00:22:23 UTC (rev 141177)
+++ trunk/Source/_javascript_Core/offlineasm/cloop.rb 2013-01-30 00:30:33 UTC (rev 141178)
@@ -66,67 +66,18 @@
C_LOOP_SCRATCH_FPR = SpecialRegister.new("d8")
class RegisterID
- def dump
- case name
- when "t0"
- "t0"
- when "t1"
- "t1"
- when "t2"
- "t2"
- when "t3"
- "t3"
- when "t4"
- "rPC"
- when "t6"
- "rBasePC"
- when "csr1"
- "tagTypeNumber"
- when "csr2"
- "tagMask"
- when "cfr"
- "cfr"
- when "lr"
- "rRetVPC"
- when "sp"
- "sp"
- else
- raise "Bad register #{name} for C_LOOP at #{codeOriginString}"
- end
- end
def clValue(type=:int)
dump + cloopMapType(type)
end
end
class FPRegisterID
- def dump
- case name
- when "ft0", "fr"
- "d0"
- when "ft1"
- "d1"
- when "ft2"
- "d2"
- when "ft3"
- "d3"
- when "ft4"
- "d4"
- when "ft5"
- "d5"
- else
- raise "Bad register #{name} for C_LOOP at #{codeOriginString}"
- end
- end
def clValue(type=:int)
dump + cloopMapType(type)
end
end
class Immediate
- def dump
- "#{value}"
- end
def clValue(type=:int)
# There is a case of a very large unsigned number (0x8000000000000000)
# which we wish to encode. Unfortunately, the C/C++ compiler
@@ -156,9 +107,6 @@
end
class Address
- def dump
- "[#{base.dump}, #{offset.value}]"
- end
def clValue(type=:int)
case type
when :int8; int8MemRef
@@ -229,9 +177,6 @@
end
class BaseIndex
- def dump
- "[#{base.dump}, #{offset.dump}, #{index.dump} << #{scaleShift}]"
- end
def clValue(type=:int)
case type
when :int8; int8MemRef
@@ -294,9 +239,6 @@
end
class AbsoluteAddress
- def dump
- "#{codeOriginString}"
- end
def clValue
dump
end
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
