Title: [141243] trunk
- Revision
- 141243
- Author
- [email protected]
- Date
- 2013-01-30 03:20:31 -0800 (Wed, 30 Jan 2013)
Log Message
REGRESSION (r139282): Caret repainting is broken for text-align: center'd <input>
https://bugs.webkit.org/show_bug.cgi?id=108283
Patch by Tien-Ren Chen <[email protected]> on 2013-01-30
Reviewed by Tim Horton.
Occasionally carets won't be fully erased when blinking.
There used to be 1-pixel padding but removed since r139282.
This patch adds back the same workaround.
Source/WebCore:
Need to rebaseline test expectations.
* editing/FrameSelection.cpp:
(WebCore::repaintCaretForLocalRect):
LayoutTests:
* platform/chromium/TestExpectations:
* platform/mac/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (141242 => 141243)
--- trunk/LayoutTests/ChangeLog 2013-01-30 10:52:58 UTC (rev 141242)
+++ trunk/LayoutTests/ChangeLog 2013-01-30 11:20:31 UTC (rev 141243)
@@ -1,3 +1,17 @@
+2013-01-30 Tien-Ren Chen <[email protected]>
+
+ REGRESSION (r139282): Caret repainting is broken for text-align: center'd <input>
+ https://bugs.webkit.org/show_bug.cgi?id=108283
+
+ Reviewed by Tim Horton.
+
+ Occasionally carets won't be fully erased when blinking.
+ There used to be 1-pixel padding but removed since r139282.
+ This patch adds back the same workaround.
+
+ * platform/chromium/TestExpectations:
+ * platform/mac/TestExpectations:
+
2013-01-30 Dominik Röttsches <[email protected]>
[EFL] Unreviewed gardening.
Modified: trunk/LayoutTests/platform/chromium/TestExpectations (141242 => 141243)
--- trunk/LayoutTests/platform/chromium/TestExpectations 2013-01-30 10:52:58 UTC (rev 141242)
+++ trunk/LayoutTests/platform/chromium/TestExpectations 2013-01-30 11:20:31 UTC (rev 141243)
@@ -4272,12 +4272,10 @@
webkit.org/b/108065 [ Debug ] tables/mozilla_expected_failures/bugs/bug2479-5.html [ Crash ]
# Transient. Needs rebaseline.
-webkit.org/b/103955 fast/repaint/caret-outside-block.html [ ImageOnlyFailure ]
-webkit.org/b/103955 [ Linux ] fast/repaint/japanese-rl-selection-repaint-in-regions.html [ ImageOnlyFailure ]
-webkit.org/b/103955 [ Linux Lion SnowLeopard ] fast/repaint/japanese-rl-selection-repaint.html [ ImageOnlyFailure ]
-webkit.org/b/103955 fast/repaint/repaint-across-writing-mode-boundary.html [ ImageOnlyFailure ]
-webkit.org/b/103955 fast/repaint/selection-rl.html [ ImageOnlyFailure ]
-webkit.org/b/103955 fast/repaint/caret-with-transformation.html [ Missing ]
+webkit.org/b/108283 fast/repaint/4774354.html [ ImageOnlyFailure ]
+webkit.org/b/108283 fast/repaint/4776765.html [ ImageOnlyFailure ]
+webkit.org/b/108283 fast/repaint/caret-with-transformation.html [ ImageOnlyFailure ]
+
webkit.org/b/106609 [ Win ] animations/fill-mode-iteration-count-non-integer.html [ Failure ]
webkit.org/b/106689 canvas/philip/tests/2d.gradient.interpolate.overlap2.html [ Failure ]
Modified: trunk/LayoutTests/platform/mac/TestExpectations (141242 => 141243)
--- trunk/LayoutTests/platform/mac/TestExpectations 2013-01-30 10:52:58 UTC (rev 141242)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2013-01-30 11:20:31 UTC (rev 141243)
@@ -1269,10 +1269,6 @@
webkit.org/b/39725 fast/events/drag-and-drop-autoscroll.html [ Skip ]
# Transient. Needs rebaseline.
-webkit.org/b/103955 fast/repaint/4774354.html [ ImageOnlyFailure ]
-webkit.org/b/103955 fast/repaint/4776765.html [ ImageOnlyFailure ]
-webkit.org/b/103955 fast/repaint/caret-outside-block.html [ ImageOnlyFailure ]
-webkit.org/b/103955 fast/repaint/selection-rl.html [ ImageOnlyFailure ]
webkit.org/b/103955 fast/repaint/caret-with-transformation.html [ Missing ]
# Needs rebaseline.
Modified: trunk/Source/WebCore/ChangeLog (141242 => 141243)
--- trunk/Source/WebCore/ChangeLog 2013-01-30 10:52:58 UTC (rev 141242)
+++ trunk/Source/WebCore/ChangeLog 2013-01-30 11:20:31 UTC (rev 141243)
@@ -1,3 +1,19 @@
+2013-01-30 Tien-Ren Chen <[email protected]>
+
+ REGRESSION (r139282): Caret repainting is broken for text-align: center'd <input>
+ https://bugs.webkit.org/show_bug.cgi?id=108283
+
+ Reviewed by Tim Horton.
+
+ Occasionally carets won't be fully erased when blinking.
+ There used to be 1-pixel padding but removed since r139282.
+ This patch adds back the same workaround.
+
+ Need to rebaseline test expectations.
+
+ * editing/FrameSelection.cpp:
+ (WebCore::repaintCaretForLocalRect):
+
2013-01-30 Dominik Röttsches <[email protected]>
[HarfBuzz] Remove the HarfBuzz-old code
Modified: trunk/Source/WebCore/editing/FrameSelection.cpp (141242 => 141243)
--- trunk/Source/WebCore/editing/FrameSelection.cpp 2013-01-30 10:52:58 UTC (rev 141242)
+++ trunk/Source/WebCore/editing/FrameSelection.cpp 2013-01-30 11:20:31 UTC (rev 141243)
@@ -1337,7 +1337,12 @@
if (!caretPainter)
return;
- caretPainter->repaintRectangle(rect);
+ // FIXME: Need to over-paint 1 pixel to workaround some rounding problems.
+ // https://bugs.webkit.org/show_bug.cgi?id=108283
+ LayoutRect inflatedRect = rect;
+ inflatedRect.inflate(1);
+
+ caretPainter->repaintRectangle(inflatedRect);
}
bool FrameSelection::recomputeCaretRect()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes