Diff
Modified: trunk/LayoutTests/ChangeLog (141386 => 141387)
--- trunk/LayoutTests/ChangeLog 2013-01-31 08:33:21 UTC (rev 141386)
+++ trunk/LayoutTests/ChangeLog 2013-01-31 08:38:25 UTC (rev 141387)
@@ -1,3 +1,14 @@
+2013-01-31 Sheriff Bot <[email protected]>
+
+ Unreviewed, rolling out r141110.
+ http://trac.webkit.org/changeset/141110
+ https://bugs.webkit.org/show_bug.cgi?id=108349
+
+ This patch broke WK2-EFL unit tests (Requested by grzegorz on
+ #webkit).
+
+ * platform/efl-wk2/TestExpectations:
+
2013-01-31 Kentaro Hara <[email protected]>
Add composition-event-constructor.html, which I forgot to add in r141028
Modified: trunk/LayoutTests/platform/efl-wk2/TestExpectations (141386 => 141387)
--- trunk/LayoutTests/platform/efl-wk2/TestExpectations 2013-01-31 08:33:21 UTC (rev 141386)
+++ trunk/LayoutTests/platform/efl-wk2/TestExpectations 2013-01-31 08:38:25 UTC (rev 141387)
@@ -316,9 +316,6 @@
# WebKitTestRunner setTouchPointRadius() is not supported
Bug(EFL) fast/events/touch/basic-single-touch-events.html [ Failure ]
-# On Linux, should be able to get spelling suggestions without selecting the misspelled word when unified text checker is enabled.
-webkit.org/b/107684 editing/spelling/context-menu-suggestions.html [ Failure ]
-
# Needs grammar checking
Bug(EFL) editing/spelling/grammar-edit-word.html [ Failure ]
Bug(EFL) editing/spelling/markers.html [ Failure ]
Modified: trunk/Source/WebCore/ChangeLog (141386 => 141387)
--- trunk/Source/WebCore/ChangeLog 2013-01-31 08:33:21 UTC (rev 141386)
+++ trunk/Source/WebCore/ChangeLog 2013-01-31 08:38:25 UTC (rev 141387)
@@ -1,3 +1,15 @@
+2013-01-31 Sheriff Bot <[email protected]>
+
+ Unreviewed, rolling out r141110.
+ http://trac.webkit.org/changeset/141110
+ https://bugs.webkit.org/show_bug.cgi?id=108349
+
+ This patch broke WK2-EFL unit tests (Requested by grzegorz on
+ #webkit).
+
+ * platform/text/TextChecking.h:
+ (WebCore):
+
2013-01-31 Kentaro Hara <[email protected]>
[V8] 'new MouseEvent("click", {relatedTarget: window}).window' should return window
Modified: trunk/Source/WebCore/platform/text/TextChecking.h (141386 => 141387)
--- trunk/Source/WebCore/platform/text/TextChecking.h 2013-01-31 08:33:21 UTC (rev 141386)
+++ trunk/Source/WebCore/platform/text/TextChecking.h 2013-01-31 08:38:25 UTC (rev 141387)
@@ -39,7 +39,7 @@
#define WTF_USE_GRAMMAR_CHECKING 1
-#if (PLATFORM(MAC) && (PLATFORM(IOS) || __MAC_OS_X_VERSION_MIN_REQUIRED >= 1060)) || PLATFORM(BLACKBERRY) || PLATFORM(EFL)
+#if (PLATFORM(MAC) && (PLATFORM(IOS) || __MAC_OS_X_VERSION_MIN_REQUIRED >= 1060)) || PLATFORM(BLACKBERRY)
#define WTF_USE_UNIFIED_TEXT_CHECKING 1
#endif
#if PLATFORM(MAC) && (PLATFORM(IOS) || __MAC_OS_X_VERSION_MIN_REQUIRED >= 1060)
Modified: trunk/Source/WebKit/efl/ChangeLog (141386 => 141387)
--- trunk/Source/WebKit/efl/ChangeLog 2013-01-31 08:33:21 UTC (rev 141386)
+++ trunk/Source/WebKit/efl/ChangeLog 2013-01-31 08:38:25 UTC (rev 141387)
@@ -1,3 +1,14 @@
+2013-01-31 Sheriff Bot <[email protected]>
+
+ Unreviewed, rolling out r141110.
+ http://trac.webkit.org/changeset/141110
+ https://bugs.webkit.org/show_bug.cgi?id=108349
+
+ This patch broke WK2-EFL unit tests (Requested by grzegorz on
+ #webkit).
+
+ * WebCoreSupport/EditorClientEfl.h:
+
2013-01-30 Huang Dongsung <[email protected]>
[TexMap] Remove GraphicsLayer in TextureMapperLayer.
Modified: trunk/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.h (141386 => 141387)
--- trunk/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.h 2013-01-31 08:33:21 UTC (rev 141386)
+++ trunk/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.h 2013-01-31 08:38:25 UTC (rev 141387)
@@ -149,9 +149,6 @@
virtual void willSetInputMethodState();
virtual void setInputMethodState(bool enabled);
virtual void requestCheckingOfString(WTF::PassRefPtr<WebCore::TextCheckingRequest>) { }
-#if USE(UNIFIED_TEXT_CHECKING)
- virtual void checkTextOfParagraph(const UChar*, int, TextCheckingTypeMask, Vector<TextCheckingResult>&) { }
-#endif
virtual TextCheckerClient* textChecker() { return this; }
private:
Modified: trunk/Source/WebKit2/ChangeLog (141386 => 141387)
--- trunk/Source/WebKit2/ChangeLog 2013-01-31 08:33:21 UTC (rev 141386)
+++ trunk/Source/WebKit2/ChangeLog 2013-01-31 08:38:25 UTC (rev 141387)
@@ -1,3 +1,16 @@
+2013-01-31 Sheriff Bot <[email protected]>
+
+ Unreviewed, rolling out r141110.
+ http://trac.webkit.org/changeset/141110
+ https://bugs.webkit.org/show_bug.cgi?id=108349
+
+ This patch broke WK2-EFL unit tests (Requested by grzegorz on
+ #webkit).
+
+ * UIProcess/efl/TextCheckerEfl.cpp:
+ * WebProcess/WebCoreSupport/WebEditorClient.h:
+ * WebProcess/WebCoreSupport/efl/WebEditorClientEfl.cpp:
+
2013-01-31 Jae Hyun Park <[email protected]>
Coordinated Graphics : Remove WebCoordinatedSurface dependency from CoordinatedSurface
Modified: trunk/Source/WebKit2/UIProcess/efl/TextCheckerEfl.cpp (141386 => 141387)
--- trunk/Source/WebKit2/UIProcess/efl/TextCheckerEfl.cpp 2013-01-31 08:33:21 UTC (rev 141386)
+++ trunk/Source/WebKit2/UIProcess/efl/TextCheckerEfl.cpp 2013-01-31 08:38:25 UTC (rev 141387)
@@ -124,39 +124,6 @@
#endif
}
-#if USE(UNIFIED_TEXT_CHECKING)
-Vector<TextCheckingResult> TextChecker::checkTextOfParagraph(int64_t spellDocumentTag, const UChar* text, int length, uint64_t checkingTypes)
-{
- Vector<TextCheckingResult> paragraphCheckingResult;
-#if ENABLE(SPELLCHECK)
- if (checkingTypes & TextCheckingTypeSpelling) {
- int offset = 0;
- while (offset < length) {
- int32_t misspellingLocation = -1;
- int32_t misspellingLength = 0;
- checkSpellingOfString(spellDocumentTag, text + offset, length - offset, misspellingLocation, misspellingLength);
- if (!misspellingLength)
- break;
-
- TextCheckingResult misspellingResult;
- misspellingResult.type = TextCheckingTypeSpelling;
- misspellingResult.location = offset + misspellingLocation;
- misspellingResult.length = misspellingLength;
- paragraphCheckingResult.append(misspellingResult);
-
- offset += misspellingLocation + misspellingLength;
- }
- }
-#else
- UNUSED_PARAM(spellDocumentTag);
- UNUSED_PARAM(text);
- UNUSED_PARAM(length);
- UNUSED_PARAM(checkingTypes);
-#endif
- return paragraphCheckingResult;
-}
-#endif
-
void TextChecker::checkSpellingOfString(int64_t spellDocumentTag, const UChar* text, uint32_t length, int32_t& misspellingLocation, int32_t& misspellingLength)
{
#if ENABLE(SPELLCHECK)
Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.h (141386 => 141387)
--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.h 2013-01-31 08:33:21 UTC (rev 141386)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.h 2013-01-31 08:38:25 UTC (rev 141387)
@@ -137,7 +137,7 @@
virtual void checkSpellingOfString(const UChar*, int length, int* misspellingLocation, int* misspellingLength) OVERRIDE;
virtual String getAutoCorrectSuggestionForMisspelledWord(const String& misspelledWord) OVERRIDE;
virtual void checkGrammarOfString(const UChar*, int length, Vector<WebCore::GrammarDetail>&, int* badGrammarLocation, int* badGrammarLength) OVERRIDE;
-#if PLATFORM(MAC) || PLATFORM(EFL)
+#if PLATFORM(MAC)
virtual void checkTextOfParagraph(const UChar* text, int length, WebCore::TextCheckingTypeMask checkingTypes, Vector<WebCore::TextCheckingResult>& results) OVERRIDE;
#endif
virtual void updateSpellingUIWithGrammarString(const String&, const WebCore::GrammarDetail&) OVERRIDE;
Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/efl/WebEditorClientEfl.cpp (141386 => 141387)
--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/efl/WebEditorClientEfl.cpp 2013-01-31 08:33:21 UTC (rev 141386)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/efl/WebEditorClientEfl.cpp 2013-01-31 08:38:25 UTC (rev 141387)
@@ -60,9 +60,4 @@
event->setDefaultHandled();
}
-void WebEditorClient::checkTextOfParagraph(const UChar* text, int length, WebCore::TextCheckingTypeMask checkingTypes, Vector<TextCheckingResult>& results)
-{
- m_page->sendSync(Messages::WebPageProxy::CheckTextOfParagraph(String(text, length), checkingTypes), Messages::WebPageProxy::CheckTextOfParagraph::Reply(results));
}
-
-}
