Title: [141420] trunk/Source/WebCore
Revision
141420
Author
[email protected]
Date
2013-01-31 07:07:34 -0800 (Thu, 31 Jan 2013)

Log Message

[Qt] Fix minor memory leak in slot execution

Reviewed by Allan Sandfeld Jensen.

Don't leak the "length" string when executing a slot in _javascript_.

* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtConnectionObject::execute):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (141419 => 141420)


--- trunk/Source/WebCore/ChangeLog	2013-01-31 14:59:29 UTC (rev 141419)
+++ trunk/Source/WebCore/ChangeLog	2013-01-31 15:07:34 UTC (rev 141420)
@@ -1,3 +1,14 @@
+2013-01-31  Simon Hausmann  <[email protected]>
+
+        [Qt] Fix minor memory leak in slot execution
+
+        Reviewed by Allan Sandfeld Jensen.
+
+        Don't leak the "length" string when executing a slot in _javascript_.
+
+        * bridge/qt/qt_runtime.cpp:
+        (JSC::Bindings::QtConnectionObject::execute):
+
 2013-01-31  Mike West  <[email protected]>
 
         Allow blocking of IndexedDB in third-party contexts

Modified: trunk/Source/WebCore/bridge/qt/qt_runtime.cpp (141419 => 141420)


--- trunk/Source/WebCore/bridge/qt/qt_runtime.cpp	2013-01-31 14:59:29 UTC (rev 141419)
+++ trunk/Source/WebCore/bridge/qt/qt_runtime.cpp	2013-01-31 15:07:34 UTC (rev 141420)
@@ -1559,7 +1559,7 @@
     const QMetaMethod method = meta->method(m_signalIndex);
 
     JSValueRef* ignoredException = 0;
-    JSRetainPtr<JSStringRef> lengthProperty(JSStringCreateWithUTF8CString("length"));
+    JSRetainPtr<JSStringRef> lengthProperty(Adopt, JSStringCreateWithUTF8CString("length"));
     int receiverLength = int(JSValueToNumber(m_context, JSObjectGetProperty(m_context, m_receiverFunction, lengthProperty.get(), ignoredException), ignoredException));
     int argc = qMax(method.parameterCount(), receiverLength);
     WTF::Vector<JSValueRef> args(argc);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to