Title: [141427] trunk/Source/WebCore
Revision
141427
Author
[email protected]
Date
2013-01-31 09:36:46 -0800 (Thu, 31 Jan 2013)

Log Message

[Skia] Update SkiaImageFilterBuilder's brightness matrix to match Chromium's implementation
https://bugs.webkit.org/show_bug.cgi?id=107841

Reviewed by Stephen White.

Update Skia's brightness filter to match the spec after http://trac.webkit.org/changeset/139770.

No new tests: covered by existing tests (currently disabled pending rebaseline).

* platform/graphics/filters/skia/SkiaImageFilterBuilder.cpp:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (141426 => 141427)


--- trunk/Source/WebCore/ChangeLog	2013-01-31 17:17:30 UTC (rev 141426)
+++ trunk/Source/WebCore/ChangeLog	2013-01-31 17:36:46 UTC (rev 141427)
@@ -1,3 +1,16 @@
+2013-01-31  Florin Malita  <[email protected]>
+
+        [Skia] Update SkiaImageFilterBuilder's brightness matrix to match Chromium's implementation
+        https://bugs.webkit.org/show_bug.cgi?id=107841
+
+        Reviewed by Stephen White.
+
+        Update Skia's brightness filter to match the spec after http://trac.webkit.org/changeset/139770.
+
+        No new tests: covered by existing tests (currently disabled pending rebaseline).
+
+        * platform/graphics/filters/skia/SkiaImageFilterBuilder.cpp:
+
 2013-01-31  Andrey Lushnikov  <[email protected]>
 
         Web Inspector: show cursor location in DTE

Modified: trunk/Source/WebCore/platform/graphics/filters/skia/SkiaImageFilterBuilder.cpp (141426 => 141427)


--- trunk/Source/WebCore/platform/graphics/filters/skia/SkiaImageFilterBuilder.cpp	2013-01-31 17:17:30 UTC (rev 141426)
+++ trunk/Source/WebCore/platform/graphics/filters/skia/SkiaImageFilterBuilder.cpp	2013-01-31 17:36:46 UTC (rev 141427)
@@ -39,8 +39,8 @@
 void getBrightnessMatrix(float amount, SkScalar matrix[20])
 {
     memset(matrix, 0, 20 * sizeof(SkScalar));
-    matrix[0] = matrix[6] = matrix[12] = matrix[18] = 1;
-    matrix[4] = matrix[9] = matrix[14] = amount * 255;
+    matrix[0] = matrix[6] = matrix[12] = amount;
+    matrix[18] = 1;
 }
 
 void getContrastMatrix(float amount, SkScalar matrix[20])
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to