Title: [141563] trunk/Source/WebCore
- Revision
- 141563
- Author
- [email protected]
- Date
- 2013-02-01 02:07:25 -0800 (Fri, 01 Feb 2013)
Log Message
Web Inspector: Sources panel navigator reveal and expand fixes.
https://bugs.webkit.org/show_bug.cgi?id=108584
Reviewed by Pavel Feldman.
Navigator folders are not expanded by default anymore.
Made domain folder expanded for inspected page main frame domain.
UISourceCodes are now added to navigator before editor container
so that they could be revealed if editor container decides to show them.
* inspector/front-end/NavigatorView.js:
(WebInspector.BaseNavigatorTreeElement.prototype.onattach):
(WebInspector.NavigatorFolderTreeElement.prototype.onattach):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._addUISourceCode):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (141562 => 141563)
--- trunk/Source/WebCore/ChangeLog 2013-02-01 10:06:06 UTC (rev 141562)
+++ trunk/Source/WebCore/ChangeLog 2013-02-01 10:07:25 UTC (rev 141563)
@@ -1,3 +1,21 @@
+2013-02-01 Vsevolod Vlasov <[email protected]>
+
+ Web Inspector: Sources panel navigator reveal and expand fixes.
+ https://bugs.webkit.org/show_bug.cgi?id=108584
+
+ Reviewed by Pavel Feldman.
+
+ Navigator folders are not expanded by default anymore.
+ Made domain folder expanded for inspected page main frame domain.
+ UISourceCodes are now added to navigator before editor container
+ so that they could be revealed if editor container decides to show them.
+
+ * inspector/front-end/NavigatorView.js:
+ (WebInspector.BaseNavigatorTreeElement.prototype.onattach):
+ (WebInspector.NavigatorFolderTreeElement.prototype.onattach):
+ * inspector/front-end/ScriptsPanel.js:
+ (WebInspector.ScriptsPanel.prototype._addUISourceCode):
+
2013-02-01 Andrey Adaikin <[email protected]>
Web Inspector: [Canvas] drop trace log in the backend when deleting profile in frontend
Modified: trunk/Source/WebCore/inspector/front-end/NavigatorView.js (141562 => 141563)
--- trunk/Source/WebCore/inspector/front-end/NavigatorView.js 2013-02-01 10:06:06 UTC (rev 141562)
+++ trunk/Source/WebCore/inspector/front-end/NavigatorView.js 2013-02-01 10:07:25 UTC (rev 141563)
@@ -460,7 +460,6 @@
this._titleTextNode.textContent = this._titleText;
this.titleElement.appendChild(this._titleTextNode);
this.listItemElement.appendChild(this.titleElement);
- this.expand();
},
onreveal: function()
@@ -536,10 +535,10 @@
onattach: function()
{
WebInspector.BaseNavigatorTreeElement.prototype.onattach.call(this);
- if (this.isDomain && this.titleText != WebInspector.inspectedPageDomain)
- this.collapse();
- else
+ if (this.isDomain && this.titleText === WebInspector.inspectedPageDomain)
this.expand();
+ else
+ this.collapse();
},
__proto__: WebInspector.BaseNavigatorTreeElement.prototype
Modified: trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js (141562 => 141563)
--- trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js 2013-02-01 10:06:06 UTC (rev 141562)
+++ trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js 2013-02-01 10:07:25 UTC (rev 141563)
@@ -245,8 +245,8 @@
var projectName = uiSourceCode.project().name();
if (uiSourceCode.project().isServiceProject())
return;
+ this._navigator.addUISourceCode(uiSourceCode);
this._editorContainer.addUISourceCode(uiSourceCode);
- this._navigator.addUISourceCode(uiSourceCode);
// Replace debugger script-based uiSourceCode with a network-based one.
var currentUISourceCode = this._currentUISourceCode;
if (currentUISourceCode && currentUISourceCode.project().isServiceProject() && currentUISourceCode !== uiSourceCode && currentUISourceCode.url ="" uiSourceCode.url) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
