Diff
Modified: trunk/Source/WebCore/ChangeLog (141573 => 141574)
--- trunk/Source/WebCore/ChangeLog 2013-02-01 11:22:04 UTC (rev 141573)
+++ trunk/Source/WebCore/ChangeLog 2013-02-01 11:26:17 UTC (rev 141574)
@@ -1,3 +1,30 @@
+2013-02-01 Andrey Adaikin <[email protected]>
+
+ Web Inspector: fix jscompiler warnings
+ https://bugs.webkit.org/show_bug.cgi?id=108604
+
+ Reviewed by Pavel Feldman.
+
+ * inspector/front-end/ConsoleView.js:
+ (WebInspector.ConsoleGroup.prototype.addMessage):
+ * inspector/front-end/ContextMenu.js:
+ (WebInspector.ContextSubMenuItem):
+ * inspector/front-end/ImageView.js:
+ (WebInspector.ImageView.prototype._copyImageURL):
+ (WebInspector.ImageView.prototype._openInNewTab):
+ * inspector/front-end/NetworkPanel.js:
+ (WebInspector.NetworkLogView.prototype._clearBrowserCache):
+ (WebInspector.NetworkLogView.prototype._clearBrowserCookies):
+ * inspector/front-end/ResourcesPanel.js:
+ (WebInspector.IDBDatabaseTreeElement.prototype._refreshIndexedDB):
+ * inspector/front-end/ScriptsNavigator.js:
+ (WebInspector.SnippetsNavigatorView.prototype._handleEvaluateSnippet):
+ (WebInspector.SnippetsNavigatorView.prototype._handleRenameSnippet):
+ (WebInspector.SnippetsNavigatorView.prototype._handleRemoveSnippet):
+ (WebInspector.SnippetsNavigatorView.prototype._handleCreateSnippet):
+ * inspector/front-end/Toolbar.js:
+ (WebInspector.Toolbar.prototype._isDockedToBottom):
+
2013-02-01 Jae Hyun Park <[email protected]>
Modified: trunk/Source/WebCore/inspector/front-end/ConsoleView.js (141573 => 141574)
--- trunk/Source/WebCore/inspector/front-end/ConsoleView.js 2013-02-01 11:22:04 UTC (rev 141573)
+++ trunk/Source/WebCore/inspector/front-end/ConsoleView.js 2013-02-01 11:26:17 UTC (rev 141574)
@@ -820,7 +820,7 @@
if (groupElement && message.type === WebInspector.ConsoleMessage.MessageType.StartGroupCollapsed)
groupElement.addStyleClass("collapsed");
} else
- this.messagesElement.insertBefore(element, node);
+ this.messagesElement.insertBefore(element, node || null);
if (element.previousSibling && message.originatingCommand && element.previousSibling.command === message.originatingCommand)
element.previousSibling.addStyleClass("console-adjacent-user-command-result");
Modified: trunk/Source/WebCore/inspector/front-end/ContextMenu.js (141573 => 141574)
--- trunk/Source/WebCore/inspector/front-end/ContextMenu.js 2013-02-01 11:22:04 UTC (rev 141573)
+++ trunk/Source/WebCore/inspector/front-end/ContextMenu.js 2013-02-01 11:26:17 UTC (rev 141574)
@@ -97,13 +97,14 @@
WebInspector.ContextSubMenuItem = function(topLevelMenu, label, disabled)
{
WebInspector.ContextMenuItem.call(this, topLevelMenu, "subMenu", label, disabled);
+ /** @type {!Array.<!WebInspector.ContextMenuItem>} */
this._items = [];
}
WebInspector.ContextSubMenuItem.prototype = {
/**
* @param {string} label
- * @param {function} handler
+ * @param {function(?)} handler
* @param {boolean=} disabled
* @return {WebInspector.ContextMenuItem}
*/
@@ -144,6 +145,9 @@
this._pendingSeparator = true;
},
+ /**
+ * @param {!WebInspector.ContextMenuItem} item
+ */
_pushItem: function(item)
{
if (this._pendingSeparator) {
Modified: trunk/Source/WebCore/inspector/front-end/ImageView.js (141573 => 141574)
--- trunk/Source/WebCore/inspector/front-end/ImageView.js 2013-02-01 11:22:04 UTC (rev 141573)
+++ trunk/Source/WebCore/inspector/front-end/ImageView.js 2013-02-01 11:26:17 UTC (rev 141574)
@@ -132,12 +132,12 @@
contextMenu.show();
},
- _copyImageURL: function(event)
+ _copyImageURL: function()
{
InspectorFrontendHost.copyText(this.resource.url);
},
- _openInNewTab: function(event)
+ _openInNewTab: function()
{
InspectorFrontendHost.openInNewTab(this.resource.url);
},
Modified: trunk/Source/WebCore/inspector/front-end/NetworkPanel.js (141573 => 141574)
--- trunk/Source/WebCore/inspector/front-end/NetworkPanel.js 2013-02-01 11:22:04 UTC (rev 141573)
+++ trunk/Source/WebCore/inspector/front-end/NetworkPanel.js 2013-02-01 11:26:17 UTC (rev 141574)
@@ -1089,13 +1089,13 @@
}
},
- _clearBrowserCache: function(event)
+ _clearBrowserCache: function()
{
if (confirm(WebInspector.UIString("Are you sure you want to clear browser cache?")))
NetworkAgent.clearBrowserCache();
},
- _clearBrowserCookies: function(event)
+ _clearBrowserCookies: function()
{
if (confirm(WebInspector.UIString("Are you sure you want to clear browser cookies?")))
NetworkAgent.clearBrowserCookies();
Modified: trunk/Source/WebCore/inspector/front-end/ResourcesPanel.js (141573 => 141574)
--- trunk/Source/WebCore/inspector/front-end/ResourcesPanel.js 2013-02-01 11:22:04 UTC (rev 141573)
+++ trunk/Source/WebCore/inspector/front-end/ResourcesPanel.js 2013-02-01 11:26:17 UTC (rev 141574)
@@ -1611,7 +1611,7 @@
contextMenu.show();
},
- _refreshIndexedDB: function(event)
+ _refreshIndexedDB: function()
{
this._model.refreshDatabaseNames();
},
Modified: trunk/Source/WebCore/inspector/front-end/ScriptsNavigator.js (141573 => 141574)
--- trunk/Source/WebCore/inspector/front-end/ScriptsNavigator.js 2013-02-01 11:22:04 UTC (rev 141573)
+++ trunk/Source/WebCore/inspector/front-end/ScriptsNavigator.js 2013-02-01 11:26:17 UTC (rev 141574)
@@ -216,9 +216,8 @@
/**
* @param {WebInspector.UISourceCode} uiSourceCode
- * @param {Event} event
*/
- _handleEvaluateSnippet: function(uiSourceCode, event)
+ _handleEvaluateSnippet: function(uiSourceCode)
{
if (!uiSourceCode.isSnippet)
return;
@@ -227,28 +226,23 @@
/**
* @param {WebInspector.UISourceCode} uiSourceCode
- * @param {Event} event
*/
- _handleRenameSnippet: function(uiSourceCode, event)
+ _handleRenameSnippet: function(uiSourceCode)
{
this.dispatchEventToListeners(WebInspector.ScriptsNavigator.Events.ItemRenamingRequested, uiSourceCode);
},
/**
* @param {WebInspector.UISourceCode} uiSourceCode
- * @param {Event} event
*/
- _handleRemoveSnippet: function(uiSourceCode, event)
+ _handleRemoveSnippet: function(uiSourceCode)
{
if (!uiSourceCode.isSnippet)
return;
WebInspector.scriptSnippetModel.deleteScriptSnippet(uiSourceCode);
},
- /**
- * @param {Event} event
- */
- _handleCreateSnippet: function(event)
+ _handleCreateSnippet: function()
{
this._snippetCreationRequested();
},
Modified: trunk/Source/WebCore/inspector/front-end/Toolbar.js (141573 => 141574)
--- trunk/Source/WebCore/inspector/front-end/Toolbar.js 2013-02-01 11:22:04 UTC (rev 141573)
+++ trunk/Source/WebCore/inspector/front-end/Toolbar.js 2013-02-01 11:26:17 UTC (rev 141574)
@@ -101,7 +101,7 @@
*/
_isDockedToBottom: function()
{
- return WebInspector.dockController && WebInspector.dockController.isDockedToBottom();
+ return !!WebInspector.dockController && WebInspector.dockController.isDockedToBottom();
},
/**
