Diff
Modified: trunk/Source/WebCore/ChangeLog (141798 => 141799)
--- trunk/Source/WebCore/ChangeLog 2013-02-04 21:15:51 UTC (rev 141798)
+++ trunk/Source/WebCore/ChangeLog 2013-02-04 21:22:01 UTC (rev 141799)
@@ -1,3 +1,24 @@
+2013-02-04 Enrica Casucci <[email protected]>
+
+ Add specific EditActions for Bold and Italic commands.
+ https://bugs.webkit.org/show_bug.cgi?id=108842.
+ <rdar://problem/13098252>
+
+ This change is required on iOS where we need to
+ identify the command in order to display the correct
+ message in the undo popup. It is also in line with
+ what we do for underline, which already has its own
+ separate EditAction.
+
+ Reviewed by Ryosuke Niwa.
+
+ No new tests. No behavior change.
+
+ * editing/EditAction.h:
+ * editing/EditorCommand.cpp:
+ (WebCore::executeToggleBold):
+ (WebCore::executeToggleItalic):
+
2013-02-04 Dima Gorbik <[email protected]>
Implemet :lang() pseudo class support for the WebVTT ::cue pseudo element
Modified: trunk/Source/WebCore/editing/EditAction.h (141798 => 141799)
--- trunk/Source/WebCore/editing/EditAction.h 2013-02-04 21:15:51 UTC (rev 141798)
+++ trunk/Source/WebCore/editing/EditAction.h 2013-02-04 21:22:01 UTC (rev 141799)
@@ -55,6 +55,8 @@
EditActionUnscript,
EditActionDrag,
EditActionCut,
+ EditActionBold,
+ EditActionItalics,
EditActionPaste,
EditActionPasteFont,
EditActionPasteRuler,
Modified: trunk/Source/WebCore/editing/EditorCommand.cpp (141798 => 141799)
--- trunk/Source/WebCore/editing/EditorCommand.cpp 2013-02-04 21:15:51 UTC (rev 141798)
+++ trunk/Source/WebCore/editing/EditorCommand.cpp 2013-02-04 21:22:01 UTC (rev 141799)
@@ -1096,12 +1096,12 @@
static bool executeToggleBold(Frame* frame, Event*, EditorCommandSource source, const String&)
{
- return executeToggleStyle(frame, source, EditActionChangeAttributes, CSSPropertyFontWeight, "normal", "bold");
+ return executeToggleStyle(frame, source, EditActionBold, CSSPropertyFontWeight, "normal", "bold");
}
static bool executeToggleItalic(Frame* frame, Event*, EditorCommandSource source, const String&)
{
- return executeToggleStyle(frame, source, EditActionChangeAttributes, CSSPropertyFontStyle, "normal", "italic");
+ return executeToggleStyle(frame, source, EditActionItalics, CSSPropertyFontStyle, "normal", "italic");
}
static bool executeTranspose(Frame* frame, Event*, EditorCommandSource, const String&)
Modified: trunk/Source/WebKit/mac/ChangeLog (141798 => 141799)
--- trunk/Source/WebKit/mac/ChangeLog 2013-02-04 21:15:51 UTC (rev 141798)
+++ trunk/Source/WebKit/mac/ChangeLog 2013-02-04 21:22:01 UTC (rev 141799)
@@ -1,3 +1,14 @@
+2013-02-04 Enrica Casucci <[email protected]>
+
+ Add specific EditActions for Bold and Italic commands.
+ https://bugs.webkit.org/show_bug.cgi?id=108842.
+ <rdar://problem/13098252>
+
+ Reviewed by Ryosuke Niwa.
+
+ * WebCoreSupport/WebEditorClient.mm:
+ (undoNameForEditAction):
+
2013-02-03 David Kilzer <[email protected]>
Upstream ENABLE_PDFKIT_PLUGIN settting
Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm (141798 => 141799)
--- trunk/Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm 2013-02-04 21:15:51 UTC (rev 141798)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm 2013-02-04 21:22:01 UTC (rev 141799)
@@ -519,6 +519,8 @@
case EditActionFormatBlock: return UI_STRING_KEY_INTERNAL("Formatting", "Format Block (Undo action name)", "Undo action name");
case EditActionIndent: return UI_STRING_KEY_INTERNAL("Indent", "Indent (Undo action name)", "Undo action name");
case EditActionOutdent: return UI_STRING_KEY_INTERNAL("Outdent", "Outdent (Undo action name)", "Undo action name");
+ case EditActionBold: return UI_STRING_KEY_INTERNAL("Bold", "Bold (Undo action name)", "Undo action name");
+ case EditActionItalics: return UI_STRING_KEY_INTERNAL("Italics", "Italics (Undo action name)", "Undo action name");
}
return nil;
}
Modified: trunk/Source/WebKit/qt/ChangeLog (141798 => 141799)
--- trunk/Source/WebKit/qt/ChangeLog 2013-02-04 21:15:51 UTC (rev 141798)
+++ trunk/Source/WebKit/qt/ChangeLog 2013-02-04 21:22:01 UTC (rev 141799)
@@ -1,3 +1,14 @@
+2013-02-04 Enrica Casucci <[email protected]>
+
+ Add specific EditActions for Bold and Italic commands.
+ https://bugs.webkit.org/show_bug.cgi?id=108842.
+ <rdar://problem/13098252>
+
+ Reviewed by Ryosuke Niwa.
+
+ * WebCoreSupport/UndoStepQt.cpp:
+ (undoNameForEditAction):
+
2013-02-04 Abhishek Arya <[email protected]>
Add ASSERT_WITH_SECURITY_IMPLICATION to detect bad cast in DOM, CSS, etc.
Modified: trunk/Source/WebKit/qt/WebCoreSupport/UndoStepQt.cpp (141798 => 141799)
--- trunk/Source/WebKit/qt/WebCoreSupport/UndoStepQt.cpp 2013-02-04 21:15:51 UTC (rev 141798)
+++ trunk/Source/WebKit/qt/WebCoreSupport/UndoStepQt.cpp 2013-02-04 21:22:01 UTC (rev 141799)
@@ -69,6 +69,10 @@
return QObject::tr("Set Writing Direction");
case EditActionSubscript:
return QObject::tr("Subscript");
+ case EditActionBold:
+ return QObject::tr("Bold");
+ case EditActionItalics:
+ return QObject::tr("Italic");
case EditActionSuperscript:
return QObject::tr("Superscript");
case EditActionUnderline:
Modified: trunk/Source/WebKit/win/ChangeLog (141798 => 141799)
--- trunk/Source/WebKit/win/ChangeLog 2013-02-04 21:15:51 UTC (rev 141798)
+++ trunk/Source/WebKit/win/ChangeLog 2013-02-04 21:22:01 UTC (rev 141799)
@@ -1,3 +1,14 @@
+2013-02-04 Enrica Casucci <[email protected]>
+
+ Add specific EditActions for Bold and Italic commands.
+ https://bugs.webkit.org/show_bug.cgi?id=108842.
+ <rdar://problem/13098252>
+
+ Reviewed by Ryosuke Niwa.
+
+ * WebCoreSupport/WebEditorClient.cpp:
+ (undoNameForEditAction):
+
2013-02-03 KwangYong Choi <[email protected]>
Fix build warning after r141473
Modified: trunk/Source/WebKit/win/WebCoreSupport/WebEditorClient.cpp (141798 => 141799)
--- trunk/Source/WebKit/win/WebCoreSupport/WebEditorClient.cpp 2013-02-04 21:15:51 UTC (rev 141798)
+++ trunk/Source/WebKit/win/WebCoreSupport/WebEditorClient.cpp 2013-02-04 21:22:01 UTC (rev 141799)
@@ -518,6 +518,8 @@
case EditActionSetWritingDirection: return WEB_UI_STRING_KEY("Set Writing Direction", "Set Writing Direction (Undo action name)", "Undo action name");
case EditActionSubscript: return WEB_UI_STRING_KEY("Subscript", "Subscript (Undo action name)", "Undo action name");
case EditActionSuperscript: return WEB_UI_STRING_KEY("Superscript", "Superscript (Undo action name)", "Undo action name");
+ case EditActionBold: return WEB_UI_STRING_KEY("Bold", "Bold (Undo action name)", "Undo action name");
+ case EditActionItalics: return WEB_UI_STRING_KEY("Italics", "Italics (Undo action name)", "Undo action name");
case EditActionUnderline: return WEB_UI_STRING_KEY("Underline", "Underline (Undo action name)", "Undo action name");
case EditActionOutline: return WEB_UI_STRING_KEY("Outline", "Outline (Undo action name)", "Undo action name");
case EditActionUnscript: return WEB_UI_STRING_KEY("Unscript", "Unscript (Undo action name)", "Undo action name");
Modified: trunk/Source/WebKit2/ChangeLog (141798 => 141799)
--- trunk/Source/WebKit2/ChangeLog 2013-02-04 21:15:51 UTC (rev 141798)
+++ trunk/Source/WebKit2/ChangeLog 2013-02-04 21:22:01 UTC (rev 141799)
@@ -1,3 +1,14 @@
+2013-02-04 Enrica Casucci <[email protected]>
+
+ Add specific EditActions for Bold and Italic commands.
+ https://bugs.webkit.org/show_bug.cgi?id=108842.
+ <rdar://problem/13098252>
+
+ Reviewed by Ryosuke Niwa.
+
+ * UIProcess/WebEditCommandProxy.cpp:
+ (WebKit::WebEditCommandProxy::nameForEditAction):
+
2013-02-04 Anders Carlsson <[email protected]>
Use a separate queue for the connection watchdog callback in the web process
Modified: trunk/Source/WebKit2/UIProcess/WebEditCommandProxy.cpp (141798 => 141799)
--- trunk/Source/WebKit2/UIProcess/WebEditCommandProxy.cpp 2013-02-04 21:15:51 UTC (rev 141798)
+++ trunk/Source/WebKit2/UIProcess/WebEditCommandProxy.cpp 2013-02-04 21:22:01 UTC (rev 141799)
@@ -125,6 +125,10 @@
return WEB_UI_STRING_KEY("Drag", "Drag (Undo action name)", "Undo action name");
case EditActionCut:
return WEB_UI_STRING_KEY("Cut", "Cut (Undo action name)", "Undo action name");
+ case EditActionBold:
+ return WEB_UI_STRING_KEY("Bold", "Bold (Undo action name)", "Undo action name");
+ case EditActionItalics:
+ return WEB_UI_STRING_KEY("Italics", "Italics (Undo action name)", "Undo action name");
case EditActionPaste:
return WEB_UI_STRING_KEY("Paste", "Paste (Undo action name)", "Undo action name");
case EditActionPasteFont:
