Title: [141822] trunk/Source/WebCore
- Revision
- 141822
- Author
- [email protected]
- Date
- 2013-02-04 15:19:49 -0800 (Mon, 04 Feb 2013)
Log Message
[Soup] Remove duplicate setting of first party for cookies
https://bugs.webkit.org/show_bug.cgi?id=108814
Reviewed by Martin Robinson.
Covered by existing tests.
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::createSoupMessageForHandleAndRequest): there is no need to set
the first party for cookies here, since that is already done in
ResourceRequest::updateSoupMessage, which is called a few lines before.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (141821 => 141822)
--- trunk/Source/WebCore/ChangeLog 2013-02-04 23:18:33 UTC (rev 141821)
+++ trunk/Source/WebCore/ChangeLog 2013-02-04 23:19:49 UTC (rev 141822)
@@ -1,3 +1,17 @@
+2013-02-04 Gustavo Noronha Silva <[email protected]>
+
+ [Soup] Remove duplicate setting of first party for cookies
+ https://bugs.webkit.org/show_bug.cgi?id=108814
+
+ Reviewed by Martin Robinson.
+
+ Covered by existing tests.
+
+ * platform/network/soup/ResourceHandleSoup.cpp:
+ (WebCore::createSoupMessageForHandleAndRequest): there is no need to set
+ the first party for cookies here, since that is already done in
+ ResourceRequest::updateSoupMessage, which is called a few lines before.
+
2013-02-04 Gustavo Noronha Silva <[email protected]>
[GStreamer][Soup] Let GStreamer provide the buffer data is downloaded to, to avoid copying
Modified: trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp (141821 => 141822)
--- trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp 2013-02-04 23:18:33 UTC (rev 141821)
+++ trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp 2013-02-04 23:19:49 UTC (rev 141822)
@@ -956,12 +956,6 @@
if (!handle->shouldContentSniff())
soup_message_disable_feature(soupMessage, SOUP_TYPE_CONTENT_SNIFFER);
- String firstPartyString = request.firstPartyForCookies().string();
- if (!firstPartyString.isEmpty()) {
- GOwnPtr<SoupURI> firstParty(soup_uri_new(firstPartyString.utf8().data()));
- soup_message_set_first_party(soupMessage, firstParty.get());
- }
-
FormData* httpBody = request.httpBody();
CString contentType = request.httpContentType().utf8().data();
if (httpBody && !httpBody->isEmpty() && !addFormElementsToSoupMessage(soupMessage, contentType.data(), httpBody, d->m_bodySize)) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
