Title: [141832] trunk/Source/WebCore
Revision
141832
Author
[email protected]
Date
2013-02-04 16:46:59 -0800 (Mon, 04 Feb 2013)

Log Message

[skia] Remove use of SkSingleInputImageFilter.
https://bugs.webkit.org/show_bug.cgi?id=108867

Reviewed by James Robinson.

This class is but a hollow shell of its former self, and has
been removed in Skia.

Covered by existing tests in css3/filters.

* platform/graphics/filters/skia/DropShadowImageFilter.cpp:
(WebCore::DropShadowImageFilter::DropShadowImageFilter):
(WebCore::DropShadowImageFilter::onFilterImage):
* platform/graphics/filters/skia/DropShadowImageFilter.h:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (141831 => 141832)


--- trunk/Source/WebCore/ChangeLog	2013-02-05 00:39:09 UTC (rev 141831)
+++ trunk/Source/WebCore/ChangeLog	2013-02-05 00:46:59 UTC (rev 141832)
@@ -1,3 +1,20 @@
+2013-02-04  Stephen White  <[email protected]>
+
+        [skia] Remove use of SkSingleInputImageFilter.
+        https://bugs.webkit.org/show_bug.cgi?id=108867
+
+        Reviewed by James Robinson.
+
+        This class is but a hollow shell of its former self, and has
+        been removed in Skia.
+
+        Covered by existing tests in css3/filters.
+
+        * platform/graphics/filters/skia/DropShadowImageFilter.cpp:
+        (WebCore::DropShadowImageFilter::DropShadowImageFilter):
+        (WebCore::DropShadowImageFilter::onFilterImage):
+        * platform/graphics/filters/skia/DropShadowImageFilter.h:
+
 2013-01-31  Kentaro Hara  <[email protected]>
 
         Implement WheelEvent::deltaMode

Modified: trunk/Source/WebCore/platform/graphics/filters/skia/DropShadowImageFilter.cpp (141831 => 141832)


--- trunk/Source/WebCore/platform/graphics/filters/skia/DropShadowImageFilter.cpp	2013-02-05 00:39:09 UTC (rev 141831)
+++ trunk/Source/WebCore/platform/graphics/filters/skia/DropShadowImageFilter.cpp	2013-02-05 00:46:59 UTC (rev 141832)
@@ -36,7 +36,7 @@
 namespace WebCore {
 
 DropShadowImageFilter::DropShadowImageFilter(SkScalar dx, SkScalar dy, SkScalar sigma, SkColor color, SkImageFilter* input)
-    : SkSingleInputImageFilter(input)
+    : SkImageFilter(input)
     , m_dx(dx)
     , m_dy(dy)
     , m_sigma(sigma)
@@ -44,7 +44,7 @@
 {
 }
 
-DropShadowImageFilter::DropShadowImageFilter(SkFlattenableReadBuffer& buffer) : SkSingleInputImageFilter(buffer)
+DropShadowImageFilter::DropShadowImageFilter(SkFlattenableReadBuffer& buffer) : SkImageFilter(buffer)
 {
     m_dx = buffer.readScalar();
     m_dy = buffer.readScalar();
@@ -62,7 +62,7 @@
 
 bool DropShadowImageFilter::onFilterImage(Proxy* proxy, const SkBitmap& source, const SkMatrix& matrix, SkBitmap* result, SkIPoint* loc)
 {
-    SkBitmap src = "" source, matrix, loc);
+    SkBitmap src = "" proxy, source, matrix, loc);
     SkAutoTUnref<SkDevice> device(proxy->createDevice(src.width(), src.height()));
     SkCanvas canvas(device.get());
 

Modified: trunk/Source/WebCore/platform/graphics/filters/skia/DropShadowImageFilter.h (141831 => 141832)


--- trunk/Source/WebCore/platform/graphics/filters/skia/DropShadowImageFilter.h	2013-02-05 00:39:09 UTC (rev 141831)
+++ trunk/Source/WebCore/platform/graphics/filters/skia/DropShadowImageFilter.h	2013-02-05 00:46:59 UTC (rev 141832)
@@ -24,12 +24,12 @@
  */
 
 #include "SkColor.h"
+#include "SkImageFilter.h"
 #include "SkScalar.h"
-#include "SkSingleInputImageFilter.h"
 
 namespace WebCore {
 
-class DropShadowImageFilter : public SkSingleInputImageFilter {
+class DropShadowImageFilter : public SkImageFilter {
 public:
     DropShadowImageFilter(SkScalar dx, SkScalar dy, SkScalar sigma, SkColor, SkImageFilter* input = 0);
     SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_PROCS(DropShadowImageFilter)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to