Title: [141838] trunk/Tools
- Revision
- 141838
- Author
- [email protected]
- Date
- 2013-02-04 17:30:14 -0800 (Mon, 04 Feb 2013)
Log Message
Setting tests on flakiness dashboard should invalidate builder.
https://bugs.webkit.org/show_bug.cgi?id=108521
Reviewed by Dirk Pranke.
When you move into a cross builder view, builder should not still be
set. Currently, it is deleted from the internal state, but still shows
up in the url, causing the current state and the hash to not match.
To see this in action, load the flakiness dashboard, select a builder,
and then click on an individual test, to get into individual test view.
The url will still have the builder you selected listed, even though it
is cleared in the UI.
The fix is to consider 'tests' to be a parameter that invalidates builder.
* TestResultServer/static-dashboards/flakiness_dashboard.js:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (141837 => 141838)
--- trunk/Tools/ChangeLog 2013-02-05 01:27:25 UTC (rev 141837)
+++ trunk/Tools/ChangeLog 2013-02-05 01:30:14 UTC (rev 141838)
@@ -1,3 +1,23 @@
+2013-02-04 Julie Parent <[email protected]>
+
+ Setting tests on flakiness dashboard should invalidate builder.
+ https://bugs.webkit.org/show_bug.cgi?id=108521
+
+ Reviewed by Dirk Pranke.
+
+ When you move into a cross builder view, builder should not still be
+ set. Currently, it is deleted from the internal state, but still shows
+ up in the url, causing the current state and the hash to not match.
+
+ To see this in action, load the flakiness dashboard, select a builder,
+ and then click on an individual test, to get into individual test view.
+ The url will still have the builder you selected listed, even though it
+ is cleared in the UI.
+
+ The fix is to consider 'tests' to be a parameter that invalidates builder.
+
+ * TestResultServer/static-dashboards/flakiness_dashboard.js:
+
2013-02-04 Kenneth Rohde Christiansen <[email protected]>
[EFL][WK2] Introduce a WebView class as counterpart for WKViewRef
Modified: trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js (141837 => 141838)
--- trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js 2013-02-05 01:27:25 UTC (rev 141837)
+++ trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js 2013-02-05 01:30:14 UTC (rev 141838)
@@ -263,6 +263,7 @@
};
DB_SPECIFIC_INVALIDATING_PARAMETERS = {
+ 'tests' : 'builder',
'testType': 'builder',
'group': 'builder'
};
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
