Title: [141903] trunk/Source/WebKit/blackberry
- Revision
- 141903
- Author
- [email protected]
- Date
- 2013-02-05 10:44:09 -0800 (Tue, 05 Feb 2013)
Log Message
[BlackBerry] Scrolling performance drops doing page load
https://bugs.webkit.org/show_bug.cgi?id=108949
Patch by Andrew Lo <[email protected]> on 2013-02-05
Reviewed by Yong Li.
Internally reviewed by Jakob Petsovits.
Internal PR 291390.
The intention of this code was to not update non-visible tiles during page load.
Before this patch, the code would update tiles that have already been rendered
during page load.
* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::updateTilesForScrollOrNotRenderedRegion):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/Api/BackingStore.cpp (141902 => 141903)
--- trunk/Source/WebKit/blackberry/Api/BackingStore.cpp 2013-02-05 18:43:50 UTC (rev 141902)
+++ trunk/Source/WebKit/blackberry/Api/BackingStore.cpp 2013-02-05 18:44:09 UTC (rev 141903)
@@ -1682,7 +1682,7 @@
TileMap currentMap = geometry->tileMap();
bool isLoading = m_client->loadState() == WebPagePrivate::Committed;
- bool forceVisible = checkLoading && isLoading;
+ bool updateNonVisibleTiles = !checkLoading || !isLoading;
TileMap::const_iterator end = currentMap.end();
for (TileMap::const_iterator it = currentMap.begin(); it != end; ++it) {
@@ -1711,8 +1711,8 @@
#endif
}
updateTile(tileOrigin, false /*immediate*/);
- } else if (isVisible
- && (forceVisible || !tileBuffer || !tileBuffer->isRendered(tileVisibleContentsRect(index, geometry), geometry->scale()))
+ } else if ((isVisible || updateNonVisibleTiles)
+ && (!tileBuffer || !tileBuffer->isRendered(tileVisibleContentsRect(index, geometry), geometry->scale()))
&& !isCurrentVisibleJob(index, geometry))
updateTile(tileOrigin, false /*immediate*/);
}
Modified: trunk/Source/WebKit/blackberry/ChangeLog (141902 => 141903)
--- trunk/Source/WebKit/blackberry/ChangeLog 2013-02-05 18:43:50 UTC (rev 141902)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2013-02-05 18:44:09 UTC (rev 141903)
@@ -1,3 +1,20 @@
+2013-02-05 Andrew Lo <[email protected]>
+
+ [BlackBerry] Scrolling performance drops doing page load
+ https://bugs.webkit.org/show_bug.cgi?id=108949
+
+ Reviewed by Yong Li.
+ Internally reviewed by Jakob Petsovits.
+
+ Internal PR 291390.
+ The intention of this code was to not update non-visible tiles during page load.
+
+ Before this patch, the code would update tiles that have already been rendered
+ during page load.
+
+ * Api/BackingStore.cpp:
+ (BlackBerry::WebKit::BackingStorePrivate::updateTilesForScrollOrNotRenderedRegion):
+
2013-02-04 Tiancheng Jiang <[email protected]>
[BlackBerry]Adjust fatfinger detection rect size
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
