Title: [142049] trunk
Revision
142049
Author
[email protected]
Date
2013-02-06 16:15:23 -0800 (Wed, 06 Feb 2013)

Log Message

[HTMLTemplateElement] Non </template> end tags should be ignored in "template contents" insertion mode.
https://bugs.webkit.org/show_bug.cgi?id=109090

Reviewed by Adam Barth.

Source/WebCore:

https://dvcs.w3.org/hg/webcomponents/raw-file/38536d37fb82/spec/templates/index.html#template-contents-insertion-mode.

Test added to html5lib suite.

* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processEndTag):

LayoutTests:

* html5lib/resources/template.dat:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (142048 => 142049)


--- trunk/LayoutTests/ChangeLog	2013-02-06 23:59:00 UTC (rev 142048)
+++ trunk/LayoutTests/ChangeLog	2013-02-07 00:15:23 UTC (rev 142049)
@@ -1,3 +1,12 @@
+2013-02-06  Rafael Weinstein  <[email protected]>
+
+        [HTMLTemplateElement] Non </template> end tags should be ignored in "template contents" insertion mode.
+        https://bugs.webkit.org/show_bug.cgi?id=109090
+
+        Reviewed by Adam Barth.
+
+        * html5lib/resources/template.dat:
+
 2013-02-06  Stephen Chenney  <[email protected]>
 
         [Chromium] Test expectations update for Skia change.

Modified: trunk/LayoutTests/html5lib/resources/template.dat (142048 => 142049)


--- trunk/LayoutTests/html5lib/resources/template.dat	2013-02-06 23:59:00 UTC (rev 142048)
+++ trunk/LayoutTests/html5lib/resources/template.dat	2013-02-07 00:15:23 UTC (rev 142049)
@@ -955,3 +955,31 @@
 |         <menu>
 |           <i>
 |             "Foo"
+
+#data
+<body><template></div><div>Foo</div><template></template><tr></tr>
+#errors
+#document
+| <html>
+|   <head>
+|   <body>
+|     <template>
+|       #document-fragment
+|         <div>
+|           "Foo"
+|         <template>
+|           #document-fragment
+
+#data
+<body><div><template></div><tr><td>Foo</td></tr></template>
+#errors
+#document
+| <html>
+|   <head>
+|   <body>
+|     <div>
+|       <template>
+|         #document-fragment
+|           <tr>
+|             <td>
+|               "Foo"

Modified: trunk/Source/WebCore/ChangeLog (142048 => 142049)


--- trunk/Source/WebCore/ChangeLog	2013-02-06 23:59:00 UTC (rev 142048)
+++ trunk/Source/WebCore/ChangeLog	2013-02-07 00:15:23 UTC (rev 142049)
@@ -1,3 +1,17 @@
+2013-02-06  Rafael Weinstein  <[email protected]>
+
+        [HTMLTemplateElement] Non </template> end tags should be ignored in "template contents" insertion mode.
+        https://bugs.webkit.org/show_bug.cgi?id=109090
+
+        Reviewed by Adam Barth.
+
+        https://dvcs.w3.org/hg/webcomponents/raw-file/38536d37fb82/spec/templates/index.html#template-contents-insertion-mode.
+
+        Test added to html5lib suite.
+
+        * html/parser/HTMLTreeBuilder.cpp:
+        (WebCore::HTMLTreeBuilder::processEndTag):
+
 2013-02-06  Alexandre Elias  <[email protected]>
 
         Make ScrollView::paint() clip by visibleContentRect

Modified: trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp (142048 => 142049)


--- trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp	2013-02-06 23:59:00 UTC (rev 142048)
+++ trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp	2013-02-07 00:15:23 UTC (rev 142049)
@@ -2278,8 +2278,8 @@
             processTemplateEndTag(token);
             return;
         }
-        setInsertionMode(InBodyMode);
-        processEndTag(token);
+
+        break;
 #else
         ASSERT_NOT_REACHED();
 #endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to